Commit Graph

28760 Commits

Author SHA1 Message Date
82ce384801 Add improvement directions to PC and Call framework metrics
Bug: webrtc:10138
Change-Id: Ib957950df6e7490a15da0345fcd73e037c1a5b19
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153892
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29278}
2019-09-24 08:25:44 +00:00
834a554962 Include module_common_types.h only where needed
Bug: None
Change-Id: I73d493f8f186b429c7be808f4dfac0398f150931
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153891
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29277}
2019-09-24 08:22:38 +00:00
bf5ee00f8d Disable prerender smoothing in MultiCodecReceiveTest.
Avoids frame dropping in render queue.


Bug: webrtc:10828
Change-Id: I9e09fc2faee4626c8d60c152840b4208dbb89dc4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153880
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29276}
2019-09-24 08:12:09 +00:00
a8e6f34323 Delete the BasicPortAllocator constructor that enables gturn
Mainly an update of the BasicPortAllocator tests. Other code related
to gturn may be deleted in a followup cl.

Bug: None
Change-Id: I72146c8faf30c1a9d03d320d75af91984f797a7e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153485
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Qingsi Wang <qingsi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29275}
2019-09-24 07:46:28 +00:00
f2690a15b7 Delete unused method SendSideBandwidthEstimation::UpdateReceiverBlock
Bug: None
Change-Id: Ieca6dd99c7e5e06f1bb2306686a6a0f1e788e22f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153844
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29274}
2019-09-24 06:37:33 +00:00
bc646eee20 Roll chromium_revision 09b71d3027..1d4ed9e21d (698937:699120)
Change log: 09b71d3027..1d4ed9e21d
Full diff: 09b71d3027..1d4ed9e21d

Changed dependencies
* src/base: fd7a9964ce..f0ff2fdcdc
* src/build: e36310e10a..04fbb767db
* src/ios: 943df620c3..ffd424e16f
* src/testing: b5bcb0b1be..f8d9a10f35
* src/third_party: 86371a345d..bb199fab1a
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5073a9e8d7..28837bfd86
* src/third_party/depot_tools: b5578f4f0b..6f18e68719
* src/third_party/libvpx/source/libvpx: c094391e95..b8d86733e9
* src/tools: 41e4d4d7ca..3b53e61b51
* src/tools/swarming_client: 96f125709a..885b3febcc
DEPS diff: 09b71d3027..1d4ed9e21d/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,marpan@webrtc.org, jianj@chromium.org,
BUG=None

Change-Id: I108153b1a45b34a9f71a0c182f11546fcb426f1d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154280
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29273}
2019-09-24 00:47:39 +00:00
cd40de94ef Delete the deprecated GetTransportParametersOffer().
Transport parameters are no longer retreived using this method, and no
implementations currently override it.

Bug: webrtc:9719
Change-Id: Iba0e1c7a320266f199aab6f2add36c6a22b48458
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154004
Commit-Queue: Bjorn Mellem <mellem@webrtc.org>
Commit-Queue: Seth Hampson <shampson@webrtc.org>
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29272}
2019-09-23 20:52:18 +00:00
988e63eb06 Proxy OnRtcpPacketReceived to the worker thread in channel tests.
https://webrtc-review.googlesource.com/c/src/+/152740 changed the way
OnRtcpPacketReceived is invoked, so that Channel no longer handles the
hop to the worker thread internally.  This change updates the test to
hop to the worker thread before calling channel, which fixes a test-only
tsan failure.

Bug: webrtc:10983
Change-Id: Ia31920791fc6eeee86c0d59aa091d708d706bcf0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154244
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Commit-Queue: Bjorn Mellem <mellem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29271}
2019-09-23 19:59:48 +00:00
aab43dbd8b Roll chromium_revision 82de2e611e..09b71d3027 (698813:698937)
Change log: 82de2e611e..09b71d3027
Full diff: 82de2e611e..09b71d3027

Changed dependencies
* src/base: 091e0e09bd..fd7a9964ce
* src/build: c05af3e14f..e36310e10a
* src/ios: 1388c19231..943df620c3
* src/testing: 07c1a1e3af..b5bcb0b1be
* src/third_party: 4d252f8a42..86371a345d
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/fa002e6324..5073a9e8d7
* src/third_party/depot_tools: 7cb60e812f..b5578f4f0b
* src/third_party/harfbuzz-ng/src: 170b5dd856..c1a585fab0
* src/tools: 33e031d574..41e4d4d7ca
DEPS diff: 82de2e611e..09b71d3027/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I034e2d278b09d484292b7ad0b10af8b42d236da5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154243
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29270}
2019-09-23 18:34:29 +00:00
a99b89b41c AEC3: Echo remover handles multiple capture signals.
Echo remover processes all microphone signals. Suppression gains are
computed separately for each capture signal. The minimum gains determine
the final suppression gains applied.

Only the first channel is synthesized. A follow-up CL will add the
synthesis of the remaining channels.

Bug: webrtc:10913
Change-Id: Ife7e74c9a9c6c208fca3992e3cfa840b6b7afcfa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153526
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29269}
2019-09-23 14:43:50 +00:00
3433d56d71 Reduce resolution and bitrates of smoke test
The high bitrate smoketest is flaky on some platforms,
this CL reduces the resolution and bitrates to make it less
flaky.

Bug: webrtc:10975
Change-Id: Id271b3c68abfa2011c207e7883cfcb230b1d3e36
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153845
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Johannes Kron <kron@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29268}
2019-09-23 13:49:38 +00:00
f7457e55fe Store PacketBuffer by value instead of as reference counted object
Bug: None
Change-Id: I5a594972e8a8dad731c927a1a374301e549f5d71
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153887
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29267}
2019-09-23 13:28:09 +00:00
3c5f91b748 Roll chromium_revision e74d6b592b..82de2e611e (698711:698813)
Change log: e74d6b592b..82de2e611e
Full diff: e74d6b592b..82de2e611e

Changed dependencies
* src/base: 8fe786af34..091e0e09bd
* src/build: 2a85930b01..c05af3e14f
* src/third_party: 1e00adb287..4d252f8a42
* src/third_party/depot_tools: d4d1ba4971..7cb60e812f
* src/tools: c164291581..33e031d574
DEPS diff: e74d6b592b..82de2e611e/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I3eb112afcd3b79b3c877ad593e20bda1763bf936
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154169
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29266}
2019-09-23 04:23:45 +00:00
289f3136a5 Roll chromium_revision 5cbf4ebd59..e74d6b592b (698593:698711)
Change log: 5cbf4ebd59..e74d6b592b
Full diff: 5cbf4ebd59..e74d6b592b

Changed dependencies
* src/base: 7390b2c043..8fe786af34
* src/build: 0bf2b96dc4..2a85930b01
* src/ios: 162f8951a2..1388c19231
* src/testing: ae682ebd48..07c1a1e3af
* src/third_party: 6fbd6866c4..1e00adb287
* src/third_party/depot_tools: 7735f52c6d..d4d1ba4971
* src/tools: f2bc23dbbd..c164291581
Added dependency
* src/third_party/android_deps/libs/androidx_test_uiautomator_uiautomator
DEPS diff: 5cbf4ebd59..e74d6b592b/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ib5cc225aed75ff023172e96901778a8b1024990c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154061
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29265}
2019-09-21 02:44:04 +00:00
4854b9f804 Roll chromium_revision 230cc8f7e4..5cbf4ebd59 (698466:698593)
Change log: 230cc8f7e4..5cbf4ebd59
Full diff: 230cc8f7e4..5cbf4ebd59

Changed dependencies
* src/base: b70d15bab8..7390b2c043
* src/build: ceed4a086a..0bf2b96dc4
* src/ios: 1ccb60e1f4..162f8951a2
* src/testing: bf89d559c0..ae682ebd48
* src/third_party: e6a4066287..6fbd6866c4
* src/tools: 9ee4313e8c..f2bc23dbbd
DEPS diff: 230cc8f7e4..5cbf4ebd59/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I46c846483750f7a0d711774e5db66ec0763c5a18
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154020
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29264}
2019-09-20 20:31:44 +00:00
37ad5ab940 Change DatagramTransportInterface methods to pure virtual.
These methods are implemented everywhere, and no longer need to provide
default implementations.

Bug: webrtc:9719
Change-Id: I2b33ace17696ec832a9936cf02a81c4973158046
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154003
Commit-Queue: Bjorn Mellem <mellem@webrtc.org>
Commit-Queue: Seth Hampson <shampson@webrtc.org>
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29263}
2019-09-20 20:11:24 +00:00
88db835278 Change DataChannelTransportInterface/Sink methods to pure virtual.
These methods are implemented everywhere, so they no longer need to
provide default implementations.

Bug: webrtc:9719
Change-Id: Idf67a78010a55f545d882793d0d6edbccfae525b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154002
Commit-Queue: Bjorn Mellem <mellem@webrtc.org>
Commit-Queue: Seth Hampson <shampson@webrtc.org>
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29262}
2019-09-20 20:06:14 +00:00
d702231268 Cleanup deprecated monitoring of MediaTransport state.
PeerConnection now watches when data channels become ready to send
through its implementation of DataChannelSink, and no longer needs to
monitor the MediaTransport state.

Bug: webrtc:9719
Change-Id: I3e17747eb03926a3791c204bf5a1d2dc67855c09
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154001
Commit-Queue: Seth Hampson <shampson@webrtc.org>
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29261}
2019-09-20 19:44:20 +00:00
5ac329c8aa Cap h264 fuzzer input to 200k.
Verified it no longer times out on the input that spawned the bug.

Bug: chromium:1005853
Change-Id: I5b0ab25aaefdc8b451b4d976b1c3b8f8d38f13e9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153840
Reviewed-by: Benjamin Wright <benwright@webrtc.org>
Commit-Queue: Benjamin Wright <benwright@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29260}
2019-09-20 18:15:00 +00:00
03bbef5e1f Fix accidental change of transport time metric
The transport time metric was accidentially changed by the CL
https://webrtc-review.googlesource.com/c/src/+/153660

This CL restore the transport time metric to how it has been
measured before, that is, time from encoder output to decoder input.

Bug: webrtc:10975
Change-Id: I66f022f26976451d28c0374b22849f14f9c02378
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153886
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Johannes Kron <kron@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29259}
2019-09-20 15:56:55 +00:00
c2e9d84822 Roll chromium_revision 303c57cf17..230cc8f7e4 (698351:698466)
Change log: 303c57cf17..230cc8f7e4
Full diff: 303c57cf17..230cc8f7e4

Changed dependencies
* src/base: 8185ff85d6..b70d15bab8
* src/build: 9417d7b115..ceed4a086a
* src/ios: 5173d293d5..1ccb60e1f4
* src/testing: f461f416c2..bf89d559c0
* src/third_party: 3f8d8226d0..e6a4066287
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/54ac3634e8..fa002e6324
* src/third_party/freetype/src: 04ebb2a000..5327092bb2
* src/tools: 2be0437563..9ee4313e8c
DEPS diff: 303c57cf17..230cc8f7e4/DEPS

Clang version changed b4160cb94c54f0b31d0ce14694950dac7b6cd83f:13bdae8541c3fc5acf6ee7de78ec5ab8446848e4
Details: 303c57cf17..230cc8f7e4/tools/clang/scripts/update.py

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ibd10426a9a77cea093ee8fca635348e320257a6c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153960
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29258}
2019-09-20 14:48:00 +00:00
27b0e0d6b3 Remove obsolete todo comment in simulcast.h
Bug: none
Change-Id: I1c51919564a8b8bae842fa6421054a2b1faba42a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153885
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29257}
2019-09-20 14:17:20 +00:00
544dfb5a97 Delete isac GetBandwidthInfo/SetBandwidthInfo
Bug: webrtc:10098
Change-Id: I4a56cdc6d081b15a1fc52cba2051783daf4e5ae3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153881
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29256}
2019-09-20 13:53:52 +00:00
ef83cc5458 Add fuzzer testing for Dependency Descriptor rtp header extension
Bug: webrtc:10342
Change-Id: I46c61b9a137a7148ed80ad38da62132dacb270f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153662
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29255}
2019-09-20 12:40:24 +00:00
04fd21513b Cleanup passing rtp packet to ulpfec receiver.
Pass RtpPacket class of header and raw packet separately

Bug: None
Change-Id: Id6d107db0e3751ff3dec87321ce6f850da0ee33a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153740
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29254}
2019-09-20 11:09:11 +00:00
0cff4fce55 Removed unused frame_size param from RtpFrameObject ctor.
Bug: webrtc:10979
Change-Id: Idde493dc7f5165e3ca173d5a38861b444b5904a4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153668
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29253}
2019-09-20 10:56:01 +00:00
48b32b748e Delete support for enabling adaptive isac mode
This appears unused. If deleted, other code related to isac bandwidth
estimation becomes unused and may be deleted in followup cls.

Bug: webrtc:10098
Change-Id: Ifeac2e90de895b12c337ea28cc33704350b9abf4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153667
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29252}
2019-09-20 10:41:09 +00:00
b5e4785464 RtpFrameObject now takes an EncodedImageBuffer in its ctor.
Bug: webrtc:10979
Change-Id: Ibc8b4a524ca95b5faa8850a41df8f2f0136a2969
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153666
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29251}
2019-09-20 10:15:01 +00:00
fb59a6aa3f Return const char* from ToString(RTCErrorType error).
Returning absl::string_view causes problems to the Chromium/WebRTC
component build because absl::operator<< needs to be exported.

This CL switches to `const char*` which should be enough to avoid
to generate temporaries.

Bug: webrtc:9419
Change-Id: If169a6f95c7efd21ac8ce108c7f2f80a76ff2313
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153842
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29250}
2019-09-20 08:27:52 +00:00
e0b31677b6 Delete dead code inside #ifdef WEBRTC_ISAC_FIX_NB_CALLS_ENABLED
Bug: None
Change-Id: If31f2a5e4a2536b3c7fda596f2c251e8074a18d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153671
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29249}
2019-09-20 07:40:10 +00:00
feee1e4c36 Add flag to APM to force multichannel even with AEC3
Currently, APM fakes multichannel in two ways:
 - With injected AECs, capture processing is only performed on the left
channel. The result is copied into the other channels.
 - With multichannel render audio, all channels are mixed into one
before analysing.

This CL adds a flag to disable these behaviors, ensuring proper
multichannel processing happens throughout the APM pipeline.

Adds killswitches to separately disable render / capture multichannel.

Additionally - AEC3 currently crashes when running with multichannel.
This CL adds the missing pieces to at least have it run without
triggering any DCHECKS, including making the high pass filter properly
handle multichannel.

Bug: webrtc:10913, webrtc:10907
Change-Id: I38795bf8f312b959fcc816a056fba2c68d4e424d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/152483
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29248}
2019-09-20 06:36:12 +00:00
e24557f51e Declare api:libjingle_peerconnection_api dependency on media:media_base
Deletes one of the two // nogncheck comments in peerconnection_interface.h.

Bug: webrtc:8733
Change-Id: I7cda4957206c4c5f36261517718b526734bad68a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150798
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Benjamin Wright <benwright@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29247}
2019-09-20 06:29:22 +00:00
2051b8bf05 Roll chromium_revision a536fa4a4a..303c57cf17 (698214:698351)
Change log: a536fa4a4a..303c57cf17
Full diff: a536fa4a4a..303c57cf17

Changed dependencies
* src/base: 2670e49cfb..8185ff85d6
* src/build: df75aae7da..9417d7b115
* src/ios: 425a78aea9..5173d293d5
* src/testing: 6099b3ff92..f461f416c2
* src/third_party: 8f7ec0c439..3f8d8226d0
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4f96a26c2f..54ac3634e8
* src/third_party/depot_tools: 2c80d01be6..7735f52c6d
* src/tools: 4357bb3217..2be0437563
DEPS diff: a536fa4a4a..303c57cf17/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Id5610d7f41fbe939e0b205f994761c1b16b1ca8c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153820
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29246}
2019-09-20 04:41:10 +00:00
95c538f17b Roll chromium_revision fc1e948f93..a536fa4a4a (698112:698214)
Change log: fc1e948f93..a536fa4a4a
Full diff: fc1e948f93..a536fa4a4a

Changed dependencies
* src/base: e766beee3d..2670e49cfb
* src/build: e2f0a70047..df75aae7da
* src/ios: 3efb3bffed..425a78aea9
* src/testing: 0b2bff4e23..6099b3ff92
* src/third_party: 81ec316b3b..8f7ec0c439
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2ad535693f..4f96a26c2f
* src/third_party/depot_tools: c6be56eced..2c80d01be6
* src/tools: 142e5efe9a..4357bb3217
DEPS diff: fc1e948f93..a536fa4a4a/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ic80366d287c04b7f4b261ec5d58b5de84f7359a9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153761
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29245}
2019-09-19 22:43:37 +00:00
f288c8ee6e Roll chromium_revision cf1a2beb4b..fc1e948f93 (697976:698112)
Change log: cf1a2beb4b..fc1e948f93
Full diff: cf1a2beb4b..fc1e948f93

Changed dependencies
* src/base: 3fe4a418db..e766beee3d
* src/build: 76a4ca1e1b..e2f0a70047
* src/ios: 8de41b2ec5..3efb3bffed
* src/testing: 3f13136080..0b2bff4e23
* src/third_party: 90b037fc6f..81ec316b3b
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/033994d4a3..2ad535693f
* src/tools: 97ef1887ae..142e5efe9a
DEPS diff: cf1a2beb4b..fc1e948f93/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ibf08e9d45f2f11894b088c8a18781a10b64d8523
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153722
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29244}
2019-09-19 18:34:57 +00:00
c12db81e79 Add frame receive to frame rendered metric to video_quality_analyzer
Bug: webrtc:10975
Change-Id: I6b36566efbbb52d27ca6cb44cb3b40aaf0cacb7b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153660
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Johannes Kron <kron@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29243}
2019-09-19 14:43:04 +00:00
f0be5b5380 Make GetBitstream non-virtual since it is no longer needed for testing.
Bug: webrtc:10979
Change-Id: Id313c7fddbec40b9f19dae95f736379b872e3082
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153663
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29242}
2019-09-19 14:04:09 +00:00
40de3cc5ef Propagating TargetRate struct to BitrateAllocator.
Bug: webrtc:9883
Change-Id: I443ac7f1ef0f933e2165fdb2f912d314acc7f2f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153345
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29241}
2019-09-19 14:03:04 +00:00
ac315b283c Add support for max/min encode bitrate to peer connection quality test
Bug: webrtc:10975
Change-Id: I9be551040936d2e9b5e41dd1bbaea2ad4afd36ed
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153481
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Johannes Kron <kron@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29240}
2019-09-19 13:47:29 +00:00
6a092637f0 Delete obsolete isac "assign" api
Bug: None
Change-Id: I116e3f4b89e2c1e1f0d06e2ff5d58d2a50e2aadb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153665
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29239}
2019-09-19 13:26:26 +00:00
d8ffbb0bc4 Roll chromium_revision afdb2e7a8b..cf1a2beb4b (697871:697976)
Change log: afdb2e7a8b..cf1a2beb4b
Full diff: afdb2e7a8b..cf1a2beb4b

Changed dependencies
* src/build: 050608ea95..76a4ca1e1b
* src/ios: 797d97f55d..8de41b2ec5
* src/testing: c223ceca68..3f13136080
* src/third_party: d7037a0728..90b037fc6f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6a17fd7fb7..033994d4a3
* src/tools: efcee32728..97ef1887ae
DEPS diff: afdb2e7a8b..cf1a2beb4b/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I8653cfade8885b6166110d4d72819e30e7d21ea4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153700
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29238}
2019-09-19 12:32:23 +00:00
76161f7446 Move the call to GetBitstream out of the RtpFrameObject ctor.
Bug: webrtc:10979
Change-Id: I9159eb04d4a371e8ed8f932a989d6b884faa7be7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153661
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Philip Eliasson <philipel@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29237}
2019-09-19 12:08:04 +00:00
14137a1064 Adds logging of audio sessions status on the recording side in ADM for Android.
Goal is to be able to retrieve more details about possible microphone conflicts in
cases where Init/Start of audio recording fails.

Only supported on Android N and higher.

Also adds new boolean UMA histogram called WebRTC.Audio.SourceMatchesRecordingSession.
Its value is stored after the recording session has been stopped.

Does not affect the media flow or functionality of the ADM. Time to start audio should
not be affected either since the new check and logging takes place on a separate
ExecutorService thread.

See go/webrtc-adm-android for more details and examples.

Bug: webrtc:10971
Change-Id: Ia80c1534e326907a1582824225d5f58caa016922
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150793
Commit-Queue: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Alex Glaznev <glaznev@webrtc.org>
Reviewed-by: Paulina Hensman <phensman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29236}
2019-09-19 11:35:10 +00:00
86873f0cd3 Improve field trial error message.
Bug: None
Change-Id: I112cda6fead3d68136fd7be551686e40191fa87f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153482
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29235}
2019-09-19 09:38:49 +00:00
e942b141d8 New build target api:media_interface
Bug: webrtc:8733
Change-Id: I84bbefb1a5ef8e592db29b79499d60ac80c23464
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153180
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29234}
2019-09-19 09:32:27 +00:00
0a5ed896e2 Adds remote estimates to rtc event log.
Bug: webrtc:10742
Change-Id: I0db998a05492603fcdeedca780d9ee3d64aa00d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/151651
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29233}
2019-09-19 09:22:37 +00:00
6ed60e39dc Implement Dependency Descriptor writer
Bug: webrtc:10342
Change-Id: I561825265c0990864e1d16aeed4afbdd98871940
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153350
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29232}
2019-09-19 08:51:40 +00:00
489843f1b1 Improve trendline estimator logging.
Bug: None
Change-Id: I7cc6dc7f45ddb7325252516490436bea1ec8d250
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153521
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29231}
2019-09-19 08:33:11 +00:00
693bf1eea1 Delete modules/rtp_rtcp local DivideRoundToNearest in favor on one in rtc_base
To resolve a TODO

Bug: None
Change-Id: I90e10af24718e1aafd7e72076731b34c1110bb4b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153524
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29230}
2019-09-19 08:10:12 +00:00
bd24260791 Roll chromium_revision eae7ecf757..afdb2e7a8b (697744:697871)
Change log: eae7ecf757..afdb2e7a8b
Full diff: eae7ecf757..afdb2e7a8b

Changed dependencies
* src/base: 01355d2940..3fe4a418db
* src/build: 71ed08eea6..050608ea95
* src/ios: e12f797b06..797d97f55d
* src/testing: 74e29479c8..c223ceca68
* src/third_party: a939fa9d82..d7037a0728
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/cbc960899a..6a17fd7fb7
* src/third_party/depot_tools: 3f79763629..c6be56eced
* src/tools: 8c0c370d66..efcee32728
DEPS diff: eae7ecf757..afdb2e7a8b/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ia0e447ae02cf1a0a9a1e1a49deca4762b486fd81
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/153620
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#29229}
2019-09-19 02:33:30 +00:00