zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change DatagramTransportInterface methods to pure virtual.

Browse Source 
These methods are implemented everywhere, and no longer need to provide
default implementations.

Bug: webrtc:9719
Change-Id: I2b33ace17696ec832a9936cf02a81c4973158046
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154003
Commit-Queue: Bjorn Mellem <mellem@webrtc.org>
Commit-Queue: Seth Hampson <shampson@webrtc.org>
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29263}
This commit is contained in:
Bjorn A Mellem
2019-09-20 12:38:01 -07:00
committed by Commit Bot
parent 88db835278
commit 37ad5ab940
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
api/transport/datagram_transport_interface.h
View File

@ -58,11 +58,10 @@ class DatagramSinkInterface {
virtual void OnDatagramSent(DatagramId datagram_id) = 0;
// Called when datagram is ACKed.
// TODO(sukhanov): Make pure virtual.
virtual void OnDatagramAcked(const DatagramAck& datagram_ack) {}
virtual void OnDatagramAcked(const DatagramAck& datagram_ack) = 0;
// Called when a datagram is lost.
virtual void OnDatagramLost(DatagramId datagram_id) {}
virtual void OnDatagramLost(DatagramId datagram_id) = 0;
};
// Datagram transport allows to send and receive unreliable packets (datagrams)
@ -140,9 +139,7 @@ class DatagramTransportInterface : public DataChannelTransportInterface {
// For clients, the parameters echo the server configuration used to create
// the client, possibly removing any fields or parameters which the client
// does not understand.
//
// TODO(mellem): Make pure virtual.
virtual std::string GetTransportParameters() const { return ""; }
virtual std::string GetTransportParameters() const = 0;
};
} // namespace webrtc