df1edc9ae0
API description: PeerConnection description
...
Since we want most users to use the PeerConnection API, this is the
part that we should document.
If we want people to use other APIs, we can add to the file.
Bug: webrtc:12674
Change-Id: Icf14f218cf51c640e6f846f10b49dff84106dc21
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215066
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33707}
2021-04-13 12:51:47 +00:00
11b308909a
Roll chromium_revision 74f869d04b..0bde1c5411 (871745:871876)
...
Change log: 74f869d04b..0bde1c541174f869d04b..0bde1c5411ca7b938131..b315c8b33379006bea8b..b19b6ba7f3b10d9dc408..5767a28ef021d746be78..e5f83f632dcd3c7ea8d4..99b2d6c6cahttps://chromium.googlesource.com/catapult.git/+log/8680ff0509..db7e7f8a5d
* src/third_party/depot_tools: 057831ef1f..9955936084965f8ecbfd..486a4a6be555b8544079..7ebfe8df7074f869d04b..0bde1c5411TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: If24c0510cf841abdb3a8c31a1f410b7c55e5c19c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215120
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33706}
2021-04-13 11:02:50 +00:00
1fded2f5ad
dcsctp: Fix build dependencies
...
Adding fuzzers to the build made "gn gen --check" discover a lot
of dependency errors between various components of dcSCTP.
Bug: webrtc:12614
Change-Id: I0b2dd7321aec2624da417f413c727bd11b4743e5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215003
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Victor Boivie <boivie@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33705}
2021-04-13 10:14:00 +00:00
e082984fee
Add death test for WrappingAsyncResolver
...
Bug: webrtc:12598
Change-Id: Iff70cc2c53da5098514853eb6034874ee2e10b2c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214961
Reviewed-by: Markus Handell <handellm@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33704}
2021-04-13 10:11:50 +00:00
a168bb9032
Add index.md documentation page for PC level test framework
...
Bug: webrtc:12675
Change-Id: I779bde07683c33a7cc0dc38033235718e95b12b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214981
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33703}
2021-04-13 09:59:50 +00:00
696cea0843
Refactor some RtpSender-level tests into RtpRtcp-level tests
...
This prepares for ability to defer sequence number assignment to after
the pacing stage - a scenario where the RtpRtcp module rather than than
RTPSender class has responsibility for sequence numbering.
Bug: webrtc:11340
Change-Id: Ife88f60258b9b7cfd9dbd3326f02ac34da8f7603
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214967
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33702}
2021-04-13 08:37:14 +00:00
5fe0b372ba
Roll chromium_revision 7e70585ca5..74f869d04b (871605:871745)
...
Change log: 7e70585ca5..74f869d04b7e70585ca5..74f869d04b8fc5bf1d4a..ca7b9381315d0017aeec..79006bea8b0b3d0c7d99..b10d9dc408f3e0beba79..21d746be78fcd6536576..cd3c7ea8d44fb42ae52e..280d5fd0df1b78913ea7..31ac7832bf7ad58b1ed2..55b85440797e70585ca5..74f869d04bTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I2a9ec3ad3e56a026b59cfc672c05ba5dbf12f5f1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215103
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33701}
2021-04-13 02:44:09 +00:00
c8cf0a6080
Remove MDNS message implementation
...
No customers have been identified.
Bug: chromium:1197965
Change-Id: Ia3063d0909c718ffb8e824225c8c60180551115a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214963
Reviewed-by: Taylor <deadbeef@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33700}
2021-04-12 22:24:56 +00:00
eff79cfc75
Roll chromium_revision 2dffe06711..7e70585ca5 (871492:871605)
...
Change log: 2dffe06711..7e70585ca52dffe06711..7e70585ca5db151ac5c5..8fc5bf1d4a399fa5ad74..5d0017aeec3ba3cf8e84..0b3d0c7d9985de9f3f89..f3e0beba7932fe4ba2c6..fcd6536576https://chromium.googlesource.com/catapult.git/+log/ab687ea7be..8680ff0509
* src/third_party/perfetto: 9511660f93..1b78913ea778b6ac0da4..7ad58b1ed22dffe06711..7e70585ca5TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I24fd4a5f915090139cbe96d385357401e3b44160
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215022
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33699}
2021-04-12 21:06:37 +00:00
067dce7acc
Fix processing of dropped frame for runtime added participant
...
Bug: webrtc:12247
Change-Id: I0fe5cad8f755bda899e81b31e255f24816bf33bc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215061
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33698}
2021-04-12 20:22:36 +00:00
dc53ce63a1
Revert "Add addr in error msg if stun sock sent with error"
...
This reverts commit 9ff75a6206142fbe17997bb092f8ec5485c2a084.
Reason for revert: Breaks downstream project.
Original change's description:
> Add addr in error msg if stun sock sent with error
>
> Before:
> ```
> (stun_port.cc:596): sendto : [0x00000041] No route to host
> ```
>
> After:
> ```
> (stun_port.cc:598): UDP send of 20 bytes to host stun1.l.google.com:19302 (74.125.200.127:19302) failed with error 65 : [0x00000041] No route to host
> ```
>
> Bug: None
> Change-Id: Ibcd487e97b37677225814562df30af66f655cddb
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215000
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com >
> Cr-Commit-Position: refs/heads/master@{#33694}
TBR=hta@webrtc.org ,yura.yaroshevich@gmail.com
Change-Id: I3dacddfd60f4406609ed79845a545959d6208bcc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215062
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33697}
2021-04-12 19:51:20 +00:00
80939356cc
Roll chromium_revision 34f3c82122..2dffe06711 (867171:871492)
...
Change log: 34f3c82122..2dffe0671134f3c82122..2dffe06711cbc66d2601..db151ac5c50cea8e20fb..399fa5ad7499a2527e91..5dbd89c9d9cbf9455e83..d0f33885a2cc80b4ac98..08f35c8514b106ab6171..3ba3cf8e849511ad8751..85de9f3f89d4a93a19d0..32fe4ba2c62@0.10.cr0
* src/third_party/android_deps/libs/com_google_auto_service_auto_service: version:1.0-rc6.cr0..version:2@1.0-rc6.cr0
* src/third_party/android_deps/libs/com_google_auto_service_auto_service_annotations: version:1.0-rc6.cr0..version:2@1.0-rc6.cr0
* src/third_party/android_deps/libs/com_google_auto_value_auto_value_annotations: version:1.7.cr0..version:2@1.7.cr0
* src/third_party/android_deps/libs/com_google_code_findbugs_jformatstring: version:3.0.0.cr0..version:2@3.0.0.cr0
* src/third_party/android_deps/libs/com_google_code_findbugs_jsr305: version:3.0.2.cr0..version:2@3.0.2.cr0
* src/third_party/android_deps/libs/com_google_code_gson_gson: version:2.8.0.cr0..version:2@2.8.0.cr0
* src/third_party/android_deps/libs/com_google_dagger_dagger: version:2.30.cr0..version:2@2.30.cr0
* src/third_party/android_deps/libs/com_google_dagger_dagger_compiler: version:2.30.cr0..version:2@2.30.cr0
* src/third_party/android_deps/libs/com_google_dagger_dagger_producers: version:2.30.cr0..version:2@2.30.cr0
* src/third_party/android_deps/libs/com_google_dagger_dagger_spi: version:2.30.cr0..version:2@2.30.cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_annotation: version:2.4.0.cr0..version:2@2.4.0.cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_annotations: version:2.4.0.cr0..version:2@2.4.0.cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_check_api: version:2.4.0.cr0..version:2@2.4.0.cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_core: version:2.4.0.cr0..version:2@2.4.0.cr0
* src/third_party/android_deps/libs/com_google_errorprone_error_prone_type_annotations: version:2.4.0.cr0..version:2@2.4.0.cr0
* src/third_party/android_deps/libs/com_google_errorprone_javac: version:9+181-r4173-1.cr0..version:2@9+181-r4173-1.cr0
* src/third_party/android_deps/libs/com_google_errorprone_javac_shaded: version:9-dev-r4023-3.cr0..version:2@9-dev-r4023-3.cr0
* src/third_party/android_deps/libs/com_google_firebase_firebase_annotations: version:16.0.0.cr0..version:2@16.0.0.cr0
* src/third_party/android_deps/libs/com_google_firebase_firebase_common: version:19.5.0.cr0..version:2@19.5.0.cr0
* src/third_party/android_deps/libs/com_google_firebase_firebase_components: version:16.1.0.cr0..version:2@16.1.0.cr0
* src/third_party/android_deps/libs/com_google_firebase_firebase_encoders: version:16.1.0.cr0..version:2@16.1.0.cr0
* src/third_party/android_deps/libs/com_google_firebase_firebase_encoders_json: version:17.1.0.cr0..version:2@17.1.0.cr0
* src/third_party/android_deps/libs/com_google_firebase_firebase_iid: version:21.0.1.cr0..version:2@21.0.1.cr0
* src/third_party/android_deps/libs/com_google_firebase_firebase_iid_interop: version:17.0.0.cr0..version:2@17.0.0.cr0
* src/third_party/android_deps/libs/com_google_firebase_firebase_installations: version:16.3.5.cr0..version:2@16.3.5.cr0
* src/third_party/android_deps/libs/com_google_firebase_firebase_installations_interop: version:16.0.1.cr0..version:2@16.0.1.cr0
* src/third_party/android_deps/libs/com_google_firebase_firebase_measurement_connector: version:18.0.0.cr0..version:2@18.0.0.cr0
* src/third_party/android_deps/libs/com_google_firebase_firebase_messaging: version:21.0.1.cr0..version:2@21.0.1.cr0
* src/third_party/android_deps/libs/com_google_googlejavaformat_google_java_format: version:1.5.cr0..version:2@1.5.cr0
* src/third_party/android_deps/libs/com_google_guava_failureaccess: version:1.0.1.cr0..version:2@1.0.1.cr0
* src/third_party/android_deps/libs/com_google_guava_guava: version:30.1-jre.cr0..version:2@30.1-jre.cr0
* src/third_party/android_deps/libs/com_google_guava_guava_android: version:30.1-android.cr0..version:2@30.1-android.cr0
* src/third_party/android_deps/libs/com_google_guava_listenablefuture: version:1.0.cr0..version:2@1.0.cr0
* src/third_party/android_deps/libs/com_google_j2objc_j2objc_annotations: version:1.3.cr0..version:2@1.3.cr0
* src/third_party/android_deps/libs/com_google_protobuf_protobuf_java: version:3.4.0.cr0..version:2@3.4.0.cr0
* src/third_party/android_deps/libs/com_google_protobuf_protobuf_javalite: version:3.13.0.cr0..version:2@3.13 .0.cr0
* src/third_party/android_deps/libs/com_googlecode_java_diff_utils_diffutils: version:1.3.0.cr0..version:2@1.3.0.cr0
* src/third_party/android_deps/libs/com_squareup_javapoet: version:1.13.0.cr0..version:2@1.13 .0.cr0
* src/third_party/android_deps/libs/com_squareup_javawriter: version:2.1.1.cr0..version:2@2.1.1.cr0
* src/third_party/android_deps/libs/javax_annotation_javax_annotation_api: version:1.3.2.cr0..version:2@1.3.2.cr0
* src/third_party/android_deps/libs/javax_annotation_jsr250_api: version:1.0.cr0..version:2@1.0.cr0
* src/third_party/android_deps/libs/javax_inject_javax_inject: version:1.cr0..version:2@1.cr0
* src/third_party/android_deps/libs/nekohtml_nekohtml: version:1.9.6.2.cr0..version:2@1.9.6.2.cr0
* src/third_party/android_deps/libs/nekohtml_xercesminimal: version:1.9.6.2.cr0..version:2@1.9.6.2.cr0
* src/third_party/android_deps/libs/net_ltgt_gradle_incap_incap: version:0.2.cr0..version:2@0.2.cr0
* src/third_party/android_deps/libs/net_sf_kxml_kxml2: version:2.3.0.cr0..version:2@2.3.0.cr0
* src/third_party/android_deps/libs/org_apache_ant_ant: version:1.8.0.cr0..version:2@1.8.0.cr0
* src/third_party/android_deps/libs/org_apache_ant_ant_launcher: version:1.8.0.cr0..version:2@1.8.0.cr0
* src/third_party/android_deps/libs/org_apache_maven_maven_ant_tasks: version:2.1.3.cr0..version:2@2.1.3.cr0
* src/third_party/android_deps/libs/org_apache_maven_maven_artifact: version:2.2.1.cr0..version:2@2.2.1.cr0
* src/third_party/android_deps/libs/org_apache_maven_maven_artifact_manager: version:2.2.1.cr0..version:2@2.2.1.cr0
* src/third_party/android_deps/libs/org_apache_maven_maven_error_diagnostics: version:2.2.1.cr0..version:2@2.2.1.cr0
* src/third_party/android_deps/libs/org_apache_maven_maven_model: version:2.2.1.cr0..version:2@2.2.1.cr0
* src/third_party/android_deps/libs/org_apache_maven_maven_plugin_registry: version:2.2.1.cr0..version:2@2.2.1.cr0
* src/third_party/android_deps/libs/org_apache_maven_maven_profile: version:2.2.1.cr0..version:2@2.2.1.cr0
* src/third_party/android_deps/libs/org_apache_maven_maven_project: version:2.2.1.cr0..version:2@2.2.1.cr0
* src/third_party/android_deps/libs/org_apache_maven_maven_repository_metadata: version:2.2.1.cr0..version:2@2.2.1.cr0
* src/third_party/android_deps/libs/org_apache_maven_maven_settings: version:2.2.1.cr0..version:2@2.2.1.cr0
* src/third_party/android_deps/libs/org_apache_maven_wagon_wagon_file: version:1.0-beta-6.cr0..version:2@1.0-beta-6.cr0
* src/third_party/android_deps/libs/org_apache_maven_wagon_wagon_http_lightweight: version:1.0-beta-6.cr0..version:2@1.0-beta-6.cr0
* src/third_party/android_deps/libs/org_apache_maven_wagon_wagon_http_shared: version:1.0-beta-6.cr0..version:2@1.0-beta-6.cr0
* src/third_party/android_deps/libs/org_apache_maven_wagon_wagon_provider_api: version:1.0-beta-6.cr0..version:2@1.0-beta-6.cr0
* src/third_party/android_deps/libs/org_ccil_cowan_tagsoup_tagsoup: version:1.2.1.cr0..version:2@1.2.1.cr0
* src/third_party/android_deps/libs/org_checkerframework_checker_compat_qual: version:2.5.5.cr0..version:2@2.5.5.cr0
* src/third_party/android_deps/libs/org_checkerframework_checker_qual: version:3.5.0.cr0..version:2@3.5.0.cr0
* src/third_party/android_deps/libs/org_checkerframework_dataflow_shaded: version:3.1.2.cr0..version:2@3.1.2.cr0
* src/third_party/android_deps/libs/org_codehaus_mojo_animal_sniffer_annotations: version:1.17.cr0..version:2@1.17.cr0
* src/third_party/android_deps/libs/org_codehaus_plexus_plexus_container_default: version:1.0-alpha-9-stable-1.cr0..version:2@1.0-alpha-9-stable-1.cr0
* src/third_party/android_deps/libs/org_codehaus_plexus_plexus_interpolation: version:1.11.cr0..version:2@1.11.cr0
* src/third_party/android_deps/libs/org_codehaus_plexus_plexus_utils: version:1.5.15.cr0..version:2@1.5.15.cr0
* src/third_party/android_deps/libs/org_jetbrains_annotations: version:13.0.cr0..version:2@13.0.cr0
* src/third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_stdlib: version:1.3.72.cr0..version:2@1.4.30.cr0
* src/third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_stdlib_common: version:1.3.72.cr0..version:2@1.4.30.cr0
* src/third_party/android_deps/libs/org_jetbrains_kotlinx_kotlinx_metadata_jvm: version:0.1.0.cr0..version:2@0.1.0.cr0
* src/third_party/android_deps/libs/org_ow2_asm_asm: version:7.0.cr0..version:2@7.0.cr0
* src/third_party/android_deps/libs/org_ow2_asm_asm_analysis: version:7.0.cr0..version:2@7.0.cr0
* src/third_party/android_deps/libs/org_ow2_asm_asm_commons: version:7.0.cr0..version:2@7.0.cr0
* src/third_party/android_deps/libs/org_ow2_asm_asm_tree: version:7.0.cr0..version:2@7.0.cr0
* src/third_party/android_deps/libs/org_ow2_asm_asm_util: version:7.0.cr0..version:2@7.0.cr0
* src/third_party/android_deps/libs/org_pcollections_pcollections: version:2.1.2.cr0..version:2@2.1.2.cr0
* src/third_party/android_deps/libs/org_robolectric_annotations: version:4.3.1.cr0..version:2@4.3.1.cr0
* src/third_party/android_deps/libs/org_robolectric_junit: version:4.3.1.cr0..version:2@4.3.1.cr0
* src/third_party/android_deps/libs/org_robolectric_pluginapi: version:4.3.1.cr0..version:2@4.3.1.cr0
* src/third_party/android_deps/libs/org_robolectric_plugins_maven_dependency_resolver: version:4.3.1.cr0..version:2@4.3.1.cr0
* src/third_party/android_deps/libs/org_robolectric_resources: version:4.3.1.cr0..version:2@4.3.1.cr0
* src/third_party/android_deps/libs/org_robolectric_robolectric: version:4.3.1.cr0..version:2@4.3.1.cr0
* src/third_party/android_deps/libs/org_robolectric_sandbox: version:4.3.1.cr0..version:2@4.3.1.cr0
* src/third_party/android_deps/libs/org_robolectric_shadowapi: version:4.3.1.cr0..version:2@4.3.1.cr0
* src/third_party/android_deps/libs/org_robolectric_shadows_framework: version:4.3.1.cr0..version:2@4.3.1.cr0
* src/third_party/android_deps/libs/org_robolectric_shadows_playservices: version:4.3.1.cr0..version:2@4.3.1.cr0
* src/third_party/android_deps/libs/org_robolectric_utils: version:4.3.1.cr0..version:2@4.3.1.cr0
* src/third_party/android_deps/libs/org_robolectric_utils_reflector: version:4.3.1.cr0..version:2@4.3.1.cr0
* src/third_party/android_deps/libs/org_threeten_threeten_extra: version:1.5.0.cr0..version:2@1.5.0.cr0
* src/third_party/androidx: v-p1zbJ800vLETiv98_a04Og1z_1IR6Cph3aB-RvpO0C..elLOzilYbu3vB2mpMZzZsC0i9QukqoU9miZ_PUmpeE8C
* src/third_party/breakpad/breakpad: dff7d5afd5..3bea2815bfhttps://chromium.googlesource.com/catapult.git/+log/36e45025a8..ab687ea7be
* src/third_party/depot_tools: e0de6a88e5..057831ef1f104674b531..4fb42ae52ee9c50fa77d..b9b74f9f781a8ecf1813..965f8ecbfdd879aac971..81d656878ehttps://aomedia.googlesource.com/aom.git/+log/79b7757996..6c93db7ff6
* src/third_party/libyuv: a8c181050c..64994843e6https://chromium.googlesource.com/linux-syscall-support.git/+log/29f7c7e018..92a65a8f5d
* src/third_party/perfetto: acb2e677b4..9511660f9379f0178cd3..70d42ae95aadd6c82864..78b6ac0da434f3c82122..2dffe0671134f3c82122..2dffe06711TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I3b3a469e48383e250adaf46b186d5cad038957a6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215021
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33696}
2021-04-12 18:25:58 +00:00
5051693ada
[Battery]: TaskQueuePacedSender not started by default.
...
Following up on https://webrtc-review.googlesource.com/c/src/+/213000
This CL prevents scheduling work before TaskQueuePacedSender::EnsureStarted(),
making it necessary to function.
Bug: chromium:1152887
Change-Id: I848c9e6d6057a404626ad693b1f4dc7fba797a9c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214320
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
Cr-Commit-Position: refs/heads/master@{#33695}
2021-04-12 15:36:46 +00:00
9ff75a6206
Add addr in error msg if stun sock sent with error
...
Before:
```
(stun_port.cc:596): sendto : [0x00000041] No route to host
```
After:
```
(stun_port.cc:598): UDP send of 20 bytes to host stun1.l.google.com:19302 (74.125.200.127:19302) failed with error 65 : [0x00000041] No route to host
```
Bug: None
Change-Id: Ibcd487e97b37677225814562df30af66f655cddb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215000
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com >
Cr-Commit-Position: refs/heads/master@{#33694}
2021-04-12 15:12:39 +00:00
3928e8fdb1
dcsctp: Disable packet fuzzers
...
This causes build failures in the Chromium fuzzers, so let's disable it
for now.
Bug: none
Change-Id: I0a076c0cd5cfb7d62383d733f3934f8b58f8ad34
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215040
Reviewed-by: Evan Shrubsole <eshr@google.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33693}
2021-04-12 14:49:09 +00:00
0aa1a19be0
Add module overview of ICE
...
Bug: webrtc:12550
Change-Id: I9e14c916d978db092406a248d7895b3c22c82cbc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214982
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33692}
2021-04-12 14:03:57 +00:00
9de39f6c45
Add titovartem@webrtc.org as owner for /g3doc
...
Bug: None
Change-Id: If19617f857b5d6c7b5b69fdcbed5b7a9e2e65a42
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215001
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33691}
2021-04-12 13:40:47 +00:00
4af6f2b337
Move threading documentation for API into g3doc structure
...
Bug: webrtc:12674
Change-Id: I49bb46b4e505f89ce8d56c469a8995779edf1f28
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214969
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33690}
2021-04-12 13:38:49 +00:00
a3575cb848
Remove tautological 'unsigned expr < 0' comparisons
...
This is the result of compiling Chromium with
Wtautological-unsigned-zero-compare. For more details, see:
https://chromium-review.googlesource.com/c/chromium/src/+/2802412
Change-Id: I05cec6ae5738036a56beadeaa1dde5189edf0137
Bug: chromium:1195670
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213783
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Stefan Holmer <stefan@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33689}
2021-04-12 11:40:14 +00:00
22379fc8dc
sctp: Rename SctpTransport to UsrSctpTransport
...
The rename ensures we don't confuse this implementation with
the new one based on the new dcSCTP library.
Bug: webrtc:12614
No-Presubmit: True
Change-Id: Ida08659bbea9c98aba8247d4368799ff7dd18729
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214482
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33688}
2021-04-12 10:40:34 +00:00
606bd6d163
dcsctp: Use correct field width for PPID
...
When migrating to use StrongAlias types, the PPID was incorrectly
modeled as an uint16_t instead of a uint32_t, as it was prior to using
StrongAlias. Most likely a copy-paste error from StreamID.
As the Data Channel PPIDs are in the range of 51-57, it was never caught
in tests.
Bug: webrtc:12614
Change-Id: I2b61ef7935df1222068e7f4e70fc2aaa532dcf7b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214960
Reviewed-by: Tommi <tommi@webrtc.org >
Reviewed-by: Florent Castelli <orphis@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33687}
2021-04-12 09:28:48 +00:00
9d60936048
dcsctp: Fix relative dependency paths in timer/
...
Bug: webrtc:12614
Change-Id: I50cd2e5beae516e4a1ba47626d835eb9c80dffcb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214965
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33686}
2021-04-12 08:25:49 +00:00
100321969c
srtp: compare key length to srtp policy key length
...
simplifying the code and comparing against the value libsrtp expects
and increase verbosity of error logging related to key length mismatches.
BUG=None
Change-Id: Icc0d0121d2983e23c95b0f972a5f6cac1d158fd7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213146
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/master@{#33685}
2021-04-12 07:57:03 +00:00
5691053612
IceStatesReachCompletionWithRemoteHostname: disable on Linux.
...
This test flakes due to the expectation at
http://shortn/_XxN4cgzMLD .
Bug: webrtc:12590
Change-Id: Id75ecd4f12cd6f9af86aeb2213fd3cb39aecb6d5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214920
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Markus Handell <handellm@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33684}
2021-04-12 07:42:03 +00:00
9071957da3
Remove unused members in tests.
...
VideoStreamEncoderTest: Remove unneeded set_timestamp_rtp in CreateFrame methods (the timestamp is set based on ntp_time_ms in VideoStreamEncoder::OnFrame).
Bug: none
Change-Id: I6b5531a9ac21cde5dac54df6de9b9d43261e90c6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214488
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33683}
2021-04-12 07:21:03 +00:00
55de2926a8
Use relative paths for //net/dcsctp/public:socket.
...
Quick fix for Chromium fuzzer builds, for example
https://ci.chromium.org/ui/p/chromium/builders/try/win-libfuzzer-asan-rel/b8850210174432806976/overview .
Bug: None
Change-Id: Id43269f58ccc976a694fbf1cef2721f654f95e62
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214962
Reviewed-by: Victor Boivie <boivie@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33682}
2021-04-12 07:14:33 +00:00
1cdeb0a56e
addIceCandidate with callback into Android's SDK.
...
Bug: webrtc:12609
Change-Id: I059a246f5ade201b6a8decac264a8dd79fef3f9a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212740
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Xavier Lepaul <xalep@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33681}
2021-04-12 07:04:54 +00:00
f075917cb0
Ensure TaskQueuePacedSender dont depend on PacketRouter
...
TaskQueuePacedSender only needs PacingController::PacketSender
Bug: None
Change-Id: I5f9aaa51f48efc099caaef474f14fd37334a52d3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214781
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33680}
2021-04-12 06:13:13 +00:00
1c73e03a37
Update WebRTC code version (2021-04-12T04:03:54).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I67bb37a2c39b1b92edb2afb10c14937482ff16f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214948
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33679}
2021-04-12 05:36:03 +00:00
cb70aa7e05
dcsctp: Add Reassembly Queue
...
The Reassembly Queue receives fragmented messages (DATA or I-DATA
chunks) and - with help of stream reassemblers - will reassemble these
fragments into messages, which will be delivered to the client.
It also handle partial reliability (FORWARD-TSN) and stream resetting.
To avoid a DoS attack vector, where a sender can send fragments in a way
that the reassembly queue will never succeed to reassemble a message and
use all available memory, the ReassemblyQueue has a maximum size.
Bug: webrtc:12614
Change-Id: Ibb084fecd240d4c414e096579244f8f5ee46914e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214043
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33678}
2021-04-11 19:59:49 +00:00
8a13d2ca9f
dcsctp: Add Traditional Reassembly Streams
...
This class handles the assembly of fragmented received messages (as DATA
chunks) and manage per-stream queues. This class only handles
non-interleaved messages as described in RFC4960, and is not used when
message interleaving is enabled on the association, as described in
RFC8260.
This is also only part of the reassembly - a follow-up change will add
the ReassemblyQueue that handle the other part as well. And an even
further follow-up change will add a "interleaved reassembly stream".
Bug: webrtc:12614
Change-Id: Iaf339fa215a2b14926f5cb74f15528392e273f99
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214042
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33677}
2021-04-11 19:20:58 +00:00
b2d539be6b
dcsctp: Add Data Tracker
...
The Data Tracker's purpose is to keep track of all received DATA chunks
and to ACK/NACK that data, by generating SACK chunks reflecting its view
of what has been received and what has been lost.
It also contains logic for _when_ to send the SACKs, as that's different
depending on e.g. packet loss. Generally, SACKs are sent every second
packet on a connection with no packet loss, and can also be sent on a
delayed timer.
In case partial reliability is used, and the transmitter has decided
that some data shouldn't be retransmitted, it will send a FORWARD-TSN
chunk, which this class also handles, by "forgetting" about those
chunks.
Bug: webrtc:12614
Change-Id: Ifafb0c211f6a47872e81830165ab5fc43ee7f366
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213664
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33676}
2021-04-11 18:37:50 +00:00
50fc1dfbcc
dcsctp: Add SCTP packet corpus
...
Each file is a SCTP packet (without any additional headers), all
extracted from a few Wireshark dumps that have been manually recorded.
Bug: webrtc:12614
Change-Id: I64bef0c563f1d83ae22735d702c8abafec6429b9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214701
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33675}
2021-04-11 18:25:08 +00:00
a4da76a880
Update WebRTC code version (2021-04-10T04:03:36).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I5beefb1c12913cf8c96b1a6db8e1dd9ad0767909
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214808
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33674}
2021-04-10 05:32:08 +00:00
061d89877a
Update WgcScreenSource* to use device indices instead of HMONITORs.
...
To maintain interoperability between different capturer implementations
this change updates WgcScreenSourceEnumerator to return a list of
device indices instead of a list of HMONITORs, and WgcScreenSource to
accept a device index as the input SourceId. WGC still requires an
HMONITOR to create the capture item, so this change also adds a utility
function GetHmonitorFromDeviceIndex to convert them, as well as new
tests to cover these changes.
Bug: webrtc:12663
Change-Id: Ic29faa0f023ebc26b4276cf29ef3d15d976e8615
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214600
Commit-Queue: Austin Orion <auorion@microsoft.com >
Reviewed-by: Jamie Walch <jamiewalch@chromium.org >
Cr-Commit-Position: refs/heads/master@{#33673}
2021-04-09 22:31:28 +00:00
f2f9bb66ca
Fixing a buffer copy issue in DesktopFrame
...
This CL fixes a buffer copying issue introduced in this CL:
https://webrtc-review.googlesource.com/c/src/+/196485
In the BasicDesktopFrame::CopyOf function, the src and dst params
were swapped. For me this manifested as a missing cursor when using
Chrome Remote Desktop. I don't know of any other bugs this caused
but I have to assume it affects all callers of the function given
that the copy will never occur.
Bug: chromium:1197210
Change-Id: I076bffbad1d658b1c6f4b0dffea17d339c867bef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214840
Commit-Queue: Joe Downing <joedow@google.com >
Commit-Queue: Jamie Walch <jamiewalch@chromium.org >
Reviewed-by: Jamie Walch <jamiewalch@chromium.org >
Cr-Commit-Position: refs/heads/master@{#33672}
2021-04-09 20:48:32 +00:00
fc5d2762f5
Fix dropped frames not counted issue
...
There's been reports of dropped frames that are not counted and
correctly reported by getStats().
If a HW decoder is used and the system is provoked by stressing
the system, I've been able to reproduce this problem. It turns out
that we've missed frames that are dropped because there is no
callback to the Decoded() function.
This CL restructures the code so that dropped frames are counted
even in cases where there's no corresponding callback for some frames.
Bug: webrtc:11229
Change-Id: I0216edba3733399c188649908d459ee86a9093d0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214783
Commit-Queue: Johannes Kron <kron@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33671}
2021-04-09 14:47:52 +00:00
9410217413
dcsctp: Add SCTP packet fuzzer
...
This fuzzer explores the SCTP parsing, as well as the individual
chunks, as a successfully parsed packet will have its chunks iterated
over and formatted using ToString.
Bug: webrtc:12614
Change-Id: I88f703c5f79e4775a069b1d5439d413870f6a629
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214490
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33670}
2021-04-09 12:23:42 +00:00
3c31ee0793
Reduce logging for PC supported codecs in PC level tests
...
Bug: None
Change-Id: I78db2d129c277c11375d8903d3127944ff832fec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214760
Commit-Queue: Tommi <tommi@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33669}
2021-04-09 11:26:22 +00:00
64099bcbe7
Add locking to UniqueRandomIdGenerator.
...
The SdpOfferAnswerHandler::ssrc_generator_ variable is used from
multiple threads.
Adding thread checks + tests for UniqueNumberGenerator along the way.
Bug: webrtc:12666
Change-Id: Id2973362a27fc1d2c7db60de2ea447d84d18ae3e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214702
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33668}
2021-04-09 10:04:25 +00:00
5f4ac67c7b
dcsctp: Add Data Generator
...
The Data Generator is a testonly library for generating
Data with correct sequence numbers.
Bug: webrtc:12614
Change-Id: Ifc04dfd14d858d905312ffed13e8905c23d59923
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214041
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33667}
2021-04-09 09:53:34 +00:00
6fa0cfa4dd
dcsctp: Add Timer and TimerManager
...
Timer is a high-level timer (in contrast to the low-level `Timeout`
class). Timers are started and can be stopped or restarted. When a timer
expires, the provided callback will be triggered.
Timers can be configured to do e.g. exponential backoff when they expire
and how many times they should be automatically restarted.
Bug: webrtc:12614
Change-Id: Id5eddd58dd0af62184b10dd1f98e3e886e3f1d50
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/213350
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33666}
2021-04-09 07:48:50 +00:00
10aaa3f1e7
dcsctp: Fixed parameter name typo
...
Late review comments from
https://webrtc-review.googlesource.com/c/src/+/213180
Bug: webrtc:12614
Change-Id: I61471902b50c6a08092a1fa9d3a03202c95177d0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214486
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33665}
2021-04-09 07:39:50 +00:00
5c5e8011e7
Update WebRTC code version (2021-04-09T04:04:26).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I565a624b8ae27f49774f2e1cd8ba86826a67bffb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214660
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33664}
2021-04-09 05:30:50 +00:00
6b0f19f9ef
sctp: Move SctpTransportFactory to a separate file
...
Bug: webrtc:12614
Change-Id: Ifc0e96ed3262e6ca057cd73d736a7ac081493f53
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214481
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33663}
2021-04-08 20:49:44 +00:00
588f9b3705
VideoReceiveStream2: AV1 encoded sink support.
...
This change adds support for emitting encoded frames
for recording when the decoder can't easily read out
encoded width and height as is the case for AV1 streams,
in which case the information is buried in OBUs. Downstream
project relies on resolution information being present for key
frames. With the change, VideoReceiveStream2 infers the
resolution from decoded frames, and supplies it in the
RecordableEncodedFrames.
Bug: chromium:1191972
Change-Id: I07beda6526206c80a732976e8e19d3581489b8fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214126
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Markus Handell <handellm@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33662}
2021-04-08 20:07:22 +00:00
edc946ea81
Move RTC_ENABLE_WIN_WGC define to the top level BUILD.gn
...
It was recommened to me to move this define to the top level BUILD.gn
file to avoid potential issues with the define not being available
where we need it.
Bug: webrtc:9273
Change-Id: Id0e939a51d1e381f684a3ae970569a255f52a5bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214101
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Austin Orion <auorion@microsoft.com >
Cr-Commit-Position: refs/heads/master@{#33661}
2021-04-08 16:31:49 +00:00
67b1fa2bd7
Update DCHECKs in RTCStatsCollector.
...
Change: RTC_DCHECK(foo->IsCurrent()
To: RTC_DCHECK_RUN_ON(foo)
Bug: none
Change-Id: I9ac5d7b7181c8a58b17ce6d2c128d3d52a6c6d25
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214300
Commit-Queue: Tommi <tommi@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33660}
2021-04-08 15:55:36 +00:00
58fa1bac03
dcsctp: Enforce variable length TLV minimum length
...
The length field was validated to not be too big, or to have too much
padding, but it could be smaller than the fixed size of the chunk, which
isn't correct. Now it's enforced to be at minimum the size of the fixed
size header.
Bug: webrtc:12614
Change-Id: I57089a5ba2854eeb63ab3b4e28cf5878087d06e8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214484
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33659}
2021-04-08 15:33:16 +00:00
ca7412d937
dcsctp: Avoid infinite loops on zero-length chunks
...
Every chunk should be at least 4 bytes to be valid - that's the size of
the chunk header. If the embedded length was zero (0), iterating over
the chunks would never complete. Fixed now.
Bug: webrtc:12614
Change-Id: I1cbd070ad34a51584f6b09c5364c3db1b2bcdc2e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214483
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Victor Boivie <boivie@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33658}
2021-04-08 15:15:16 +00:00
