a961761c87
Roll chromium_revision e5a3e5dfd7..62bf27aca5 (749695:749837)
...
Change log: e5a3e5dfd7..62bf27aca5e5a3e5dfd7..62bf27aca5f06db6034d..d8e56f5f8292f2cec906..a42d61c299af4d83d3a9..cd5ba3420e11c6b48fad..c09e22fba2996d591645..460b204134https://chromium.googlesource.com/catapult.git/+log/786ed18d9d..1046637743
* src/third_party/depot_tools: 1ee78cdaac..3c11794956f37ede0804..d3b1e99c56e5a3e5dfd7..62bf27aca5TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ic6aa8e653b326138b29d079bc8b3f14775d09688
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170381
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30782}
2020-03-12 20:39:08 +00:00
de86381161
Leverage dispatch_queue_create_with_target when possible.
...
Replacing dispatch_queue_create followed by
dispatch_set_target_queue with dispatch_queue_create_with_target
is claimed to be source of GCD performance improvement:
https://developer.apple.com/videos/play/wwdc2017/706/
Video since 40 min. Slides since 199.
Bug: webrtc:9055
Change-Id: I0136f7faaef0951a7ad243bc8772f3ee952d5470
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168491
Reviewed-by: Tommi <tommi@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com >
Cr-Commit-Position: refs/heads/master@{#30781}
2020-03-12 20:33:48 +00:00
e6cedbbff6
Ensures that all simulated TCP packets are at least 4 bytes.
...
Bug: webrtc:10839
Change-Id: I4f2f5cf75b9fbcedb39e3fa05d11c68a7de6f5b1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170051
Reviewed-by: Ali Tofigh <alito@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30780}
2020-03-12 17:42:13 +00:00
d35a686517
Reland "Fix for out-of-bounds write in square test frame generator."
...
This is a reland of 30026214b13535a9fe1c47f1463378fbf976c643
Original change's description:
> Fix for out-of-bounds write in square test frame generator.
>
> The length is set on construction and includes an assumption on the
> image resolution, if the resolution changes, a square might be larger
> than what fits into the buffer, causing an out of bounds write. This
> CL fixes this simply by restricting the size of the square.
>
> Bug: webrtc:11415
> Change-Id: Iee14a1971997b4ae2fddef0a7af7c76a2509e879
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170042
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Reviewed-by: Ali Tofigh <alito@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30732}
Bug: webrtc:11415
Change-Id: I0dc584858208f478434ebc6f9e31634595c4e5ad
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170116
Reviewed-by: Ali Tofigh <alito@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30779}
2020-03-12 17:09:22 +00:00
a4304ac5a8
Roll chromium_revision 97afa2b0cb..e5a3e5dfd7 (749589:749695)
...
Change log: 97afa2b0cb..e5a3e5dfd797afa2b0cb..e5a3e5dfd7e5ee983503..f06db6034d0bcd34f295..92f2cec906ce0ef13226..af4d83d3a93cbe9ba792..996d591645cf4d8e20da..f37ede080497afa2b0cb..e5a3e5dfd7TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I4dca87f66ef62cd09379f7f0d707c22dcb426659
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170309
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30778}
2020-03-12 16:42:43 +00:00
b8996ddac0
Revert "Temporary debug logging for SingleProcessEncodedImageDataInjector"
...
This reverts commit 4f3c4fcb1f26606af9e7ce0420d1fa8fbc95d82f.
Reason for revert: bug is fixed, so temporary logging can be removed.
Original change's description:
> Temporary debug logging for SingleProcessEncodedImageDataInjector
>
> Bug: None
> Change-Id: Idb482c002ed41b9ad750109fd3497425003be11b
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169448
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Artem Titov <titovartem@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30649}
TBR=mbonadei@webrtc.org ,titovartem@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: None
Change-Id: I8f9587b4963bd089b3f870b43bd7a8b7e6a75b38
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170342
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30777}
2020-03-12 14:31:43 +00:00
0c96449305
Clamp stable target bitrate to min/max allocated bitrate.
...
Currently, the stable target can grow to 2x the max allocated bitrate.
Bug: None
Change-Id: I71657cb49ebebd429aae0bcd2e2978938252115c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170222
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30776}
2020-03-12 13:51:10 +00:00
d82a02c837
ACM: Corrected temporary buffer size
...
This CL corrects the temporary buffers size in the
pre-processing of the capture audio before encoding.
As part of this it removes the ACM-specific hardcoding
of the size and instead ensures that the size of the
temporary buffer matches that of the AudioFrame.
Bug: webrtc:11242
Change-Id: I56dd6cadfd4e140e8e159966c33d1027383ea9fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170340
Commit-Queue: Per Åhgren <peah@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30775}
2020-03-12 12:23:20 +00:00
c71be24c82
Roll chromium_revision 96fc083e52..97afa2b0cb (749472:749589)
...
Change log: 96fc083e52..97afa2b0cb96fc083e52..97afa2b0cb8a766f0bc8..0bcd34f2953d67d1cdd9..ce0ef132262b6b18bf3b..3cbe9ba7924c7c4b4bc6..1ee78cdaac2a2c374463..cf4d8e20da96fc083e52..97afa2b0cbTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I22a34cae82812023e2598020f363de187cb44efb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170306
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30774}
2020-03-12 10:52:07 +00:00
bd74d5ca6b
Pass callbacks for RtcpReceiver at construction
...
Bug: webrtc:10680
Change-Id: Ic242008e63a5a86ac30ab5f4041a30dbdb7fc72b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170236
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30773}
2020-03-12 10:26:17 +00:00
b8e69efcee
Write protos as binary.
...
We need to write protos as "wb" and not "w", otherwise we get CRLF
on Windows which corrupts the proto.
Bug: chromium:1029452
Change-Id: Iabf841405134d7bc2523ac48219ca7cb9d8214c1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170320
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30772}
2020-03-12 09:43:57 +00:00
f092e4d0ff
Reland "Whitespace change to kick bots."
...
This is a reland of c782263e5f19f7c30d0b2120a8ec2383111ac1c6
Original change's description:
> Whitespace change to kick bots.
>
> TBR: phoglund@webrtc.org
> Bug: None
> No-Try: True
> No-Tree-Checks: true
> Change-Id: I7c39b96c59ab074809137b10e31d722a1c43d098
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170106
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30736}
TBR=phoglund@webrtc.org
No-Try: True
Bug: None
Change-Id: I2ac364a90a295d33ec377d8ba9d21ce3d293c1a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170321
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30771}
2020-03-12 08:03:55 +00:00
2896bf697b
Add ios_use_goma_rbe=true to iOS bots.
...
Bug: webrtc:11401
Change-Id: Ieec115c38b300936ddf9be99a4c6c9ee1708c37f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170227
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30770}
2020-03-12 07:06:51 +00:00
484bb8a03b
Roll chromium_revision 3bc28c823c..96fc083e52 (749350:749472)
...
Change log: 3bc28c823c..96fc083e523bc28c823c..96fc083e52097bc4098e..e5ee983503339716a5f0..8a766f0bc8fb85a1e63a..3d67d1cdd9524f3fe2f4..11c6b48fad3055d05fd8..2b6b18bf3bhttps://chromium.googlesource.com/catapult.git/+log/7004f998c7..786ed18d9d
* src/third_party/depot_tools: 53effe844c..4c7c4b4bc6bda209202b..2a2c3744633bc28c823c..96fc083e52TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I383a1bf4876d174dd10706f22d1807902c373c26
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170302
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30769}
2020-03-12 03:11:50 +00:00
a7dad03fb1
Roll chromium_revision da6a45d3d1..3bc28c823c (749241:749350)
...
Change log: da6a45d3d1..3bc28c823cda6a45d3d1..3bc28c823c802ab61871..097bc4098e455b1d9ff3..339716a5f08487262865..fb85a1e63ab8d4bc4dea..524f3fe2f414cc07ffe1..3055d05fd896c9784d1a..53effe844c545152f302..d2350e16453f5d4a663b..bda209202bda6a45d3d1..3bc28c823cTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I6c3c417387a8318fe045a82581348d00db7ffcf6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170300
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30768}
2020-03-11 22:43:49 +00:00
d8d15937da
Roll chromium_revision 03913e7d28..da6a45d3d1 (749124:749241)
...
Change log: 03913e7d28..da6a45d3d103913e7d28..da6a45d3d1e8a1fa2191..802ab618716a6f591676..455b1d9ff3beeea9a64a..8487262865d634140838..b8d4bc4dea472228bf0f..14cc07ffe1https://chromium.googlesource.com/catapult.git/+log/e4aabc8bab..7004f998c7
* src/tools: dba78d3638..3f5d4a663b03913e7d28..da6a45d3d1TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ifd7282f5f66133e7af2d8520c84723ed78b9c75e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170262
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30767}
2020-03-11 18:39:16 +00:00
6c08e4b57d
Remove deprecated RtpVideoStreamReceiver constructor.
...
The dependencies have been updated to use the new constructor.
Bug: webrtc:11380
Change-Id: I1ded1816b94fd069d729df50ff83842eca054acc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170223
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30766}
2020-03-11 17:38:34 +00:00
443f26695f
Cleanup RtcpReceiver tests
...
update MOCK_METHODs to use new syntax recommended in go/totw/164
Replace fixture with struct of mocks.
Use main method under test (IncomingPacket) directly rather than through fixture helpers
minor cleanup of the RtcReceiver itself:
make IncomingPacket function more friendly to containers,
mark class as final to verify ability to inherit from it is not used and
thus destructor doesn't need to be virtual.
Bug: None
Change-Id: I346e7dc513b1fbe663ebe5858dec7df0520416a7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170226
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Markus Handell <handellm@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30765}
2020-03-11 15:15:14 +00:00
3bc8123247
Scale unacked_data consistently in RobustThroughputEstimator
...
Bug: webrtc:10274
Change-Id: I4bb460ec13a17080a50750e59f87d7e972f9947b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170232
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30764}
2020-03-11 15:02:44 +00:00
75d91faecc
Revert "Reland "Whitespace change to kick bots.""
...
This reverts commit f11a0287d6217c629fb381dba6f668db9f560efd.
Reason for revert: Trigger bots.
Original change's description:
> Reland "Whitespace change to kick bots."
>
> This reverts commit 984dc32776be391084183e075ec7932cec89d491.
>
> Reason for revert: Trigger all the bots.
>
> Original change's description:
> > Revert "Whitespace change to kick bots."
> >
> > This reverts commit c782263e5f19f7c30d0b2120a8ec2383111ac1c6.
> >
> >
> > Original change's description:
> > > Whitespace change to kick bots.
> > >
> > > TBR: phoglund@webrtc.org
> > > Bug: None
> > > No-Try: True
> > > No-Tree-Checks: true
> > > Change-Id: I7c39b96c59ab074809137b10e31d722a1c43d098
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170106
> > > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#30736}
> >
> > TBR=phoglund@webrtc.org ,mbonadei@webrtc.org
> >
> > Change-Id: I265e1ae044c0f44561f8910291bdabf9cc22c936
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: None
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170221
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30750}
>
> TBR=phoglund@webrtc.org ,mbonadei@webrtc.org
>
> Change-Id: Iff32bb0ced35906f6a70e414bb72f3dc49f53abb
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: None
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170233
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30762}
TBR=phoglund@webrtc.org ,mbonadei@webrtc.org
Change-Id: I4ad5c84b876249f9160d6cf2d3cacd4cf83b73b4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170234
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30763}
2020-03-11 14:48:46 +00:00
f11a0287d6
Reland "Whitespace change to kick bots."
...
This reverts commit 984dc32776be391084183e075ec7932cec89d491.
Reason for revert: Trigger all the bots.
Original change's description:
> Revert "Whitespace change to kick bots."
>
> This reverts commit c782263e5f19f7c30d0b2120a8ec2383111ac1c6.
>
>
> Original change's description:
> > Whitespace change to kick bots.
> >
> > TBR: phoglund@webrtc.org
> > Bug: None
> > No-Try: True
> > No-Tree-Checks: true
> > Change-Id: I7c39b96c59ab074809137b10e31d722a1c43d098
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170106
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30736}
>
> TBR=phoglund@webrtc.org ,mbonadei@webrtc.org
>
> Change-Id: I265e1ae044c0f44561f8910291bdabf9cc22c936
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: None
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170221
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30750}
TBR=phoglund@webrtc.org ,mbonadei@webrtc.org
Change-Id: Iff32bb0ced35906f6a70e414bb72f3dc49f53abb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170233
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30762}
2020-03-11 14:34:16 +00:00
8f47b27268
Partial revert: "Hand protos directly to histograms and fix summary."
...
This partially reverts commit 7427fc6560b0cdf67912863162c72cfde2ed0cd6.
Turns out proto importing is broken on the catapult side. A fix is
coming. Until then I'll have to use the old JSON way.
Bug: chromium:1029452
Change-Id: Ib5c43d721fe6c4e2639a0d518f4fa69b42b6c388
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170230
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30761}
2020-03-11 13:56:14 +00:00
6817394eac
Fix: don't use recovered packets in UlpFEC recovery
...
Bug: b/141915452
Change-Id: I75324651694e5c3233bc3627269289d3f0a91514
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170225
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30760}
2020-03-11 12:49:11 +00:00
4d3f93f348
Roll chromium_revision 9a91e04496..03913e7d28 (749020:749124)
...
Change log: 9a91e04496..03913e7d289a91e04496..03913e7d28ec6c1e4d1e..e8a1fa21913e210049d3..6a6f5916762cd0224458..beeea9a64acc303f1d06..d634140838db27bf8879..472228bf0fhttps://chromium.googlesource.com/catapult.git/+log/8bf3aecd33..e4aabc8bab
* src/third_party/depot_tools: 552ddbf3bf..96c9784d1a4d1e13b3f2..dba78d36389a91e04496..03913e7d28TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ifca8d0c1731af14f72fcf0ff49905e05734bb5fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170242
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30759}
2020-03-11 12:41:51 +00:00
e618cc9c1e
Add jitterBufferTargetDelay as RTCNonStandardStatsMember to new GetStats API
...
Bug: webrtc:11381
Change-Id: I7df3450e50da49d178e1e3a5d9f4970672d91aac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169120
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30758}
2020-03-11 12:08:32 +00:00
c46385c346
Add Av1 Decoder wrapper behind a build flag
...
Bug: webrtc:11404
Change-Id: I090ffd173d667e8845de1b986af462516b7c76e6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169452
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Michael Horowitz <mhoro@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30757}
2020-03-11 11:20:56 +00:00
45c104b4fd
RtpTransceiver: add kStopped enumeration value.
...
This change introduces a new kStopped enumeration value to
RtpTransceiverDirection, preparing for later CLs which
implement RTP header extension control,
https://chromestatus.com/feature/5680189201711104 .
The new enumeration value is unused in the code.
Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/65YdUi02yZk
Bug: chromium:980879
Change-Id: Id8cab9891236884542689fbf1b300e64a2cb636d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170050
Commit-Queue: Markus Handell <handellm@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30756}
2020-03-11 11:19:51 +00:00
78964c1e0a
Transform encoded frames in RtpVideoStreamReceiver.
...
This change is part of the implementation of the Insertable Streams Web
API: https://github.com/alvestrand/webrtc-media-streams/blob/master/explainer.md
Design doc for WebRTC library changes:
http://doc/1eiLkjNUkRy2FssCPLUp6eH08BZuXXoHfbbBP1ZN7EVk
Bug: webrtc:11380
Change-Id: If4ffcfe5761492a2ae5513ec46deb9f837e8aee8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169130
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30755}
2020-03-11 09:46:57 +00:00
62057627ef
[Adaptation] Rename and move resource adaptation module/processor stuff.
...
Rename:
- call/adaptation/resource_adaptation_module_interface.[h/cc] -->
call/adaptation/resource_adaptation_processor_interface.[h/cc]
- call/adaptation/resource_adaptation_processor.[h/cc] -->
call/adaptation/new_resource_adaptation_processor_poc.[h/cc]
Move + Rename:
- video/overuse_frame_detector_resource_adaptation_module.[h/cc] -->
video/adaptation/resource_adaptation_processor.[h/cc]
Move:
- video/encode_usage_resource.[h/cc] --> video/adaptation/...
- video/overuse_frame_detector.[h/cc] --> video/adaptation/...
- video/quality_scaler_resource.[h/cc] --> video/adaptation/...
Unittests are also moved. In order to avoid a circular dependency,
VideoStreamEncoder::kDefaultLastFrameInfo[Width/Height] is moved and
renamed to kDefaultInputPixels[Width/Height] in
video/adaptation/resource_adaptation_processor.[h/cc].
Bug: webrtc:11222
Change-Id: Icf920e8a7362002b1c63c42b2d9e2e63c990b532
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170117
Reviewed-by: Evan Shrubsole <eshr@google.com >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30754}
2020-03-11 09:30:16 +00:00
0759249370
Fix 'all' build on Android platforms.
...
Example of failures when trying to build "all":
https://ci.chromium.org/p/webrtc/builders/try/android_arm64_rel/35549
Bug: webrtc:11411
Change-Id: Idf462c39eb499e5f6f7c971bce78c54d071f9871
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170113
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30753}
2020-03-11 08:29:06 +00:00
c69fd59270
Fix 'all' build on non Android platforms.
...
Example of failures when trying to build "all":
https://ci.chromium.org/p/webrtc/builders/ci/Mac%20Asan/23867
https://ci.chromium.org/p/webrtc/builders/try/linux_tsan2/32911
https://ci.chromium.org/p/webrtc/builders/try/linux_ubsan/32390
All related to missing //third_party/ced code.
Bug: webrtc:11411
Change-Id: Ie3d7e87192edfb48d13ab8b14aba05808411a3ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170112
Reviewed-by: Patrik Höglund <phoglund@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30752}
2020-03-11 08:24:27 +00:00
59f3b71c04
Automate conversion from c++ VideoCodeType to java VideoCodecType
...
Bug: b/148146536
Change-Id: I030c7c6c2a1a9d002bcc60f45c8d6025bd0935b8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/167301
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org >
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30751}
2020-03-11 08:02:36 +00:00
984dc32776
Revert "Whitespace change to kick bots."
...
This reverts commit c782263e5f19f7c30d0b2120a8ec2383111ac1c6.
Original change's description:
> Whitespace change to kick bots.
>
> TBR: phoglund@webrtc.org
> Bug: None
> No-Try: True
> No-Tree-Checks: true
> Change-Id: I7c39b96c59ab074809137b10e31d722a1c43d098
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170106
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30736}
TBR=phoglund@webrtc.org ,mbonadei@webrtc.org
Change-Id: I265e1ae044c0f44561f8910291bdabf9cc22c936
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170221
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30750}
2020-03-11 07:11:10 +00:00
ed678386b4
Roll chromium_revision ad5dd08069..9a91e04496 (748920:749020)
...
Change log: ad5dd08069..9a91e04496ad5dd08069..9a91e044963325855ae5..ec6c1e4d1ecd6c9dda12..3e210049d340b07936fa..2cd0224458aa8f2b07ee..cc303f1d064509cf0c09..db27bf8879https://chromium.googlesource.com/catapult.git/+log/4bdcfb7b6e..8bf3aecd33
* src/third_party/depot_tools: 8aa9d62e8e..552ddbf3bf7befc24683..4d1e13b3f2ad5dd08069..9a91e04496TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I26988d5d4ffcba41fbca9f6a59e36dfaadc0def9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170202
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30749}
2020-03-11 02:37:36 +00:00
6d2dfeb3e6
Add RTC_EXPORT to webrtc::Clock
...
Bug: chromium:1011581
Change-Id: I827ccff6946d3c86af67adcd00b57fad0440489f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170043
Commit-Queue: Johannes Kron <kron@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30748}
2020-03-10 23:00:21 +00:00
f826f4cf57
Roll chromium_revision 4fa1454bcb..ad5dd08069 (748775:748920)
...
Change log: 4fa1454bcb..ad5dd080694fa1454bcb..ad5dd08069455a13248a..3325855ae5a9187877c2..cd6c9dda126c8a9b7959..40b07936fafd69a41d76..aa8f2b07ee98877aae23..4509cf0c09https://chromium.googlesource.com/catapult.git/+log/9e5db26faa..4bdcfb7b6e
* src/third_party/depot_tools: 0c4a3c2503..8aa9d62e8ec0c52ef23c..7befc246834fa1454bcb..ad5dd08069TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I6c04377ae969623df3477021c6ed213537ccd2e9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170200
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30747}
2020-03-10 22:51:41 +00:00
430e4a09e0
Allow to negotiate absolute capture time rtp header extension.
...
Bug: webrtc:10739
Change-Id: I239d67a8c02bcc4175b142174b254e876bdd8d6d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169920
Commit-Queue: Minyue Li <minyue@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30746}
2020-03-10 22:25:15 +00:00
8332950f4a
Roll chromium_revision 29afd4ae2e..4fa1454bcb (748637:748775)
...
Change log: 29afd4ae2e..4fa1454bcb29afd4ae2e..4fa1454bcb941c32bd58..455a13248a5007d4594c..a9187877c2cb01a2be34..6c8a9b7959c3b1c1980b..fd69a41d76c0ce153b13..98877aae23b920323e03..c0c52ef23c29afd4ae2e..4fa1454bcbTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I79570044be4b99ba5c0efd2bd9ddcf3d86ebdbf8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170183
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30745}
2020-03-10 19:06:29 +00:00
dd14a95596
Allow TimestampAligner to translate timestamp without new observation of system clock.
...
Bug: chromium:1054403
Change-Id: I32c622851fc0bed2c47ae142c743399acb91ae84
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169924
Commit-Queue: Minyue Li <minyue@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30744}
2020-03-10 17:22:54 +00:00
1230c8568e
Revert "Fix for out-of-bounds write in square test frame generator."
...
This reverts commit 30026214b13535a9fe1c47f1463378fbf976c643.
Reason for revert: Speculative revert, breaks downstream test.
Original change's description:
> Fix for out-of-bounds write in square test frame generator.
>
> The length is set on construction and includes an assumption on the
> image resolution, if the resolution changes, a square might be larger
> than what fits into the buffer, causing an out of bounds write. This
> CL fixes this simply by restricting the size of the square.
>
> Bug: webrtc:11415
> Change-Id: Iee14a1971997b4ae2fddef0a7af7c76a2509e879
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170042
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Reviewed-by: Ali Tofigh <alito@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30732}
TBR=srte@webrtc.org ,alito@webrtc.org
Change-Id: Ia0056da04a6f6f817ccadfc38aabe0c5f94754cc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11415
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170115
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30743}
2020-03-10 16:19:02 +00:00
ce588ae61d
Add MID/RID configurability to RTPSender.
...
With the new config option |always_send_mid_and_rid|, the user
of the RTPSender can decide if MIDs and RIDs should always be sent
(when provided and negotiated), or if their sending should be disabled
after the receiver has acked the stream. Depending on the use case,
different settings might be preferable. The default setting is not
changed in this CL.
Bug: webrtc:11416
Change-Id: Ic3c71a6105fb7ee08d53cf9eb03f4e53b5799610
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170109
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30742}
2020-03-10 14:12:20 +00:00
84a1b3e9ba
Remove nisse from call/OWNERS
...
Bug: None
Change-Id: Ic7b86ce4fd0c694f62e6dd4243c571a486f4a34d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170049
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30741}
2020-03-10 12:52:54 +00:00
b2678cfefe
Roll chromium_revision 5a78076ccc..29afd4ae2e (748288:748637)
...
Change log: 5a78076ccc..29afd4ae2e5a78076ccc..29afd4ae2ecb9c7743fc..941c32bd5837411900cf..5007d4594cfa6ae42dcf..1a8a3a71e021082355b1..cb01a2be34e2d1db790b..c3b1c1980be356b32dbc..c0ce153b13https://chromium.googlesource.com/catapult.git/+log/c5f5b9e951..9e5db26faa
* src/third_party/depot_tools: ffd02955e6..0c4a3c25037a8bc9a90c..a68325e7d98da3555008..b920323e030ac28472d0..cc958279ff5a78076ccc..29afd4ae2eTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I15ad894513429be586ea96e19b358d833073782c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170180
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#30740}
2020-03-10 12:44:14 +00:00
5b60b19c62
Cleanup: Removes unused AimdRateControl field trials.
...
Bug: webrtc:9883
Change-Id: I4a15ae20ea1fa7cc05a8e898fb6de35cd0fe4acc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169849
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Reviewed-by: Minyue Li <minyue@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30739}
2020-03-10 12:00:19 +00:00
eac08bfe23
Reland "Wire up internal libvpx VP9 scaler to statistics proxy"
...
This reverts commit a2cb93d8b9659292f7ec73db53421d481f84c22c.
Reason for revert: Reland with no changes after downstream projects are
updated.
Original change's description:
> Revert "Wire up internal libvpx VP9 scaler to statistics proxy"
>
> This reverts commit 50327a51007c3e25bc3bcd35b5d0945fe0f27d05.
>
> Reason for revert: Breaks downstream tests
>
> Original change's description:
> > Wire up internal libvpx VP9 scaler to statistics proxy
> >
> > Bug: webrtc:11396
> > Change-Id: I5ac69208b00cc75d4e5dbb3ab86f234b3e1f29f8
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169922
> > Reviewed-by: Niels Moller <nisse@webrtc.org >
> > Reviewed-by: Henrik Boström <hbos@webrtc.org >
> > Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#30725}
>
> TBR=ilnik@webrtc.org ,hbos@webrtc.org ,nisse@webrtc.org
>
> Change-Id: I53dcb41bdf8f8dccfcd43b717509ec047f590648
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:11396
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170102
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30734}
TBR=ilnik@webrtc.org ,hbos@webrtc.org ,nisse@webrtc.org ,srte@webrtc.org
Change-Id: Ie47df4aec199701256c1dba8fa64176683becabc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11396
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170105
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30738}
2020-03-10 11:15:51 +00:00
7427fc6560
Hand protos directly to histograms and fix summary.
...
The catapult code has learned how to deserialize protos, so we don't
need JSON as a middle step.
Also, set summary options to false for now to avoid polluting the
dashboard with _avg, _count for each metric. We don't use those
anyway. The durable solution is to set these from the histogram
writer, but catapult doesn't read the summary options correctly
from the proto yet.
Bug: chromium:1029452
Change-Id: I59d300fd34d36df836064ff41f6d0bf75bd6695e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170104
Commit-Queue: Patrik Höglund <phoglund@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30737}
2020-03-10 10:43:17 +00:00
c782263e5f
Whitespace change to kick bots.
...
TBR: phoglund@webrtc.org
Bug: None
No-Try: True
No-Tree-Checks: true
Change-Id: I7c39b96c59ab074809137b10e31d722a1c43d098
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170106
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30736}
2020-03-10 10:21:56 +00:00
3bdc5e9a5f
Delete ACMVADCallback
...
This callback is enabled via the method
AudioCodingModule::RegisterVADCallback, which is unused, and deleted
in this cl.
Bug: None
Change-Id: I04c8690fbb673305e69fe5b1c32d88efd6c72d1b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/148420
Reviewed-by: Minyue Li <minyue@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30735}
2020-03-10 09:53:46 +00:00
a2cb93d8b9
Revert "Wire up internal libvpx VP9 scaler to statistics proxy"
...
This reverts commit 50327a51007c3e25bc3bcd35b5d0945fe0f27d05.
Reason for revert: Breaks downstream tests
Original change's description:
> Wire up internal libvpx VP9 scaler to statistics proxy
>
> Bug: webrtc:11396
> Change-Id: I5ac69208b00cc75d4e5dbb3ab86f234b3e1f29f8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169922
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#30725}
TBR=ilnik@webrtc.org ,hbos@webrtc.org ,nisse@webrtc.org
Change-Id: I53dcb41bdf8f8dccfcd43b717509ec047f590648
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:11396
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170102
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30734}
2020-03-10 08:09:50 +00:00
137991396d
Make a switch to disable DTLS 1.0, TLS 1.0 and TLS 1.1 downgrade in WebRTC.
...
This reverts commit af1f8655b2cb69af382396ea642eb0a2bf04bb4d
Landing the change with default set to
"enabled" (DTLS 1.0 will continue to work by default),
so that flipping the default can be a separate CL.
Original change's description:
> Revert "Disable DTLS 1.0, TLS 1.0 and TLS 1.1 downgrade in WebRTC."
>
> This reverts commit 7276b974b78ea4f409d8738b1b6f1515f7a8968e.
>
> Reason for revert: Changing to a later Chrome release.
>
> Original change's description:
> > Disable DTLS 1.0, TLS 1.0 and TLS 1.1 downgrade in WebRTC.
> >
> > This change disables DTLS 1.0, TLS 1.0 and TLS 1.1 in WebRTC by default. This
> > is part of a larger effort at Google to remove old TLS protocols:
> > https://security.googleblog.com/2018/10/modernizing-transport-security.html
> >
> > For the M74 timeline I have added a disabled by default field trial
> > WebRTC-LegacyTlsProtocols which can be enabled to support these cipher suites
> > as consumers move away from these legacy cipher protocols but it will be off
> > in Chrome.
> >
> > This is compliant with the webrtc-security-arch specification which states:
> >
> > All Implementations MUST implement DTLS 1.2 with the
> > TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 cipher suite and the P-256
> > curve [FIPS186]. Earlier drafts of this specification required DTLS
> > 1.0 with the cipher suite TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA, and
> > at the time of this writing some implementations do not support DTLS
> > 1.2; endpoints which support only DTLS 1.2 might encounter
> > interoperability issues. The DTLS-SRTP protection profile
> > SRTP_AES128_CM_HMAC_SHA1_80 MUST be supported for SRTP.
> > Implementations MUST favor cipher suites which support (Perfect
> > Forward Secrecy) PFS over non-PFS cipher suites and SHOULD favor AEAD
> > over non-AEAD cipher suites.
> >
> > Bug: webrtc:10261
> > Change-Id: I847c567592911cc437f095376ad67585b4355fc0
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125141
> > Commit-Queue: Benjamin Wright <benwright@webrtc.org >
> > Reviewed-by: David Benjamin <davidben@webrtc.org >
> > Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#27006}
>
> TBR=steveanton@webrtc.org ,davidben@webrtc.org ,qingsi@webrtc.org ,benwright@webrtc.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: webrtc:10261
> Change-Id: I34727e65c069e1fb2ad71838828ad0a22b5fe811
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/130367
> Commit-Queue: Benjamin Wright <benwright@webrtc.org >
> Reviewed-by: Benjamin Wright <benwright@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27403}
Bug: webrtc:10261
Change-Id: I28c6819d37665976e396df280b4abf48fb91d533
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/169851
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Benjamin Wright <benwright@webrtc.org >
Reviewed-by: Qingsi Wang <qingsi@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#30733}
2020-03-09 19:23:44 +00:00
