d2541e81c6
Remove <iostream> usage from loopback.cc
...
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1522004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4077 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-21 11:09:36 +00:00
375deb4e19
Suffix VcmCapturer's privates with underscore_
...
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1506005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4076 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-21 09:32:22 +00:00
cb9cff0c71
Add functions to ViE API to enable/disable the absolute send time header extension.
...
BUG=
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1487004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4065 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-20 12:00:23 +00:00
8d6eb56085
Avoid NPE crash on Android platforms that don't support getting preview framerate.
...
- catch Camera.setParameters() signaling errors through RuntimeException (!)
- make video_demo_apk rebuild when .java sources change
BUG=1778
R=wu@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1493004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4059 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-17 17:33:31 +00:00
21632124dd
Include gflags properly and X11 include order in VideoEngine.
...
BUG=
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1500004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4057 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-17 14:25:02 +00:00
f5d4cb1958
Include files from webrtc/.. paths in video_engine/
...
BUG=1662
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1492004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4056 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-17 13:44:48 +00:00
e874a8f24b
Enable WebRTC demo application on x86 Android
...
Steps to build the demo application for x86 Android:
source build/android/envsetup.sh --target-arch=x86
gclient runhooks
ninja -C out/Debug
cd webrtc/video_engine/test/android
ndk-build APP_ABI=x86
ant debug
R=fischman@webrtc.org , leozwang@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1478004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4053 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-17 05:41:07 +00:00
29d5839233
New VideoEngine API implementation on top of old one, first steps.
...
BUG=1668
R=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1360004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4044 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-16 12:08:03 +00:00
4dee30927a
Remove SetOverUseDetectorOptions and cleaned ViESharedData.
...
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1486004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4042 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-16 11:13:18 +00:00
29b2219914
Adding a factory to remote bitrate estimator and allow it to be set via config.
...
Additionally:
- clean api to set remote bitrate estimator mode.
- clean api to set over use detector options.
R=mflodman@webrtc.org , stefan@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1448006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4027 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 12:10:58 +00:00
c9cb4fffac
Fix typo in log statement. witdh should be width.
...
BUG=none
TESTED=try bots
Review URL: https://webrtc-codereview.appspot.com/1466004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4016 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-14 05:02:08 +00:00
c53480fbcf
Disabled flaky codec test (RunsCodecTestWithoutErrors)
...
BUG=1734
TBR=mflodman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1460004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4009 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-13 15:10:02 +00:00
d6ed000585
This is the first step to convert building the Android WebRTC demo to a proper GYP target, android ndk toolchains is being used to build the jni cpp files instead of using ndk-build.
...
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1444005
Patch from Jeremy Mao <yujie.mao@intel.com >.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3999 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-10 16:34:01 +00:00
6a36f0e46f
Since the layout of the Android WebRTC demo application is fixed, if we start the demo application in portrait postion, the activity will be destroyed and then created again, force the demo application to start in landscape position to avoid activity re-creation.
...
BUG=webrtc:1741
TEST=Build and run the Android WebRTC demo application
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1439006
Patch from Jeremy Mao <yujie.mao@intel.com >.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3994 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-09 17:40:33 +00:00
e525309004
WebRTCDemo Android doesn't hangle activity recreation correctly.
...
Also optimize Statsview a little bit.
BUG=1740
TEST=Manual test with WebRTCDemo Android
R=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1439005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3993 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-09 08:52:50 +00:00
ebdfa8dcba
Add fischman into OWNERS of WebRTCDemo Android.
...
BUG=
TBR=fischman@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1450005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3991 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-09 07:30:38 +00:00
d72262dc01
Fix compile errors in ViE with latest clang.
...
Rolling to the latest Chromium picks up a new clang, which catches a fresh error:
error: 'reinterpret_cast' to class 'webrtc::VideoEngineImpl *' from its base at non-zero offset 'webrtc::VideoEngine *' behaves differently from 'static_cast' [-Werror,-Wreinterpret-base-class]
VideoEngineImpl* vie_impl = reinterpret_cast<VideoEngineImpl*>(video_engine);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../webrtc/video_engine/vie_codec_impl.cc:36:31: note: use 'static_cast' to adjust the pointer correctly while downcasting
VideoEngineImpl* vie_impl = reinterpret_cast<VideoEngineImpl*>(video_engine);
^~~~~~~~~~~~~~~~
static_cast
This was triggered by André's change here:
https://code.google.com/p/webrtc/source/detail?r=3986
which made VideoEngineImpl a derived class of VideoEngine (good).
Picked up one other error as well:
error: implicit conversion from 'long' to 'int' changes value from 9223372036854775807 to -1 [-Werror,-Wconstant-conversion]
AutoTestSleep(std::numeric_limits<long>::max());
~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This fixes the errors and is required before stable can be rolled in Chromium.
TBR=mflodman,andresp
Review URL: https://webrtc-codereview.appspot.com/1450004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3989 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-09 02:12:07 +00:00
3004c79c6a
Fix clang errors in non-GYP_DEFINES=clang=1 build
...
BUG=1623
R=stefan@webrtc.org , tina.legrand@webrtc.org , tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1368004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3968 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-07 12:36:21 +00:00
42636e82d0
Removing bad code resulting in flaky test.
...
BUG=1723
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1390004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3941 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-02 21:02:04 +00:00
0d95e06a2f
Bugfix custom call stop.
...
BUG=1717
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1388004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3938 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-02 18:25:03 +00:00
3c48f31e5b
WebRTCDemo Android app to route audio to headphone when it's plugged in.
...
BUG=1654
TEST=WebRTCDemo app
Review URL: https://webrtc-codereview.appspot.com/1348004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3932 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-05-02 03:18:00 +00:00
342353780d
Consolidate common_audio into a single target.
...
In principle should reduce gyp processing time, but the difference was not measurable. In any case, it's a good simplification that aligns with having a single common_video target.
R=bjornv@webrtc.org , kma@webrtc.org , tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1375004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3928 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-30 23:43:26 +00:00
dd807ac474
Adding buffered mode to loopback test
...
Review URL: https://webrtc-codereview.appspot.com/1371004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3920 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-30 15:19:47 +00:00
47128ab5ab
Removing vie file related code from vie_custom_call
...
Follow up on https://code.google.com/p/webrtc/source/detail?r=3900
Review URL: https://webrtc-codereview.appspot.com/1361004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3911 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-26 20:09:54 +00:00
c41478f7eb
Ensure build_demo.py run subprocesses with bash shell.
...
It turns out the default shell becomes /bin/sh on Lucid. By specifying the shell for subprocess.check_call we ensure bash is used.
Thanks to yujie.mao@intel.com for pointing this out.
BUG=1659
TEST=Successful build with build_demo.py both on Ubuntu Lucid and Precise.
TBR=leozwang
Review URL: https://webrtc-codereview.appspot.com/1343004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3875 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-19 11:50:42 +00:00
6e788df19e
Remove vim/emacs modelines from .gypi files
...
BUG=1655
Review URL: https://webrtc-codereview.appspot.com/1326005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3857 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-16 12:40:34 +00:00
6f41ca9fd2
WebRTCDemo: Enable making multiple calls.
...
Previously after the first call subsequent attempts to bind the RTP/RTCP ports would fail, since r3754.
BUG=1618
Review URL: https://webrtc-codereview.appspot.com/1302007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3817 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-10 20:33:27 +00:00
b238d1210b
WebRtc_Word32 -> int32_t in video_engine/
...
BUG=314
Review URL: https://webrtc-codereview.appspot.com/1302005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3801 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-09 13:41:51 +00:00
6faf71d27b
Remove the old unused udp_transport
...
Review URL: https://webrtc-codereview.appspot.com/1272009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3788 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-08 23:25:25 +00:00
367804cce2
Clean packets on the network when closing + made loopback test actually run again.
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/1290006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3776 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-08 10:42:50 +00:00
10eb92039b
Add GYP target for WebRTC Video demo for Android.
...
Add a build target for the Video demo app for Android that only
exists when OS=='android' during build.
Note that this doesn't solve webrtc:1029, it's more like a workaround
waiting for the complete solution, which is to great a proper GYP target
that doesn't involve an action and an external script.
BUG=1029
TEST=Built successfully with:
source build/android/envsetup.sh
gclient runhooks
ninja -C out/Debug
Also verified the target is not present when OS is not 'android'.
Review URL: https://webrtc-codereview.appspot.com/1286004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3769 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-05 13:36:32 +00:00
b5bf54c4e7
Permit arbitrary payload names for kVideoCodecGeneric.
...
BUG=1575
Review URL: https://webrtc-codereview.appspot.com/1282005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3768 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-05 13:27:38 +00:00
82dcc9ff11
Remove UDP transport API from ViE
...
Review URL: https://webrtc-codereview.appspot.com/1232004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3754 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-04-02 20:37:14 +00:00
a442d4d983
Removed all code enclosed in WEBRTC_SRTP #ifdefs, and the unsupported VoE SRTP APIs. Test stubs are left in place as we still have the (De)RegisterExternalEncryption() APIs, although they are currently untested.
...
Today I had to figure out this code was legacy. Now next person doesn't have to.
BUG=
Review URL: https://webrtc-codereview.appspot.com/1247004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3738 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-28 09:14:36 +00:00
458194ba65
Fix broken audio.
...
The problem was introduced in 3712, no need to external transport in
real test app, revert the change.
TBR=pwestin@webrtc.org
BUG=1539
Review URL: https://webrtc-codereview.appspot.com/1266005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3735 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-27 20:55:54 +00:00
e1a7193869
Fix flakiness in network up/down event tests when running under memcheck.
...
TBR=pwestin@webrtc.org
BUG=1524
Review URL: https://webrtc-codereview.appspot.com/1261005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3732 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-27 17:01:48 +00:00
add50b94a5
WebRTCDemo: remove unnecessary stop & start during orientation change which isn't necessary since API v14.
...
(required bumping minSdkVersion to 14)
This fixes a RuntimeException thrown on GalaxyNexus (but not N7, N4, or NS)
during startPreview() after the sequence of Start(), Stop(), Start(); seemingly
GN's OMX stack can't deal with parallel startPreview() & setPreviewDisplay() in
this situation.
Also:
- Only set the surface in the camera when valid
- Remove duplicate assignment
- Fix error check on voiceChannel allocation to account for multiple channel creation due to orientation change causing onDestroy()/onCreate() on the app, and rampant use of process-static holders for VoE data.
BUG=1537
Review URL: https://webrtc-codereview.appspot.com/1259005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3731 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-27 16:48:34 +00:00
bfacda60be
Add interface to signal a network down event.
...
- In real-time mode encoding will be paused until the network is back up.
- In buffering mode the encoder will keep encoding, and packets will be
buffered at the sender. When the buffer grows above the target delay
encoding will be paused.
- Fixes a couple of issues related to pacing which was found with the new test.
- Introduces different max bitrates for pacing and for encoding. This allows
the pacer to faster get rid of the queue after a network down event.
(Work based on issue 1237004)
BUG=1524
TESTS=trybots,vie_auto_test
Review URL: https://webrtc-codereview.appspot.com/1258004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3730 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-27 16:36:01 +00:00
a078d5cc38
Bugfix for extended RTP/RTCP test
...
TBR=mflodman
Review URL: https://webrtc-codereview.appspot.com/1234004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3713 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-22 20:03:03 +00:00
26e35e1d06
Move the VIE tests to use external transport instead of the built in udp transport
...
Review URL: https://webrtc-codereview.appspot.com/1216010
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3712 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-22 19:21:27 +00:00
94bc4cf905
Add min and target bitrate to VideoCodec.
...
Review URL: https://webrtc-codereview.appspot.com/1214004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3710 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-22 17:13:08 +00:00
8911ce46a4
Generic video-codec support.
...
Labels frames as key/delta, also marks the first RTP packet of a frame as such,
to allow proper reconstruction even if packets are received out of order.
BUG=1442
TBR=ajm@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1207004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3680 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-18 16:39:03 +00:00
684f0577fb
Revert r3667 and r3665
...
Review URL: https://webrtc-codereview.appspot.com/1199004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3668 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-13 23:20:57 +00:00
2dc0367406
Added destructors for tests to control destruct order
...
TBR=mflodman
Review URL: https://webrtc-codereview.appspot.com/1197005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3667 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-13 21:36:10 +00:00
361bac7a4f
Removed the engine API:s related to transport such as SetSendDestination, the functionality is now provided via the test frame work.
...
Review URL: https://webrtc-codereview.appspot.com/1029004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3665 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-13 17:52:42 +00:00
efe4edb6da
Enabling bufffering mode with no sync module or VoE
...
BUG= 1454
Review URL: https://webrtc-codereview.appspot.com/1149006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3625 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-06 23:29:33 +00:00
ea386147f1
Update integration tests for idempotent RTP header settings.
...
Review URL: https://webrtc-codereview.appspot.com/1152004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3593 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-03-01 23:43:14 +00:00
0b6293aaaa
Fixed typo in vie_autotest_loopback.cc.
...
Review URL: https://webrtc-codereview.appspot.com/1114004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3542 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-20 12:13:10 +00:00
eb91792cfd
Refactoring temporal layers implementation and adding VideoCodecMode for easier control of codec settings.
...
Review URL: https://webrtc-codereview.appspot.com/1105007
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3528 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-18 14:40:18 +00:00
3897255b63
Add VoE interface to VieRTP test
...
BUG=
Review URL: https://webrtc-codereview.appspot.com/1097015
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3527 4adac7df-926f-26a2-2b94-8c16560cd09d
2013-02-16 01:35:59 +00:00