fefa77c426
Add pthread thread-local storage support for ScopedYieldPolicy
...
Emscripten does not support C++11 thread_local but does support
the pthread TLS API.
Bug: None
Change-Id: Ia21895148d1df7652579d086d9e1c0c53d7a85f4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145441
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28621}
2019-07-19 14:33:53 +00:00
836ab13f1c
Remove rtc::Flag.
...
WebRTC has been migrated to Abseil Flags.
Bug: webrtc:10616
Change-Id: Id4a363429ccd2dd55c0dff00c9490c15124fdccc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144631
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28620}
2019-07-19 14:05:01 +00:00
63741c7fa1
Don't use all_dependent_configs for sdk frameworks
...
libs should be propagated to the final binary even without that:
https://gn.googlesource.com/gn/+/master/docs/reference.md#var_libs
But add some missing SDK framework dependencies:
* RTCNativeI420Buffer.mm uses CGBitmapContextGetBytesPerRow.
* socketrocket uses SecCertificateCopyData.
Bug: None
Change-Id: Iba38a5dfaf470a5a790d494cbec8ade44b1d16ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/146082
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28605}
2019-07-19 06:30:54 +00:00
7f8dbe18ea
Add config to specify raw audio priority bitrate including overhead.
...
Bug: webrtc:10815
Change-Id: I6a498d6c6bcd4fe4ba6ccc4d6f407d686528d946
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145333
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28590}
2019-07-17 15:28:46 +00:00
0182a0300f
Reland "Remove the injectable bitrate allocation strategy API."
...
This is a reland of 80cb3f6db622442b6360e67851e8903aa0d06d03
Original change's description:
> Remove the injectable bitrate allocation strategy API.
>
> This removes PeerConnectionInterface::SetBitrateAllocationStrategy()
> plus a ton of now-dead code.
>
> Bug: webrtc:10556
> Change-Id: Icfae3bdd011588552934d9db4df16000847db7c3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133169
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28523}
TBR=kwiberg@webrtc.org
Bug: webrtc:10556
Change-Id: Ic17a7a7cc447292306876ee9582ad62fd2499765
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145900
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28585}
2019-07-17 10:20:45 +00:00
1cd6f3224a
Fix typo in comment.
...
TBR=artit@webrtc.org
No-Try: True
Bug: None
Change-Id: I96bdc4788b58f3e7f45da5e8ba383d991382079a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145404
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28566}
2019-07-12 19:51:23 +00:00
e95b57cdfc
Revert "Remove the injectable bitrate allocation strategy API."
...
This reverts commit 80cb3f6db622442b6360e67851e8903aa0d06d03.
Reason for revert: Performance regression on downstream project.
Original change's description:
> Remove the injectable bitrate allocation strategy API.
>
> This removes PeerConnectionInterface::SetBitrateAllocationStrategy()
> plus a ton of now-dead code.
>
> Bug: webrtc:10556
> Change-Id: Icfae3bdd011588552934d9db4df16000847db7c3
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133169
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Reviewed-by: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28523}
TBR=henrika@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org ,srte@webrtc.org ,alexnarest@webrtc.org ,jonasolsson@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:10556
Change-Id: Ife905d661e7b1a227662395c729a9336c62fd2d7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145338
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28560}
2019-07-12 15:27:19 +00:00
6564366f75
Use -Wno-undef to compile jsoncpp.
...
This should fix this error:
In file included from ../../api/audio/echo_canceller3_config_json.cc:19:
In file included from ../..\rtc_base/strings/json.h:18:
In file included from ../../third_party/jsoncpp/source/include\json/json.h:9:
In file included from ../../third_party/jsoncpp/source/include\json/autolink.h:9:
../../third_party/jsoncpp/source/include\json/config.h(126,5): error: '__GNUC__' is not defined, evaluates to 0 [-Werror,-Wundef]
Maybe we could also fix it upstream.
Bug: webrtc:10770
Change-Id: I68434c6957189f680625bd2f2b85422965a89785
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/145322
Reviewed-by: Artem Titarenko <artit@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28558}
2019-07-12 13:13:46 +00:00
80cb3f6db6
Remove the injectable bitrate allocation strategy API.
...
This removes PeerConnectionInterface::SetBitrateAllocationStrategy()
plus a ton of now-dead code.
Bug: webrtc:10556
Change-Id: Icfae3bdd011588552934d9db4df16000847db7c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133169
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28523}
2019-07-10 13:13:25 +00:00
a0eefc17f7
Rename USE_NATIVE_MUTEX_ON_MAC to RTC_USE_NATIVE_MUTEX_ON_MAC.
...
WebRTC internal macros should be prefixed by RTC_.
Bug: None
Change-Id: I1a0be41ca1ea35173edf34bc190fc425c5f2c67b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144782
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28509}
2019-07-08 16:54:29 +00:00
a4d873786f
Format almost everything.
...
This CL was generated by running
git ls-files | grep -P "(\.h|\.cc)$" | grep -v 'sdk/' | grep -v 'rtc_base/ssl_' | \
grep -v 'fake_rtc_certificate_generator.h' | grep -v 'modules/audio_device/win/' | \
grep -v 'system_wrappers/source/clock.cc' | grep -v 'rtc_base/trace_event.h' | \
grep -v 'modules/audio_coding/codecs/ilbc/' | grep -v 'screen_capturer_mac.h' | \
grep -v 'spl_inl_mips.h' | grep -v 'data_size_unittest.cc' | grep -v 'timestamp_unittest.cc' \
| xargs clang-format -i ; git cl format
Most of these changes are clang-format grouping and reordering includes
differently.
Bug: webrtc:9340
Change-Id: Ic83ddbc169bfacd21883e381b5181c3dd4fe8a63
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144051
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28505}
2019-07-08 13:45:15 +00:00
48284b86d4
BalancedDegradationSettings: Add option to configure fps based on codec type.
...
Bug: none
Change-Id: I43b3d976b9400a0552fee80a6a65c215c71049ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144543
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28503}
2019-07-08 11:46:25 +00:00
51f599bdaa
Make rtc_base/base_java public.
...
Bug: webrtc:9048
Change-Id: I4ce8219fcc751ee89050a075df5ad44fc9e68237
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144524
Reviewed-by: Magnus Jedvert <magjed@webrtc.org >
Commit-Queue: Sami Kalliomäki <sakal@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28471}
2019-07-03 14:44:46 +00:00
84ce3c08a5
Macro rename s/CS_DEBUG_CHECKS/RTC_CS_DEBUG_CHECKS.
...
Bug: None
Change-Id: Ie55de3148cb450de8e37d53e810f2a2d590a1f6c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144049
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28466}
2019-07-03 13:49:52 +00:00
a2b30d8940
Add functions to read from/write to bitstream values with known max value
...
Bug: webrtc:10342
Change-Id: I701b09de574eb463daaf8d2c19008ac3452879eb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144033
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28465}
2019-07-03 13:30:01 +00:00
2c5af4f6dc
Add * and / operator into SamplesStatsCounter.
...
Add * and / operator into SamplesStatsCounter to simplify convertion
between samples units.
Bug: webrtc:10138
Change-Id: I985b60bc63c071ceaf0fddcdbcd3e6476353c0fe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/142171
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28456}
2019-07-03 09:19:36 +00:00
a09484940b
RateControlSettings: add option to set min pixels per frame for libvpx vp8.
...
Bug: none
Change-Id: I09aa1bcea2f4a9cd65ffeef1df1d9656e4604def
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144029
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28412}
2019-06-28 10:54:23 +00:00
9407776aa2
Temporarily suppress -Wdeprecated-declarations to update jsoncpp.
...
This is required to land [1] which introduces new APIs and deprecates
the old ones.
[1] - https://chromium-review.googlesource.com/c/chromium/src/+/1674449
Bug: webrtc:10770
Change-Id: Iceadf1fa1a3324db6c53f5c822c64ed6fc59fc76
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144021
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28407}
2019-06-27 20:00:26 +00:00
2644a703cc
Delete rtc::TryCritScope as unused
...
Bug: None
Change-Id: I9288f26d22835fc4e8ee7e5da5acfa4b4b527d8a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/143163
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28389}
2019-06-26 13:04:19 +00:00
1231419785
BalancedDegradationSettings: Add option to configure QP thresholds.
...
Add possibility to configure low/high QP thresholds based on resolution.
Bug: none
Change-Id: Iaa3168b77678bd74feb67295d7658c0140721231
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141867
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28348}
2019-06-24 09:32:51 +00:00
b028c6a8ff
Support __EMSCRIPTEN__ in rtc_base.
...
Bug: None
Change-Id: Ie0497e268b93ad15a164db85e8cefdb823d64a65
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140863
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28307}
2019-06-18 12:44:00 +00:00
5a8f860a01
Prepare for deletion of the NO_MAIN_THREAD_WRAPPING preprocessor define
...
This is a partial reland of
https://webrtc-review.googlesource.com/c/src/+/39680 ,
including only the (hopefully) non-problematic parts of it, but
postponing actual deletion of automatic thread wrapping.
Bug: webrtc:9714
Change-Id: I9b79dd073f0e945cbb62f3b54cff05eaaea9b06c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141664
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28265}
2019-06-13 13:51:17 +00:00
00e71ef49e
Fix TaskQueueLibevent::PostTask when used on the same TaskQueue
...
Stop using event_base_once because it doesn't guarantee to free QueuedTask when task not run and thus may break TaskQueue guarantee all posted tasks are eventually deleted
Bug: webrtc:10731, webrtc:10278
Change-Id: Id073a6092cf603cac5768da7a0770371053b20cc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141420
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28241}
2019-06-11 18:08:18 +00:00
171bd2644d
Delete unused MacOS code related to ERRCTX_OSSTATUS
...
Bug: webrtc:6424
Change-Id: I3f98d31677201fcc52e492a463945fb9f6f2e883
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138831
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28231}
2019-06-11 13:11:56 +00:00
d2e5013858
Delete optional Runnable argument to rtc::Thread::Start
...
Intended to simplify later changes to thread shutdown logic.
Bug: webrtc:10648
Change-Id: I61ba240c0f4b73a0bc6af6a3471804ecb434c41f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137510
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28219}
2019-06-11 08:24:50 +00:00
240b893fd2
Reland "Link fewer X11-related libraries"
...
This is a reland of 829a5dce900b781376ea72ba5d869c5dbe58a82d
(unchanged)
Downstream is fixed in https://chromium-review.googlesource.com/1651786
Original change's description:
> Link fewer X11-related libraries
>
> Use an explicit list and don't add X11 dependency to rtc_base.
>
> Allow skipping code that depends on rarer extensions such as Xdamage, Xfixes.
>
> Bug: None
> Change-Id: Icb8d20a267358f5cd3f1ff2af31a669e0670d2f6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140865
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Guido Urdaneta <guidou@webrtc.org >
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28204}
Bug: None
Change-Id: I51c60f7713eb49889cebbca2242f33b81b0aef39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141301
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28218}
2019-06-11 07:34:49 +00:00
4606ded90c
Revert "Link fewer X11-related libraries"
...
This reverts commit 829a5dce900b781376ea72ba5d869c5dbe58a82d.
Reason for revert: Suspect of breaking autoroll to chromium: https://crrev.com/c/1651414 .
Original change's description:
> Link fewer X11-related libraries
>
> Use an explicit list and don't add X11 dependency to rtc_base.
>
> Allow skipping code that depends on rarer extensions such as Xdamage, Xfixes.
>
> Bug: None
> Change-Id: Icb8d20a267358f5cd3f1ff2af31a669e0670d2f6
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140865
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Reviewed-by: Guido Urdaneta <guidou@webrtc.org >
> Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28204}
TBR=zijiehe@chromium.org ,mbonadei@webrtc.org ,henrika@webrtc.org ,oprypin@webrtc.org ,guidou@webrtc.org
Change-Id: Ie106de700fc017dafa603d15eaec88c4790dacfb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/141300
Reviewed-by: Marina Ciocea <marinaciocea@webrtc.org >
Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28215}
2019-06-10 19:53:42 +00:00
646e096e03
Allow null FILE* to AecDumpFactory::Create
...
Also add Create method with a FileWrapper argument, extracted from cl
https://webrtc-review.googlesource.com/c/src/+/140283
Bug: webrtc:6463
Change-Id: If86f17d5fda964df0b5874bd5a15fcaed899dd4e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140946
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Alex Loiko <aleloi@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28211}
2019-06-10 14:09:19 +00:00
dfd7f3074e
Delete unneeded includes of string_utils.h
...
Bug: None
Change-Id: I3618903ebd6d6888c2a9548dc97761d0d2e74d0a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140040
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28207}
2019-06-10 10:44:40 +00:00
829a5dce90
Link fewer X11-related libraries
...
Use an explicit list and don't add X11 dependency to rtc_base.
Allow skipping code that depends on rarer extensions such as Xdamage, Xfixes.
Bug: None
Change-Id: Icb8d20a267358f5cd3f1ff2af31a669e0670d2f6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140865
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Guido Urdaneta <guidou@webrtc.org >
Reviewed-by: Henrik Andreassson <henrika@webrtc.org >
Commit-Queue: Oleh Prypin <oprypin@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28204}
2019-06-10 08:44:17 +00:00
79976e02fe
Fix error message in rtc_base/system/arch.h
...
No-Try: True
Bug: None
Change-Id: Ic604c4a3f219703eb7c105bf1f73ccd0f9934766
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140862
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28199}
2019-06-07 22:58:48 +00:00
26b5e35276
Adds Frequency unit type.
...
Bug: webrtc:10674
Change-Id: Ic0ddca46d8522d994bbeba072a73836b506fe40f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138261
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28192}
2019-06-07 09:54:02 +00:00
d3a4ebe332
Control rtt_mult addition cap via experiment.
...
Bug: webrtc:10717
Change-Id: I68f7d8216e1a1611e692dd82ba96890cad98c7de
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140284
Commit-Queue: Michael Horowitz <mhoro@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28191}
2019-06-07 09:43:26 +00:00
7b06b9b202
Remove pthatcher@webrtc.org from OWNERS
...
Bug: webrtc:10381
No-Try: True
Change-Id: I485d3869eb340bdf078c829cb893f01b4fa9258b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140300
Reviewed-by: Peter Thatcher <pthatcher@webrtc.org >
Commit-Queue: Peter Thatcher <pthatcher@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28176}
2019-06-05 19:47:20 +00:00
9930929303
Adds srte@ as OWNER of units.
...
Bug: webrtc:9883
Change-Id: I003a459ba5c37b7fe844a0aff7178c2fd8b2de81
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139247
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28171}
2019-06-05 15:08:57 +00:00
4cd1c6a3db
Lockless SwapQueue
...
This change makes SwapQueue lockless in order to reduce lock contention
in the Audio Processing Module.
Bug: webrtc:10205
Change-Id: Idc3b2a85e959b467bc1653492e48eee42e236fa5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138901
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28135}
2019-06-03 11:49:49 +00:00
6806550d5d
Fix build with recent linux kernel.
...
Recent kernel commit[1] moved a bit the define for this constant. This revealed
a missing include in WebRTC.
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0768e17073dc5
Bug: webrtc:10677
Change-Id: I6ed69d307599d077760ae6ad74be10bfbdd1cac6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138270
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28108}
2019-05-29 15:04:55 +00:00
787f4b2a71
Fix text logging of ALR detector experiment settings.
...
Bug: None
Change-Id: I580528dee5492eb7e3458d114218de4c315804bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138900
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28088}
2019-05-28 14:35:37 +00:00
d9b4f3330f
Cleanup of AudioAllocationSettings flags.
...
Using simple IsEnabled/IsDisabled instead of the parser for Enabled/
Disabled flags to improve readability.
Bug: webrtc:9883
Change-Id: I3dbf906d49f99269f73a8ced6b3f042181228f3d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138078
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28062}
2019-05-24 14:14:08 +00:00
f25df35e14
Reland "Delete STACK_ARRAY macro, and use of alloca"
...
This is a reland of 74b373f04a69b279e45b0792d86c594cb33d22c1
Original change's description:
> Delete STACK_ARRAY macro, and use of alloca
>
> Refactor the few uses of STACK_ARRAY to avoid an extra copy
> on the stack.
>
> Bug: webrtc:6424
> Change-Id: I5c8f3c0381523db0ead31207d949df9a286c76ba
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137806
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28038}
Bug: webrtc:6424
Change-Id: Id635ccdfae12157cbb3ab9089c5e4a9f77f742ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138211
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28052}
2019-05-24 09:33:06 +00:00
c1b36669db
Revert "Delete STACK_ARRAY macro, and use of alloca"
...
This reverts commit 74b373f04a69b279e45b0792d86c594cb33d22c1.
Reason for revert: This breaks chromium, blocking webrtc from rolling.
...
In file included from ../../third_party/webrtc\rtc_base/strings/string_builder.h:23:
../../third_party/webrtc\rtc_base/string_utils.h(54,28): error: implicit conversion loses integer precision: 'std::__1::basic_string<wchar_t, std::__1::char_traits<wchar_t>, std::__1::allocator<wchar_t> >::size_type' (aka 'unsigned long long') to 'int' [-Werror,-Wshorten-64-to-32]
ws.size());
See https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8912652299012991936/+/steps/compile__with_patch_/0/stdout
Original change's description:
> Delete STACK_ARRAY macro, and use of alloca
>
> Refactor the few uses of STACK_ARRAY to avoid an extra copy
> on the stack.
>
> Bug: webrtc:6424
> Change-Id: I5c8f3c0381523db0ead31207d949df9a286c76ba
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137806
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28038}
TBR=kwiberg@webrtc.org ,nisse@webrtc.org
Change-Id: I223fceab60855dde363cc9ce8375e8f5cca43c02
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:6424
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138209
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28043}
2019-05-23 17:35:07 +00:00
74b373f04a
Delete STACK_ARRAY macro, and use of alloca
...
Refactor the few uses of STACK_ARRAY to avoid an extra copy
on the stack.
Bug: webrtc:6424
Change-Id: I5c8f3c0381523db0ead31207d949df9a286c76ba
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137806
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28038}
2019-05-23 13:10:13 +00:00
a352248c43
Add a config flag to disable the audio ALR probing request.
...
Bug: webrtc:10200
Change-Id: Ifc5ea100cd66a7ccd6b777259d6531c93118eeb1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138064
Reviewed-by: Oskar Sundbom <ossu@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28035}
2019-05-23 11:23:43 +00:00
e7e3601614
Remove hex_encode functions with raw buffer output from the header file
...
Moved into the anonymous namespace in string_encode.cc.
Bug: webrtc:6424
Change-Id: I5e8ea0f02c94d6de82ca4f875d16862eb2db3d2b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138073
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28034}
2019-05-23 10:53:56 +00:00
ecd3054b56
Replace a broken assumption in candidate gathering for mDNS candidates.
...
The gathering of host candidates with mDNS names is asynchronous and its
completion can happen after a srflx candidate is gathered by the same
underlying socket. We have a broken check in UDPPort::CreateConnection()
that assumes the gathering of host and srflx candidates is sequential.
This CL also does minor refactoring and clean-up.
Bug: chromium:944577
Change-Id: Ic28136a9515081f40b232a22fcbf4209814ed33a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/138043
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Jeroen de Borst <jeroendb@webrtc.org >
Reviewed-by: Amit Hilbuch <amithi@webrtc.org >
Commit-Queue: Qingsi Wang <qingsi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28030}
2019-05-22 22:58:58 +00:00
04f39242c2
Delete no longer used windows helpers
...
Utf8ToWindowsFilename:
Unused since deletion of FileStream, cl
https://webrtc-review.googlesource.com/c/src/+/128900
GetCurrentProcessIntegrityLevel and IsCurrentProcessLowIntegrity:
Unused since deletion of GetTemporaryFolder, cl
https://codereview.webrtc.org/2995413002
Bug: webrtc:6424
Change-Id: Iec9e1137c6873fd6f3d6888101bae1a741c9d4b1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137807
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28021}
2019-05-22 10:32:25 +00:00
04a3cc1ad9
Delete rtc_base/unittest_main.cc
...
Usage replaced with test/test_main.cc.
Bug: webrtc:5996
Change-Id: I65e7539f2072fb45255a3c1af0b10dd06e1701ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137805
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28010}
2019-05-21 14:44:11 +00:00
9d1840c3df
Revert "Delete NO_MAIN_THREAD_WRAPPING preprocessor define."
...
This reverts commit 0f78c6b28dbc0c9caa555ce89ce91b0f08c510ea.
Reason for revert: Breaks downstream tests.
Original change's description:
> Delete NO_MAIN_THREAD_WRAPPING preprocessor define.
>
> Since many tests rely on rtc::Thread::Current(), add an
> explicit rtc::AutoThread in the main() function used by tests.
>
> Bug: webrtc:9714
> Change-Id: Id82121967c9621fe1c2945846009c48139fa57da
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/39680
> Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#28000}
TBR=kwiberg@webrtc.org ,nisse@webrtc.org ,kthelgason@webrtc.org
Change-Id: Iff939bb0d5ad0ea01b953321993733bb56c9070b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9714
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137512
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28001}
2019-05-21 07:26:54 +00:00
0f78c6b28d
Delete NO_MAIN_THREAD_WRAPPING preprocessor define.
...
Since many tests rely on rtc::Thread::Current(), add an
explicit rtc::AutoThread in the main() function used by tests.
Bug: webrtc:9714
Change-Id: Id82121967c9621fe1c2945846009c48139fa57da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/39680
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#28000}
2019-05-21 06:53:54 +00:00
f4e085a499
Using absl traits for checks and logging.
...
Bug: webrtc:9883
Change-Id: If4af810c1ba64c6c022c0fb5328a75527bec5934
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133622
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27993}
2019-05-20 18:39:12 +00:00
