Reason for revert:
Doing a reland where systeminfo.cc includes basictypes.h so that CPU_X86 etc. are defined when they are checked/used.
Original issue's description:
> Revert of Replace basictypes.h with stdint.h for int_t types. (patchset #1 id:1 of https://codereview.webrtc.org/2604043002/ )
>
> Reason for revert:
> Very likely cause of Chromium import bot breakage (unused function '__cpuid'), TBD why.
>
> Original issue's description:
> > Replace basictypes.h with stdint.h for int_t types.
> >
> > Removes basictypes.h for types that only makes use of it for fixed-size-int
> > typedefs and replaces it with stdint.h.
> >
> > BUG=webrtc:6853
> > R=tommi@webrtc.org
> >
> > Review-Url: https://codereview.webrtc.org/2604043002
> > Cr-Commit-Position: refs/heads/master@{#15867}
> > Committed: 7fd1a75300
>
> TBR=tommi@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6853
>
> Review-Url: https://codereview.webrtc.org/2603203003
> Cr-Commit-Position: refs/heads/master@{#15869}
> Committed: 7eb0e23bcf
BUG=webrtc:6853
TBR=tommi@webrtc.org
Review-Url: https://codereview.webrtc.org/2609783002
Cr-Commit-Position: refs/heads/master@{#15873}
State and priority added to ConnectionInfo. The Connection::State enum
is replaced by IceCandidatePairState enum class.
At P2PTransportChannel::GetStats, Connection::stats is called, producing
ConnectionInfo for the connection that is then filled in with additional
values from the Connection. This is refactored so that all values are
set by Connection::stats.
RTCStatsCollector is updated to surface the ConnectionInfo stats.
BUG=webrtc:6755, chromium:633550, chromium:627816
Review-Url: https://codereview.webrtc.org/2597423003
Cr-Commit-Position: refs/heads/master@{#15870}
Reason for revert:
Very likely cause of Chromium import bot breakage (unused function '__cpuid'), TBD why.
Original issue's description:
> Replace basictypes.h with stdint.h for int_t types.
>
> Removes basictypes.h for types that only makes use of it for fixed-size-int
> typedefs and replaces it with stdint.h.
>
> BUG=webrtc:6853
> R=tommi@webrtc.org
>
> Review-Url: https://codereview.webrtc.org/2604043002
> Cr-Commit-Position: refs/heads/master@{#15867}
> Committed: 7fd1a75300TBR=tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6853
Review-Url: https://codereview.webrtc.org/2603203003
Cr-Commit-Position: refs/heads/master@{#15869}
Removes basictypes.h for types that only makes use of it for fixed-size-int
typedefs and replaces it with stdint.h.
BUG=webrtc:6853
R=tommi@webrtc.org
Review-Url: https://codereview.webrtc.org/2604043002
Cr-Commit-Position: refs/heads/master@{#15867}
TestMemberIsPositive and TestMemberIsNonNegative added and used in test.
BUG=chromium:627816
Review-Url: https://codereview.webrtc.org/2593623002
Cr-Commit-Position: refs/heads/master@{#15866}
Files only making use of size_t from basictypes.h are replaced with
stddef.h, except in cases where they already for instance use stdio.h or
stdlib.h that already provide size_t.
BUG=webrtc:6853
R=tommi@webrtc.org
Review-Url: https://codereview.webrtc.org/2605123002
Cr-Commit-Position: refs/heads/master@{#15865}
No stats are collected by it, remove to reduce unnecessary thread hops.
BUG=webrtc:6875, chromium:627816
Review-Url: https://codereview.webrtc.org/2583193002
Cr-Commit-Position: refs/heads/master@{#15862}
This CL adds the first layer of the echo canceller 3.
All of the code is as it should, apart from
block_processor.* which only contains placeholder
functionality. (Upcoming CLs will add proper
functionality into those files.)
BUG=webrtc:6018
Review-Url: https://codereview.webrtc.org/2584493002
Cr-Commit-Position: refs/heads/master@{#15861}
This test was inadvertently made useless in https://codereview.webrtc.org/2558303002/.
Prior to that CL, at least 100 media packets -- but no ULPFEC packets -- had to
be sent before the test claimed that ULPFEC was not utilized. This CL reinstates
that behaviour, but instead of counting packets we expect the test to time out
when ULPFEC should not be utilized.
This solution is simple in code, but increases the test duration from 70 ms
to 10000 ms. Note, however, that the 70 ms duration was for a test that didn't
test anything interesting...
TESTED=Using gtest-parallel locally: 2000 test runs without flakes.
BUG=webrtc:6851
Review-Url: https://codereview.webrtc.org/2592693002
Cr-Commit-Position: refs/heads/master@{#15859}
These entries are not using exec_script anymore so we can enforce the
check and remove them from the whitelist.
BUG=None
NOTRY=True
Review-Url: https://codereview.webrtc.org/2598403002
Cr-Commit-Position: refs/heads/master@{#15843}
Before promoting it to the main waterfall I thought it made
sense to ensure it works for a phone that actually is 32-bit
(iPhone 6s isn't). It also makes more sense to run the older
iOS version (9) on the older phone.
BUG=chromium:677385
TBR=ehmaldonado@webrtc.org
Review-Url: https://codereview.webrtc.org/2604203002 .
Cr-Commit-Position: refs/heads/master@{#15837}
The P2PTransportChannel will eventually inherit from IceTransportInternal instead of TransportChannelImpl.
However, the Chromium/remoting depends on TransportChannel and TransportChannelImpl.
The solution to work around this:
Step1:
Make a WebRTC CL to introduce IceTransportInternal and IceTransportInternal2 by type-defining
TransportChannel and TransportChannelImpl.
Step2:
Make a Chromium CL to replace the TransportChannel and TransportChannelImpl with
IceTransportInternal and IceTransportInternal2.
Step3:
Make a WebRTC to redefine IceTransportInternal2 to be IceTransportInternal and switch the base
class of P2PTransportChannel with IceTransportInternal.
Step4"
Make a Chromium CL to remove the IceTransportInternal2.
This CL is the Step1. The real IceTransportInternal implementation
is commented out temporarily.
BUG=none
Review-Url: https://codereview.webrtc.org/2598103003
Cr-Commit-Position: refs/heads/master@{#15824}
