d69a726989
Make WebRTC use third_party/libevent rather than base/third_party/libevent
...
Bug: chromium:1335194
Change-Id: I084b391b42e2496163ea625c0bdc9255177e5603
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266680
Auto-Submit: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37375}
2022-06-30 07:43:49 +00:00
7a66900683
Delete rtc_base/atomic_ops.h
...
Bug: webrtc:9305
Change-Id: I3e8b0db03b84b5361d63db31ee23e6db3deabfe4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266497
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37348}
2022-06-28 08:32:13 +00:00
117e692a7d
tls: add logging of expected/received hashes on failures
...
BUG=None
Change-Id: I8e9a4e69c520e1ee1edeb7f45f039f2cda400a50
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265869
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37268}
2022-06-19 22:33:10 +00:00
ef9bcd17a5
Make webrtc units division by integer constexpr
...
std::round is not constexpr until c++23 and force conversion to floating point which is unnecessary for integer devision
For integer division change rounding to 'round down' from 'round to nearest' as less surprising.
Bug: webrtc:13756
Change-Id: I9c2382bafc9ddccb0f54d6e7bf8cac4f2a3175a1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265863
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37250}
2022-06-17 10:34:09 +00:00
c374d11fac
Move to_queued_task.h and pending_task_safety_flag.h into public API
...
Bug: b/235812579
Change-Id: I9fa3dc4a65044df8b44fff4e9bfeac7233fa381c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266080
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37248}
2022-06-17 09:20:39 +00:00
105711e9ad
Move rtc::make_ref_counted to api/
...
Bug: webrtc:12701
Change-Id: If49095b101c1a1763c2a44a0284c0d670cce953f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265390
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37219}
2022-06-15 09:47:38 +00:00
7ef4f514c5
[MessageHandler] Remove rtc::MessageHandler inheritance from StunRequest
...
This removes MessageHandler and Thread dependencies from StunRequest
and StunRequestManager. Instead the TaskQueueBase abstraction is
used for async posting and synchronous Clear() operations removed by
using a pending task safety flag.
Bug: webrtc:9702
Change-Id: I6e9ed5e1b4c446fd1f91af06e3ab36bccb5d7320
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265060
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37218}
2022-06-15 08:42:48 +00:00
bed8507b95
Delete almost unused utility rtc::Ref
...
Instead, use explicit declaration
scoped_ref_ptr<FinalRefCountedObject<Event>> in AsyncInvoker classes.
Bug: webrtc:12701
Change-Id: I7ce43e2dc99a51b610852b4feda79e4bf86ee4ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265803
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37210}
2022-06-14 13:44:37 +00:00
9a665402d7
Reland "TaskQueue: unexpose delayed task convenience methods."
...
This reverts commit 4cd3a0d082d0b9d44fd78eef3d53d4360e99a674.
Reason for revert: Downstream build should be fixed.
Original change's description:
> Revert "TaskQueue: unexpose delayed task convenience methods."
>
> This reverts commit 08bb6295ea1f438a26f8c1ab01769cfa63943756.
>
> Reason for revert: Breaks downstream tests
>
> Original change's description:
> > TaskQueue: unexpose delayed task convenience methods.
> >
> > Bug: webrtc:14165
> > Change-Id: Ieb8580670e9e521580afd68cca6ff631fb6df3f8
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265400
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Auto-Submit: Markus Handell <handellm@webrtc.org >
> > Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#37166}
>
> Bug: webrtc:14165
> Change-Id: Ia7368cf205622be448ec0ead5d22f211aa071a29
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265411
> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
> Owners-Override: Björn Terelius <terelius@webrtc.org >
> Auto-Submit: Björn Terelius <terelius@webrtc.org >
> Commit-Queue: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37167}
Bug: webrtc:14165
Change-Id: I3d963d272e8a1431103a5d5fb4568ccacd81119c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265395
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Markus Handell <handellm@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37186}
2022-06-13 07:27:37 +00:00
4cd3a0d082
Revert "TaskQueue: unexpose delayed task convenience methods."
...
This reverts commit 08bb6295ea1f438a26f8c1ab01769cfa63943756.
Reason for revert: Breaks downstream tests
Original change's description:
> TaskQueue: unexpose delayed task convenience methods.
>
> Bug: webrtc:14165
> Change-Id: Ieb8580670e9e521580afd68cca6ff631fb6df3f8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265400
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Auto-Submit: Markus Handell <handellm@webrtc.org >
> Commit-Queue: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37166}
Bug: webrtc:14165
Change-Id: Ia7368cf205622be448ec0ead5d22f211aa071a29
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265411
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Owners-Override: Björn Terelius <terelius@webrtc.org >
Auto-Submit: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37167}
2022-06-09 15:48:23 +00:00
08bb6295ea
TaskQueue: unexpose delayed task convenience methods.
...
Bug: webrtc:14165
Change-Id: Ieb8580670e9e521580afd68cca6ff631fb6df3f8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265400
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Auto-Submit: Markus Handell <handellm@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37166}
2022-06-09 14:08:54 +00:00
f1d822b03b
Delete variant of rtc::split that copies the output fields
...
Bug: webrtc:13579
Change-Id: I065a32704d48d5eed21aee0e9757cac9ecf7aa99
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261951
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Ali Tofigh <alito@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37160}
2022-06-09 08:29:33 +00:00
d197e0b876
Reland "Don't create PacketSocketFactory inside BasicPortAllocatorSession"
...
This is a reland of commit 7d4634cef76a1ac244d4b83faaf4c617bf236b71
Original change's description:
> Don't create PacketSocketFactory inside BasicPortAllocatorSession
>
> This extends AlwaysValidPointer to avoid creating a unique_ptr inside it.
>
> Bug: webrtc:13145
> Change-Id: I73a4f18d0a7037b57f575b04b134e4f7eadceb79
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263240
> Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37048}
Bug: webrtc:13145
Change-Id: Iec8091ada5862cb6aa48d45b2a426c05bda798f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264826
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Owners-Override: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37138}
2022-06-07 11:24:16 +00:00
45d66a59d6
Fix usage of sprintf.
...
sprintf is marked as deprecated with Xcode 14.
Bug: chromium:1331345
Change-Id: Ib7eb7ab829457f3ef5fcad44b43fe827359ad7d4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265200
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Auto-Submit: Justin Cohen <justincohen@google.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37136}
2022-06-07 07:14:06 +00:00
25361a89dd
Revert "Reland "Don't create PacketSocketFactory inside BasicPortAllocatorSession""
...
This reverts commit a8be79ce27f10a698bdb46e490c2bbcbb2300e52.
Reason for revert: Downstream projects were not fixed and I was to eager to reland this, sorry about this.
Original change's description:
> Reland "Don't create PacketSocketFactory inside BasicPortAllocatorSession"
>
> This is a reland of commit 7d4634cef76a1ac244d4b83faaf4c617bf236b71
>
> Original change's description:
> > Don't create PacketSocketFactory inside BasicPortAllocatorSession
> >
> > This extends AlwaysValidPointer to avoid creating a unique_ptr inside it.
> >
> > Bug: webrtc:13145
> > Change-Id: I73a4f18d0a7037b57f575b04b134e4f7eadceb79
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263240
> > Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
> > Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#37048}
>
> Bug: webrtc:13145
> Change-Id: I7d64c25b2942b392a1c35ff2fe1edc83d7b03746
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264503
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
> Commit-Queue: Christoffer Jansson <jansson@webrtc.org >
> Reviewed-by: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
> Cr-Commit-Position: refs/heads/main@{#37088}
Bug: webrtc:13145
Change-Id: Ie7990bae9a7c864ffaa4eb5b637618caad509633
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264823
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Christoffer Jansson <jansson@webrtc.org >
Owners-Override: Christoffer Jansson <jansson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37089}
2022-06-02 09:45:16 +00:00
a8be79ce27
Reland "Don't create PacketSocketFactory inside BasicPortAllocatorSession"
...
This is a reland of commit 7d4634cef76a1ac244d4b83faaf4c617bf236b71
Original change's description:
> Don't create PacketSocketFactory inside BasicPortAllocatorSession
>
> This extends AlwaysValidPointer to avoid creating a unique_ptr inside it.
>
> Bug: webrtc:13145
> Change-Id: I73a4f18d0a7037b57f575b04b134e4f7eadceb79
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263240
> Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37048}
Bug: webrtc:13145
Change-Id: I7d64c25b2942b392a1c35ff2fe1edc83d7b03746
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264503
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Christoffer Jansson <jansson@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@webrtc.org >
Reviewed-by: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
Cr-Commit-Position: refs/heads/main@{#37088}
2022-06-02 09:31:06 +00:00
61dbcd115a
Rewrite "Reset all maps in AndroidNetworkMonitor Start()/Stop()"
...
This reverts commit 8cd7b0a7babf3f58f6beab70fcabeb75e66c1bed.
The assumption in AndroidNetworkMonitor that an interface name
is unique has turned out to be incorrect :( for some (weird) devices,
i.e ccmni0.
It is unclear if it is a permanent setup or a transient state.
This cl/ changes the impl. to cope with that, the last
OnNetworkConnected_n "owns" the interface name, and when
OnNetworkDisconnected_n runs, we check if we're "owner"
and maybe set a new "owner" (if we're not "owner" we do nothing).
New testcases added.
I also
1) change NetworkMonitorInterface to return a struct
with all the information that is requested with interface name
as key.
2) Change Network.cc adding (debug) assertions that network
properties can't change inside a loop (in one thread).
Original change's description:
> Revert "Reset all maps in AndroidNetworkMonitor Start()/Stop()"
>
> This reverts commit 02293096f9689fee3d32defa77dca227cc1eee90.
>
> Reason for revert: mysterious crashes in android_network_monitor.cc
>
> Original change's description:
> > Reset all maps in AndroidNetworkMonitor Start()/Stop()
> >
> > This cl/ fixes another race condition with the recent additions
> > to NetworkMonitorAutoDetect (getAllNetworksFromCache).
> >
> > The getAllNetworksFromCache-feature uses the by the Android team
> > preferred way of enumerating networks, i.e to register network listeners.
> >
> > Th recent fix to add IsAdapterAvailable, https://webrtc-review.googlesource.com/c/src/+/257400
> > contained a bug in that the adapter_type_by_name_ map was not
> > reset either on disconnect or Start/Stop.
> >
> > This cl/ addresses that including unit test.
> > It also de-obfuscates NetworkMonitor so that it always
> > calls NotifyOfActiveNetworkList on startMonitoring even
> > if list.size() == 0. This should not matter but makes
> > code easier to understand.
> >
> > Bug: webrtc:13741
> > Change-Id: I438b877eebf769a8b2e7292b697ef1c0a349b24f
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258721
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> > Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
> > Cr-Commit-Position: refs/heads/main@{#36530}
>
> Bug: webrtc:13741
> Change-Id: I36fbf63f658d3e8048e13959cbebfbd14df12b14
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264146
> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
> Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37016}
Bug: webrtc:13741
Change-Id: Ib4eb072b775e493b564528f0be94c685b70ec20f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264421
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Jonas Oreland <jonaso@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37056}
2022-05-31 10:49:55 +00:00
6b9e040ab2
Revert "Don't create PacketSocketFactory inside BasicPortAllocatorSession"
...
This reverts commit 7d4634cef76a1ac244d4b83faaf4c617bf236b71.
Reason for revert: Breaks downstream project.
Original change's description:
> Don't create PacketSocketFactory inside BasicPortAllocatorSession
>
> This extends AlwaysValidPointer to avoid creating a unique_ptr inside it.
>
> Bug: webrtc:13145
> Change-Id: I73a4f18d0a7037b57f575b04b134e4f7eadceb79
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263240
> Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#37048}
Bug: webrtc:13145
Change-Id: Iacddd280f9f27b703f2a03ee568722aed8d3abc1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264463
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Owners-Override: Christoffer Jansson <jansson@webrtc.org >
Commit-Queue: Christoffer Jansson <jansson@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37053}
2022-05-31 09:22:24 +00:00
7d4634cef7
Don't create PacketSocketFactory inside BasicPortAllocatorSession
...
This extends AlwaysValidPointer to avoid creating a unique_ptr inside it.
Bug: webrtc:13145
Change-Id: I73a4f18d0a7037b57f575b04b134e4f7eadceb79
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/263240
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37048}
2022-05-31 00:58:04 +00:00
e66b83f8ad
Never pass a signed char to ctype macros like isdigit()
...
Bug: None
Change-Id: I451bb2c1f175a77aefbc8363009bf35a769fe941
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264442
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37037}
2022-05-30 13:05:03 +00:00
8712d0b150
Include all trace categories for internal usage
...
This CL adds a parameter to include `TRACE_DISABLED_BY_DEFAULT`
categories for internal usage. Tentatively set it by default.
Bug: webrtc:14080
Change-Id: I62a1a437b8d144b86bc5017e20e2f35e042ad2cd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260664
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36966}
2022-05-23 09:10:36 +00:00
83830f316e
Delete TestListener and top-level thread wrapping.
...
Instead use rtc::AutoThread in tests that need that.
Bug: webrtc:9714
Change-Id: I1f33b1b2d321770d062504dd9ef86d66a345dd42
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/254681
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36950}
2022-05-20 15:21:21 +00:00
9aa46c6572
Delete rtc::join
...
Define a local function in the only place where it is used, for calling
SSL_set1_curves_list.
Bug: webrtc:6424
Change-Id: I7b9c372aaed15dbc88ced55652f5afd93db55e49
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261313
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36853}
2022-05-11 14:37:04 +00:00
e00d7d0ce6
Adopt absl::string_view in CopyOnWriteBuffer
...
Bug: webrtc:13579
Change-Id: Ia2b99a28ed0c103215e8616da67a5c961b957199
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260465
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Ali Tofigh <alito@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36832}
2022-05-10 10:32:41 +00:00
adaf511221
Extend UnitBase multiplication to support size_t
...
Bug: None
Change-Id: I8dcb85cdb2819df54d4cb0cae59b77d7d629123a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260941
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36828}
2022-05-10 07:41:30 +00:00
ea1e6f44f8
Delete rtc_base/format_macros.h
...
It defined RTC_PRIuS, which was needed for compatibility with MSVC
prior to version 2015.
Bug: webrtc:6424
Change-Id: I5668d473376201cad3e8da65927c967fc397804b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261314
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36814}
2022-05-09 12:03:21 +00:00
624340b32f
Add test for StringFormat and string_view
...
Bug: none
Change-Id: Ibc366dc30f0fc8ef098e66b8ffd982c0046db6d2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261449
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36805}
2022-05-08 09:13:53 +00:00
662d7f11d5
Fixes to support building in -std=c++20 mode.
...
* Structs with user-declared constructors are no longer considered
aggregates, so remove the declarations when possible
* Types of both arguments to "==" must match to avoid "ambiguous
function call" warning
* Various types of math involving enums are deprecated, so replace with
constexprs where necessary
* ABSL_CONST_INIT must be used on definition as well as declaration
* volatile memory may no longer be read from and written to by the same
operator, so replace e.g. "n++" with "n = n + 1"
* Replace an outdated check for no_unique_address support with
__has_cpp_attribute
* std::result_of(f(x)) has been removed, replace with
std::invoke_result(f, x)
Bug: chromium:1284275
Change-Id: I77b366ab1da7eb2c1e4c825b2714417c31ee5903
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261221
Auto-Submit: Peter Kasting <pkasting@chromium.org >
Reviewed-by: Tomas Gunnarsson <tommi@google.com >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36786}
2022-05-05 17:15:58 +00:00
26d12fcc71
Remove rtc_base:rtc_base_approved
...
It's now empty, let's remove it!
Bug: webrtc:9838
Change-Id: I4b3310e882ea95fdf47903f9ad31e2efb35703f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261242
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36774}
2022-05-05 09:43:31 +00:00
15a3c3fdca
Split Windows code from rtc_base_approved to smaller targets
...
Bug: webrtc:9838
Change-Id: Ic463284fd68715fd9b8eadd50e1d25841cb60020
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261241
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36768}
2022-05-05 06:47:49 +00:00
00579e8bce
Use AlwaysValidPointer in connection_context
...
This extends AlwaysValidPointer to take a lambda for its default
rather than requesting a constructor.
Bug: none
Change-Id: Ied97968c3f511af15422a1eef9801d14d4ec5b96
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260580
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36745}
2022-05-03 13:39:06 +00:00
3a9e6877e5
Cleanup rtc_base_approved target
...
Removed all unused or transitional parts
Bug: webrtc:9838
Change-Id: I6bc14e4e0ac09ab27e4d739ac76bb6a4dfff2cb7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260140
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36741}
2022-05-03 06:58:27 +00:00
8fcc79b3d5
Add missing overload of LogSink::OnLogMessage()
...
Bug: webrtc:13579
Change-Id: If2ddff90f404361745257b0bed0951d9de0f08bf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260470
Commit-Queue: Ali Tofigh <alito@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36723}
2022-05-02 08:15:05 +00:00
13f9c62ec8
Fix comparator bugs which are not compliant to strict weak ordering.
...
See a full explanation of the problem on this blog [1] post about changing
std::sort in LLVM and relative issues uncovered.
The CompareNetwork function was violating the 4th rule of "strict weak
ordering" (Transitivity of incomparability: x == y and y == z imply x == z, where x == y means x < y and y < x are both false).
[1] - https://danlark.org/2022/04/20/changing-stdsort-at-googles-scale-and-beyond/
Bug: None
Change-Id: I7e893f0a30da31403766284823f75c45c4db91c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251681
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Niels Moller <nisse@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36711}
2022-04-29 16:00:53 +00:00
d3890781be
Adopt absl::string_view in some fakes under rtc_base/
...
Bug: webrtc:13579
Change-Id: I52462a0edb4fb309cea3bc27f60dc81c5ea50522
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260464
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Ali Tofigh <alito@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36710}
2022-04-29 15:33:12 +00:00
6228d870dc
Reland "Delete deprecated versions of MergeNetworkList"
...
This is a reland of commit 7679e9bf071250e8e98ef6ef58962ddcc73cd498
Breakage in chrome/services/sharing/ (not built as part of webrtc
presubmit) should be fixed with
https://chromium-review.googlesource.com/c/chromium/src/+/3604642
Original change's description:
> Delete deprecated versions of MergeNetworkList
>
> Bug: webrtc:13869
> Change-Id: I6b888ba14ca664a1f28de2fb59b7d1343cb18bd8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259300
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36611}
Bug: webrtc:13869
Change-Id: I4cf0fe0f2310eabb2d0b32c6dec5f8aef64c7712
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259869
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36704}
2022-04-29 11:19:02 +00:00
9c83d9d99e
DTLS: fail the connection if DTLSv1_handle_timeout returns an error
...
which signals a permanent connection failure to the application
BUG=webrtc:13999
Change-Id: I7ba25db4aa9035583558a613db97561c48796c76
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260100
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/main@{#36700}
2022-04-29 05:44:42 +00:00
9432768024
Prepare for deletion of implicit conversion from rtc::scoped_refptr<T> to T*
...
Bug: webrtc:13464
Change-Id: I4c7095d3a1c7c1a9ab609f5f1595545f6cad18db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249087
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36693}
2022-04-28 12:58:56 +00:00
76d9c18c3a
Minor tweaks to the stdlib TQ implementation.
...
Remove the `started_` member variable and some other minor updates to
follow conventions elsewhere in the code.
Bug: none
Change-Id: I4cbb914b39cb2e2787719b906ca937931dc3dad7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/258360
Reviewed-by: Markus Handell <handellm@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36677}
2022-04-27 22:42:16 +00:00
df0cbf589f
Make rtc_base_approved a rtc_source_set
...
A target with only header files should be a source_set.
Bug: webrtc:9838, chromium:1319559
Change-Id: Ic60ed3ac074c36bee0a16831cd463053a7d81efe
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260043
Auto-Submit: Florent Castelli <orphis@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36649}
2022-04-26 06:17:29 +00:00
7765f9e3df
Fix logging MakeVal template
...
Types with ToLogString implemented were not being recognized correctly.
Now types like TimeDelta and Timestamp can be logged as normal.
Change-Id: Ia15f90bdd1d63a39f7452f9b4bba178d01b74352
Bug: webrtc:13995
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259863
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36646}
2022-04-25 16:01:40 +00:00
a30aef3dea
Move event_tracer out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: Ic3c424729b5edd3e378c4195afe33ae5c88ad491
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259312
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36637}
2022-04-24 14:47:40 +00:00
ed4aadc0a2
Move copy_on_write_buffer out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: Ib9a9cd3bc868e716315594c436df7e2cce0d9a5a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259311
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36636}
2022-04-24 09:51:50 +00:00
ceb7b36d3a
Move byte_buffer out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: Ic7e912cba1218f1eed794cb8c393ac148106b16c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259310
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36634}
2022-04-23 22:47:39 +00:00
a876a92d31
Move byte_order out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: Ieb2fbaad8831439ca04fc5249e295c8839f6890e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259309
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36633}
2022-04-23 19:04:29 +00:00
7606375b1a
Move buffer_queue out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: I472223685b15c46cd351fd6d9ddec837d898a0db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259308
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36632}
2022-04-23 17:31:09 +00:00
f9c5984a1d
Move buffer out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: I14feff7b1f0182d031b6644d281be44122820ce7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259307
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36629}
2022-04-22 21:19:28 +00:00
6bb1fd358b
Move rate_statistics out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: Ia5a45291a403097c0527d50ced85c3881653fa37
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259306
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36627}
2022-04-22 15:39:48 +00:00
58cc468d16
Move rate_tracker out of rtc_base_approved
...
Bug: webrtc:9838
Change-Id: If7dea8bf6ef3344286ac16b57290e557cf866f92
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259305
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Florent Castelli <orphis@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36622}
2022-04-22 13:30:19 +00:00
2f9291c7fb
Revert "Delete deprecated versions of MergeNetworkList"
...
This reverts commit 7679e9bf071250e8e98ef6ef58962ddcc73cd498.
Reason for revert: Breaks chromium roll (see https://ci.chromium.org/ui/p/chromium/builders/try/linux-chromeos-compile-dbg/998457/overview )
Original change's description:
> Delete deprecated versions of MergeNetworkList
>
> Bug: webrtc:13869
> Change-Id: I6b888ba14ca664a1f28de2fb59b7d1343cb18bd8
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259300
> Reviewed-by: Harald Alvestrand <hta@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/main@{#36611}
Bug: webrtc:13869
Change-Id: I781ac1980687367ee17d033f6613c2e487b7966f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259775
Auto-Submit: Ilya Nikolaevskiy <ilnik@webrtc.org >
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#36621}
2022-04-22 13:24:29 +00:00
