zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
11,877 Commits 1 Branch 0 Tags
e76db89e0b3974af8dcba62d34b51e04a64d98e9
Commit Graph

11877 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Tommi
2067826a5e Remove dependency on ConditionVariableWrapper and CriticalSectionWrapper in UdpSocketPosix. 
This is a part of cleaning up 'friend' parts of ConditionVariableWrapper's implementation where it accesses private variables of CriticalSectionWrapper, which is not good since it makes assumptions about the implementation on all posix platforms.
Instead I'm using rtc::Event, another condition variable based implementation we have, and fits the requirements of UdpSocketPosix.

BUG=
R=pbos@webrtc.org

Review URL: https://codereview.webrtc.org/1591333002 .

Cr-Commit-Position: refs/heads/master@{#11295}
 2016-01-18 19:35:49 +00:00
Peter Boström
233bfd2da4 Move keyframe requests outside encoder mutex. 
Enables faster keyframe requests since they are no longer blocked by
calls to the encoder.

BUG=webrtc:5410
R=stefan@webrtc.org

Review URL: https://codereview.webrtc.org/1600553003 .

Cr-Commit-Position: refs/heads/master@{#11294}
 2016-01-18 19:23:51 +00:00
kjellander
49c740264c Roll chromium_revision ad2f344..7a4fb8d (370010:370025) 
Change log: ad2f344..7a4fb8d
Full diff: ad2f344..7a4fb8d

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1609443002

Cr-Commit-Position: refs/heads/master@{#11293}
 2016-01-18 19:05:34 +00:00
tommi
aff4b70db0 Simplify the implementation of LoggingTest. 
This removes dependency on ConditionVariableWrapper and CriticalSectionWrapper which currently have a 'friend' relationship that I'd like to get rid of.

BUG=

Review URL: https://codereview.webrtc.org/1590983005

Cr-Commit-Position: refs/heads/master@{#11292}
 2016-01-18 18:20:21 +00:00
kwiberg
f8c2baca4e Add a gyp/gn variable for whether to use iLBC or not 
BUG=webrtc:5415

Review URL: https://codereview.webrtc.org/1578953003

Cr-Commit-Position: refs/heads/master@{#11291}
 2016-01-18 14:38:40 +00:00
Niels Möller
f5a3a93d26 Add 5-argument wrapper WebRtcVideoFrame::InitToBlack 
For some reason, inheriting it doesn't work.

BUG=webrtc:5426
R=perkj@webrtc.org

Review URL: https://codereview.webrtc.org/1602543003 .

Cr-Commit-Position: refs/heads/master@{#11290}
 2016-01-18 14:24:54 +00:00
kjellander
d1420673e3 Roll chromium_revision 1c9621e..ad2f344 (369979:370010) 
Change log: 1c9621e..ad2f344
Full diff: 1c9621e..ad2f344

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1603563002

Cr-Commit-Position: refs/heads/master@{#11289}
 2016-01-18 14:03:32 +00:00
danilchap
34ed2b95a5 [rtp_rtcp] rtcp::SenderReport moved into own file and got Parse function 
BUG=webrtc:5260
R=åsapersson

Review URL: https://codereview.webrtc.org/1544983002

Cr-Commit-Position: refs/heads/master@{#11288}
 2016-01-18 10:43:38 +00:00
nisse
8b1e431231 Delete remnants of non-square pixel support from cricket::VideoFrame. 
If ever needed, add some aspect ratio parameter, without pixel_width
and pixel_height arguments cluttering commonly used functions.

BUG=webrtc:5426

Committed: https://crrev.com/709513d4133107d5c02aed34a5ee99444c4d4e25
Cr-Commit-Position: refs/heads/master@{#11243}

Review URL: https://codereview.webrtc.org/1586613002

Cr-Commit-Position: refs/heads/master@{#11287}
 2016-01-18 09:46:33 +00:00
kjellander
33c1dca48b Roll chromium_revision 89ca041..1c9621e (369966:369979) 
Change log: 89ca041..1c9621e
Full diff: 89ca041..1c9621e

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1593233008

Cr-Commit-Position: refs/heads/master@{#11286}
 2016-01-18 04:01:48 +00:00
kjellander
9d2a3c51d9 Roll chromium_revision 4b805fe..89ca041 (369965:369966) 
Change log: 4b805fe..89ca041
Full diff: 4b805fe..89ca041

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1599063003

Cr-Commit-Position: refs/heads/master@{#11285}
 2016-01-17 20:00:42 +00:00
kjellander
e110e5c09b Roll chromium_revision 6058a7b..4b805fe (369961:369965) 
Change log: 6058a7b..4b805fe
Full diff: 6058a7b..4b805fe

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1596933003

Cr-Commit-Position: refs/heads/master@{#11284}
 2016-01-17 12:03:25 +00:00
kjellander
d7db862622 Roll chromium_revision 9e8fb7a..6058a7b (369957:369961) 
Change log: 9e8fb7a..6058a7b
Full diff: 9e8fb7a..6058a7b

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1591273005

Cr-Commit-Position: refs/heads/master@{#11283}
 2016-01-17 04:33:42 +00:00
kjellander
c1cf0d3ba7 Roll chromium_revision 0a79aa1..9e8fb7a (369950:369957) 
Change log: 0a79aa1..9e8fb7a
Full diff: 0a79aa1..9e8fb7a

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1584293006

Cr-Commit-Position: refs/heads/master@{#11282}
 2016-01-16 21:21:41 +00:00
kjellander
011df0acd2 Roll chromium_revision 553c2cb..0a79aa1 (369932:369950) 
Change log: 553c2cb..0a79aa1
Full diff: 553c2cb..0a79aa1

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1584283009

Cr-Commit-Position: refs/heads/master@{#11281}
 2016-01-16 12:02:43 +00:00
kjellander
f624a22c86 Roll chromium_revision 46fd746..553c2cb (369797:369932) 
Change log: 46fd746..553c2cb
Full diff: 46fd746..553c2cb

Changed dependencies:
* src/third_party/ffmpeg: a41fa51..d1e9c4b
DEPS diff: 46fd746..553c2cb/DEPS

No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1591993002

Cr-Commit-Position: refs/heads/master@{#11280}
 2016-01-16 04:04:13 +00:00
honghaiz
cec0a08275 Add a new interface for creating a udp socket in which it binds the socket to a network if the network handle is set. 
Plus, in stunport, turnport and allocation sequence, create a socket using the new interface.

BUG=

Review URL: https://codereview.webrtc.org/1556743002

Cr-Commit-Position: refs/heads/master@{#11279}
 2016-01-15 22:49:15 +00:00
guoweis
56271ed889 fix bug 5430 
Fixed misusage of Connection function and also fixed the test case.

BUG=webrtc:5430

Review URL: https://codereview.webrtc.org/1592763003

Cr-Commit-Position: refs/heads/master@{#11278}
 2016-01-15 22:45:11 +00:00
glaznev
f4decb5469 Add QP statistics logging to Android HW encoder. 
- Similar to HW decoder log timing for first 5 frames
of HW encoder input and output to track correct encoder
start.
- Increment input timestamp when frame is dropped.
- Better calculate average encoding time.
- Use different tags for encoder and decoder modules.

BUG=b/26504665

Review URL: https://codereview.webrtc.org/1587943004

Cr-Commit-Position: refs/heads/master@{#11277}
 2016-01-15 21:49:26 +00:00
kjellander
305ca25a67 Roll chromium_revision ff895e2..46fd746 (369726:369797) 
Change log: ff895e2..46fd746
Full diff: ff895e2..46fd746

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1591803002

Cr-Commit-Position: refs/heads/master@{#11276}
 2016-01-15 20:03:06 +00:00
deadbeef
884f58523a Storing raw audio sink for default audio track. 
BUG=webrtc:5250

Committed: https://crrev.com/e591f9377f33f3f725a30faecd1bef1a71fa6b99
Cr-Commit-Position: refs/heads/master@{#11230}

Review URL: https://codereview.webrtc.org/1551813002

Cr-Commit-Position: refs/heads/master@{#11275}
 2016-01-15 17:20:08 +00:00
Danil Chapovalov
1567d0bd98 [rtp_rtcp] rtcp::Sdes moved into own file 
Cleaning/Parsing will be done in the https://codereview.webrtc.org/1439553003/

BUG=webrtc:5260
R=asapersson@webrtc.org, åsapersson

Review URL: https://codereview.webrtc.org/1592763002 .

Cr-Commit-Position: refs/heads/master@{#11274}
 2016-01-15 16:34:32 +00:00
torbjorng
79a5a83e10 Adapt to boringssl's new defaults. 
This is now a merge with patchset #2 of https://codereview.webrtc.org/1550773002 after that CL was reverted.

BUG=webrtc:5381

Review URL: https://codereview.webrtc.org/1589493004

Cr-Commit-Position: refs/heads/master@{#11273}
 2016-01-15 15:16:54 +00:00
Danil Chapovalov
2c13297bf5 [rtp_rtcp] rtcp::Rpsi moved into own file 
Cleaning/Parsing will be done in the https://codereview.webrtc.org/1550293003/

BUG=webrtc:5260
R=asapersson@webrtc.org, åsapersson

Review URL: https://codereview.webrtc.org/1583233007 .

Cr-Commit-Position: refs/heads/master@{#11272}
 2016-01-15 14:21:34 +00:00
Danil Chapovalov
256e5b23f8 Cleaning/Parsing will be done in the https://codereview.webrtc.org/1557593002/ 
BUG=webrtc:5260
R=asapersson@webrtc.org, åsapersson

Review URL: https://codereview.webrtc.org/1579213005 .

Cr-Commit-Position: refs/heads/master@{#11271}
 2016-01-15 13:16:36 +00:00
kjellander
a132197f10 Roll chromium_revision 6e188de..ff895e2 (369712:369726) 
Change log: 6e188de..ff895e2
Full diff: 6e188de..ff895e2

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1589013005

Cr-Commit-Position: refs/heads/master@{#11270}
 2016-01-15 12:38:28 +00:00
Danil Chapovalov
5679da1291 [rtp_rtcp] rtcp::Fir moved into own file 
Cleaning/Parsing will be done in the https://codereview.webrtc.org/1544403002

BUG=webrtc:5260
R=asapersson@webrtc.org, åsapersson

Review URL: https://codereview.webrtc.org/1581983003 .

Cr-Commit-Position: refs/heads/master@{#11269}
 2016-01-15 12:19:59 +00:00
Danil Chapovalov
a5eba6c98b [rtp_rtcp] rtcp::Remb moved into own file 
Cleaning/Parsing will be done in the https://codereview.webrtc.org/1552773002/

BUG=webrtc:5260
R=asapersson@webrtc.org, åsapersson

Review URL: https://codereview.webrtc.org/1590883002 .

Cr-Commit-Position: refs/heads/master@{#11268}
 2016-01-15 11:40:27 +00:00
ivoc
d66b44d565 Reland "Added option to specify a maximum file size when recording an AEC dump.", commit ae2c5ad12afc8cc29fe9c59dea432b697b871a87. 
The revert of the original CL was commit 36d4c545007129446e551c45c17b25377dce89a4.
Original review: https://codereview.webrtc.org/1413483003/

The original CL changes a function on audio_processing.h that is used by Chrome, this CL adds back the old function.

TBR=glaznev@webrtc.org, henrik.lundin@webrtc.org, solenberg@google.com, henrikg@webrtc.org, perkj@webrtc.org
BUG=webrtc:4741
Committed: https://crrev.com/f4f5cb09277d5ef6aeac8341e5f54a055867803a
Cr-Commit-Position: refs/heads/master@{#11093}

Review URL: https://codereview.webrtc.org/1540103002

Cr-Commit-Position: refs/heads/master@{#11267}
 2016-01-15 11:06:41 +00:00
kjellander
74e8df81ae Roll chromium_revision 9946592..6e188de (369667:369712) 
Change log: 9946592..6e188de
Full diff: 9946592..6e188de

No dependencies changed.
No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1584953005

Cr-Commit-Position: refs/heads/master@{#11266}
 2016-01-15 10:34:57 +00:00
solenberg
0f7d2939e0 Revert changes to default option setting in https://codereview.webrtc.org/1500633002/ 
As found by aluebs@, the changes breaks ability to create AecDumps: https://codereview.webrtc.org/1530333007/

BUG=webrtc:4690

Review URL: https://codereview.webrtc.org/1568853002

Cr-Commit-Position: refs/heads/master@{#11265}
 2016-01-15 09:40:45 +00:00
hbos
5602f65659 setup_links.py fix so that FFmpeg compiles on windows. 
Fix creates a symlink tools/generate_stubs -> chromium/src/tools/generate_stubs which is used by ffmpeg on windows.

BUG=468365
NOTRY=True

Review URL: https://codereview.webrtc.org/1586083003

Cr-Commit-Position: refs/heads/master@{#11264}
 2016-01-15 09:38:39 +00:00
kjellander
6a59ad3ab5 Revert of Remove libfuzzer trybot from default trybot set. (patchset #1 id:1 of https://codereview.webrtc.org/1585963002/ ) 
Reason for revert:
This was resolved by the roll in https://codereview.webrtc.org/1573243017/. See https://code.google.com/p/chromium/issues/detail?id=577566 for details.

Original issue's description:
> Remove libfuzzer trybot from default trybot set.
>
> BUG=chromium:577566
> TBR=pbos@webrtc.org
> NOTRY=True
>
> Committed: https://crrev.com/35aae2e5cab191f820ad6757b1092e22a43e426b
> Cr-Commit-Position: refs/heads/master@{#11245}

TBR=pbos@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:577566

Review URL: https://codereview.webrtc.org/1587043007

Cr-Commit-Position: refs/heads/master@{#11263}
 2016-01-15 08:28:48 +00:00
kjellander
301830f79b Roll chromium_revision 099be58..9946592 (369139:369667) 
Change log: 099be58..9946592
Full diff: 099be58..9946592

Changed dependencies:
* src/tools/gyp: b85ad3e..54b7dfc
DEPS diff: 099be58..9946592/DEPS

No update to Clang.

TBR=

Review URL: https://codereview.webrtc.org/1573243017

Cr-Commit-Position: refs/heads/master@{#11262}
 2016-01-15 04:18:29 +00:00
Sergey Ulanov
dc305db059 Add ApplyPacketOptions() 
When libjingle is compied with ENABLE_EXTERNAL_AUTH the sending socket
needs to update RTP header in order for the outgoing packet to be
valid. The corresponding code was in chromium in
content/browser/renderer_host/p2p/socket_host.cc and it was impossible
to reuse it anywhere else. This CL moves this code to
talk/media/base/rtputils.h/cc, so it can be used outside of chrome.

BUG=crbug.com/547158
R=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1578323002 .

Cr-Commit-Position: refs/heads/master@{#11261}
 2016-01-15 01:15:05 +00:00
Honghai Zhang
20ac434010 Fix a test bot failure. 
That was caused by https://codereview.webrtc.org/1581903002/

BUG=
R=pthatcher@google.com
TBR=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1587373002 .

Cr-Commit-Position: refs/heads/master@{#11260}
 2016-01-14 23:56:35 +00:00
deadbeef
e1f9d837ae Adding AddTrack/RemoveTrack to native PeerConnection API. 
Also, now creating the RtpSender/RtpReceiver proxy objects immediately,
rather than waiting until when GetSenders/GetReceivers is called.

Review URL: https://codereview.webrtc.org/1563403002

Cr-Commit-Position: refs/heads/master@{#11259}
 2016-01-14 23:35:46 +00:00
danilchap
d9e62f5837 Fixed sending Rtp packets with non zero csrcs and certain extensions. 
Added test that fails because of given issue.

BUG=webrtc:5413
R=stefan@webrtc.org

Review URL: https://codereview.webrtc.org/1586523003

Cr-Commit-Position: refs/heads/master@{#11258}
 2016-01-14 22:55:23 +00:00
honghaiz
67b1e1ab0b Put options as the argument of the java PeerConnectionFactory constructor. 
BUG=

Review URL: https://codereview.webrtc.org/1581903002

Cr-Commit-Position: refs/heads/master@{#11257}
 2016-01-14 22:45:44 +00:00
terelius
5d332ac8ff Fix expectation bug in the RTPSender unit test. 
The current expectation for InsertPacket(...) uses WillRepeatedly, which accepts if the function is called zero or more times. This CL changes this to either a fixed number of calls, or at least a positive number of calls.

Review URL: https://codereview.webrtc.org/1585783003

Cr-Commit-Position: refs/heads/master@{#11256}
 2016-01-14 22:37:43 +00:00
Stefan Holmer
04cb763955 Add tests for verifying transport feedback for audio and video. 
BUG=webrtc:5263
R=mflodman@webrtc.org

Review URL: https://codereview.webrtc.org/1589523002 .

Cr-Commit-Position: refs/heads/master@{#11255}
 2016-01-14 19:34:39 +00:00
kjellander
fcfc804e43 Eliminate defines in talk/ 
Replace LINUX, OSX and IOS defines with WEBRTC_ prefixed versions.
Remove no longer used defines from talk/build/common.gypi due to
previously migrated sources (into webrtc/p2p and webrtc/libjingle).

When this is rolled into Chromium, we can also clean up the platform
defines in
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/libjingle.gyp

NOTRY=True
BUG=webrtc:5420
TESTED=Ran all compile trybots with --clobber flag.
TBR=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1588453005

Cr-Commit-Position: refs/heads/master@{#11254}
 2016-01-14 19:01:25 +00:00
sprang
3542013f58 Revert of Update with new default boringssl no-aes cipher suites. Re-enable tests. (patchset #3 id:40001 of https://codereview.webrtc.org/1550773002/ ) 
Reason for revert:
We're getting boringssl version conflicts. Reverting for now.

Original issue's description:
> Update with new default boringssl no-aes cipher suites. Re-enable tests.
>
> This undoes https://codereview.webrtc.org/1533253002 (except the DEPS part).
>
> BUG=webrtc:5381
> R=davidben@webrtc.org, henrika@webrtc.org
>
> Committed: https://crrev.com/31c8d2eac5aec977f584ab0ae5a1d457d674f101
> Cr-Commit-Position: refs/heads/master@{#11250}

TBR=davidben@webrtc.org,henrika@webrtc.org,torbjorng@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5381

Review URL: https://codereview.webrtc.org/1586183002

Cr-Commit-Position: refs/heads/master@{#11253}
 2016-01-14 17:14:06 +00:00
Stefan Holmer
2734d77c95 Remove assert which was incorrectly added to TcpPort::OnSentPacket. 
TBR=pthatcher@webrtc.org

BUG=webrtc:4173

Review URL: https://codereview.webrtc.org/1588083002 .

Cr-Commit-Position: refs/heads/master@{#11252}
 2016-01-14 16:04:04 +00:00
Stefan Holmer
55674ffb32 Reland Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket. 
Chromium reported errors when building libjingle_nacl due to some methods used virtual instead of override when they were overriding the base class. My guess is that when one method starts using override, all other in the same class must too.

R=tommi@webrtc.org
TBR=pthatcher@webtrc.org

BUG=4173

Review URL: https://codereview.webrtc.org/1589563003 .

Cr-Commit-Position: refs/heads/master@{#11251}
 2016-01-14 14:49:23 +00:00
Torbjorn Granlund
31c8d2eac5 Update with new default boringssl no-aes cipher suites. Re-enable tests. 
This undoes https://codereview.webrtc.org/1533253002 (except the DEPS part).

BUG=webrtc:5381
R=davidben@webrtc.org, henrika@webrtc.org

Review URL: https://codereview.webrtc.org/1550773002 .

Cr-Commit-Position: refs/heads/master@{#11250}
 2016-01-14 14:18:02 +00:00
tommi
e5e0e57bdf Revert of Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket. (patchset #3 id:40001 of https://codereview.webrtc.org/1577873003/ ) 
Reason for revert:
Broke Chrome:

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/143025/steps/compile%20%28with%20patch%29/logs/stdio

FAILED: cd ../../third_party/libjingle; python ../../native_client/build/build_nexe.py --root ../.. --product-dir ../../out/Debug/xyz --config-name Debug -t ../../native_client/toolchain/ --arch pnacl --build newlib_plib --name ../../out/Debug/gen/tc_pnacl_newlib/lib/libjingle_nacl.a --objdir ../../out/Debug/obj/third_party/libjingle/libjingle_nacl.gen/pnacl_newlib-pnacl/libjingle_nacl "--include-dirs=../../out/Debug/gen/tc_pnacl_newlib/include ../.. \"../../out/Debug/gen\" ./source ../ ../../native_client_sdk/src/libraries ../../native_client_sdk/src/libraries/nacl_io/include ../../native_client_sdk/src/libraries/third_party/newlib-extras ../expat/files/lib ../boringssl/src/include" "--compile_flags=-O2 -g -Wall -fdiagnostics-show-option -Werror  -Wno-unused-function -Wno-char-subscripts -Wno-c++11-extensions -Wno-unnamed-type-template-args -Wno-extra-semi -Wno-unused-private-field -Wno-char-subscripts -Wno-unused-function \"-std=gnu++11\" " --gomadir /b/build/goma "--defines=\"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\" \"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\" \"NACL_BUILD_ARCH=x86\" V8_DEPRECATION_WARNINGS \"CLD_VERSION=2\" \"_FILE_OFFSET_BITS=64\" CHROMIUM_BUILD \"CR_CLANG_REVISION=255169-1\" COMPONENT_BUILD UI_COMPOSITOR_IMAGE_TRANSPORT \"USE_AURA=1\" \"USE_ASH=1\" \"USE_PANGO=1\" \"USE_CAIRO=1\" \"USE_DEFAULT_RENDER_THEME=1\" \"USE_LIBJPEG_TURBO=1\" \"USE_X11=1\" \"IMAGE_LOADER_EXTENSION=1\" \"ENABLE_WEBRTC=1\" \"ENABLE_MEDIA_ROUTER=1\" USE_PROPRIETARY_CODECS ENABLE_PEPPER_CDMS ENABLE_CONFIGURATION_POLICY ENABLE_NOTIFICATIONS \"ENABLE_HIDPI=1\" \"ENABLE_TOPCHROME_MD=1\" USE_UDEV DONT_EMBED_BUILD_METADATA \"DCHECK_ALWAYS_ON=1\" FIELDTRIAL_TESTING_ENABLED \"ENABLE_TASK_MANAGER=1\" \"ENABLE_EXTENSIONS=1\" \"ENABLE_PDF=1\" \"ENABLE_PLUGINS=1\" \"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" \"ENABLE_AUTOFILL_DIALOG=1\" \"ENABLE_BACKGROUND=1\" \"ENABLE_PRINTING=1\" \"ENABLE_PRINT_PREVIEW=1\" \"ENABLE_SPELLCHECK=1\" \"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\" \"ENABLE_SUPERVISED_USERS=1\" \"ENABLE_MDNS=1\" \"ENABLE_SERVICE_DISCOVERY=1\" V8_USE_EXTERNAL_STARTUP_DATA FULL_SAFE_BROWSING SAFE_BROWSING_CSD SAFE_BROWSING_DB_LOCAL EXPAT_RELATIVE_PATH FEATURE_ENABLE_SSL GTEST_RELATIVE_PATH HAVE_OPENSSL_SSL_H NO_MAIN_THREAD_WRAPPING NO_SOUND_SYSTEM WEBRTC_POSIX SRTP_RELATIVE_PATH SSL_USE_OPENSSL USE_WEBRTC_DEV_BRANCH \"timezone=_timezone\" XML_STATIC \"USE_LIBPCI=1\" \"USE_OPENSSL=1\" \"USE_OPENSSL_CERTS=1\"" "--link_flags=-B../../out/Debug/gen/tc_pnacl_newlib/lib  " "--source-list=../../out/gypfiles/third_party/libjingle/pnacl_newlib.libjingle_nacl.source_list.gypcmd"
In file included from ../webrtc/p2p/base/tcpport.cc:67:
../webrtc/p2p/base/tcpport.h:50:23: error: 'CreateConnection' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  virtual Connection* CreateConnection(const Candidate& address,
                      ^
../webrtc/p2p/base/portinterface.h:71:23: note: overridden virtual function is here
  virtual Connection* CreateConnection(
                      ^
In file included from ../webrtc/p2p/base/tcpport.cc:67:
../webrtc/p2p/base/tcpport.h:53:16: error: 'PrepareAddress' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
  virtual void PrepareAddress();
               ^
../webrtc/p2p/base/portinterface.h:63:16: note: overridden virtual function is here
  virtual void PrepareAddress() = 0;
               ^

(etc)

Original issue's description:
> Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket.
>
> To reduce the risk of future mistakes when connecting Ports, Port::OnSentPacket was made pure virtual to ensure that new implementations take care of it.
>
> BUG=4173
> R=pthatcher@webrtc.org
>
> Committed: https://crrev.com/7307952a5bf63311e5f9a2a90089a06177e42716
> Cr-Commit-Position: refs/heads/master@{#11247}

TBR=pthatcher@webrtc.org,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=4173

Review URL: https://codereview.webrtc.org/1586063002

Cr-Commit-Position: refs/heads/master@{#11249}
 2016-01-14 12:57:03 +00:00
aluebs
688e308a35 Re-land: "Use an explicit identifier in Config" 
This let's us use them to configure them when using WebRTC as an external library. One use case where this is necessary is in the Android OS.

Original CL: https://codereview.webrtc.org/1538643004/

TBR=tommi@webrtc.org

Review URL: https://codereview.webrtc.org/1589573004

Cr-Commit-Position: refs/heads/master@{#11248}
 2016-01-14 12:32:51 +00:00
Stefan Holmer
7307952a5b Connect TurnPort and TCPPort to AsyncPacketSocket::SignalSentPacket. 
To reduce the risk of future mistakes when connecting Ports, Port::OnSentPacket was made pure virtual to ensure that new implementations take care of it.

BUG=4173
R=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1577873003 .

Cr-Commit-Position: refs/heads/master@{#11247}
 2016-01-14 12:15:56 +00:00
nisse
268493a96b Revert of Delete remnants of non-square pixel support from cricket::VideoFrame. (patchset #1 id:1 of https://codereview.webrtc.org/1586613002/ ) 
Reason for revert:
These changes broke chrome.

Need to temporarily keep methods InitToEmptyBuffer, InitToBlack, CreateEmptyFrame with old but ignored arguments for pixel_width and pixel_height. Then update chrome, and delete the old methods in a separate cl.

Original issue's description:
> Delete remnants of non-square pixel support from cricket::VideoFrame.
>
> If ever needed, add some aspect ratio parameter, without pixel_width
> and pixel_height arguments cluttering commonly used functions.
>
> BUG=webrtc:5426
>
> Committed: https://crrev.com/709513d4133107d5c02aed34a5ee99444c4d4e25
> Cr-Commit-Position: refs/heads/master@{#11243}

TBR=pthatcher@webrtc.org,perkj@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5426

Review URL: https://codereview.webrtc.org/1583223002

Cr-Commit-Position: refs/heads/master@{#11246}
 2016-01-14 10:35:30 +00:00