Commit Graph

27262 Commits

Author SHA1 Message Date
6b319e68e9 Add CreateDatagram to MediaTransportFactory
Bug: webrtc:9719
Change-Id: I6e756d925917f032aa94a221706cd4241085b2a2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137340
Commit-Queue: Anton Sukhanov <sukhanov@webrtc.org>
Reviewed-by: Bjorn Mellem <mellem@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27980}
2019-05-17 22:18:41 +00:00
9fe1834d5d Implement RTCOutboundRtpStreamStats.totalPacketSendDelay for video.
This is a standardized metric. Spec:
https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-totalpacketsenddelay

It is meant to replace the legacy googBucketDelay. The average
packet delay over any interval can be calculated as the delta
totalPacketSendDelay divided by the delta packetsSent between two
calls to getStats().

Bug: webrtc:10506
Change-Id: I3d6c6d66e5a06937d0ea8d182a82cd255084ad19
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137044
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27979}
2019-05-17 18:53:20 +00:00
45b2e27ccd Remove non-source sources from binary targets
No behavior changes.

BUG=chromium:964411

Change-Id: I833cfc4571d2f191acbb53e4b423f2a174ac9de3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137520
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27978}
2019-05-17 18:43:00 +00:00
b50d995a5b Add juberti@ to webrtc root owners
It's useful to have someone in PST timezone with root approval.

Bug: webrtc:10638
Change-Id: I9453c6bca3b77879c0c893bff8ca1abb6db5ab2a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137182
Reviewed-by: Justin Uberti <juberti@google.com>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Commit-Queue: Anton Sukhanov <sukhanov@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27977}
2019-05-17 18:11:58 +00:00
12f886640f Roll chromium_revision 4c9872694a..243a2094e7 (660753:660868)
Change log: 4c9872694a..243a2094e7
Full diff: 4c9872694a..243a2094e7

Changed dependencies
* src/base: 5a3c8a6d57..fba03dece9
* src/build: 865cb800d6..3c7a12c795
* src/ios: dd4258e733..11b06981d9
* src/testing: 9d9a16dab9..904b090729
* src/third_party: 472de41bf6..fb42db204b
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/fd64d5d2d4..b1d937f421
* src/third_party/depot_tools: 5737f025b5..0e405d1ac6
* src/tools: 8c467d7632..912a00ef8d
DEPS diff: 4c9872694a..243a2094e7/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I8d7631c35d9a83c9b9e137d1e020117f8aeb42da
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137481
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27976}
2019-05-17 17:31:46 +00:00
3525f86c42 Adds feedback generator.
This is a useful tool to use for unittests of code that uses
TransportFeedback as input.

Bug: webrtc:10498
Change-Id: I171b22841eb9e16a5d5b785ff45ae9df5a6ccd7f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137423
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Jonas Olsson <jonasolsson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27975}
2019-05-17 16:14:32 +00:00
df5731e44d Improve spec compliance of SetStreamIDs in RtpSenderInterface
This CL makes RtpSender::SetStreamIDs fire fire negotiationneeded
event if needed and exposes the method on RtpSenderInterface.

This is a spec-compliance change.

Bug: webrtc:10129
Change-Id: I2b98b92665c847102838b094516a79b24de0e47e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135121
Commit-Queue: Guido Urdaneta <guidou@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27974}
2019-05-17 12:53:31 +00:00
519d74a5fc Drop data for disabled endpoints.
Drop packets received from disabled endpoint and return socket error
when trying to send data from disabled endpoint.

Bug: webrtc:10138
Change-Id: I55259d2ac47adea78b47aeb25842e63a98a405c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134643
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27973}
2019-05-17 10:31:22 +00:00
fd26ef732f Delete unused RTPFragmentationHeader members
Deleted fragmentationTimeDiff and fragmentationPlType. Unused since cl
https://webrtc-review.googlesource.com/c/src/+/134212.

Bug: webrtc:6471
Change-Id: I36b45be6f6babeda5a5f172c1f1a3876bb752e7f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134308
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27972}
2019-05-17 09:26:17 +00:00
f13a0960e6 Fix memory leak in Thread::PostTask.
Use MessageData rather than MessageHandler to refer
to allocated storage.

That way, MessageQueue will delete storage for us if the
thread object is stopped before the Message is handled.

Leak seems triggered by the
RTCStatsIntegrationTest.GetsStatsWhileClosingPeerConnection
test.

Bug: webrtc:9714
Change-Id: I9e1255a3b6f16a763568744775ec0b3aef671227
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136684
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27971}
2019-05-17 08:45:32 +00:00
1e193faaf1 Add DecelerationTargetLevelOffset Field Trial.
This change allows NetEq to reach preferred jitter buffer size much faster
for high target delays because it uses absolute units instead of relative ones
during computation of lower_limit.

More details can be found here:
https://docs.google.com/document/d/12qPMJYFhGXrA_o_nvz9VshpzAJX6aULxFig1fTzBzDI/edit

Change-Id: I21ce0e35e25166d935fdf0325c083bcf990899f5

Bug: webrtc:10619
Change-Id: I21ce0e35e25166d935fdf0325c083bcf990899f5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135745
Reviewed-by: Minyue Li <minyue@webrtc.org>
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Commit-Queue: Ruslan Burakov <kuddai@google.com>
Cr-Commit-Position: refs/heads/master@{#27970}
2019-05-17 08:08:12 +00:00
8e1a0080d3 Roll chromium_revision 64564f7a42..4c9872694a (660541:660753)
Change log: 64564f7a42..4c9872694a
Full diff: 64564f7a42..4c9872694a

Changed dependencies
* src/base: 79d0db3862..5a3c8a6d57
* src/build: 05ee3a4249..865cb800d6
* src/ios: 9efbd407c6..dd4258e733
* src/testing: f086dcc9cc..9d9a16dab9
* src/third_party: b57abf30b7..472de41bf6
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/72ee2533b1..fd64d5d2d4
* src/third_party/depot_tools: 99fe071354..5737f025b5
* src/tools: 3036709251..8c467d7632
DEPS diff: 64564f7a42..4c9872694a/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ib8805f3343f87366d0e9b7a3aaa822fe82a7a5ea
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137405
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27969}
2019-05-17 07:44:07 +00:00
02ed529340 Revert "Roll chromium_revision 64564f7a42..5ab21b0a3a (660541:660661)"
This reverts commit 45a827351bfc2406d4ef08eab9c551cdb8b93594.

Reason for revert: It contains https://chromium-review.googlesource.com/c/chromium/src/+/1610749 which breaks Android compilation at HEAD.

Original change's description:
> Roll chromium_revision 64564f7a42..5ab21b0a3a (660541:660661)
> 
> Change log: 64564f7a42..5ab21b0a3a
> Full diff: 64564f7a42..5ab21b0a3a
> 
> Changed dependencies
> * src/base: 79d0db3862..2af57fa3f5
> * src/build: 05ee3a4249..747602a080
> * src/ios: 9efbd407c6..8144c1a2dc
> * src/testing: f086dcc9cc..27aef0038a
> * src/third_party: b57abf30b7..78419dc6d6
> * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/72ee2533b1..fd64d5d2d4
> * src/tools: 3036709251..5d994ede45
> DEPS diff: 64564f7a42..5ab21b0a3a/DEPS
> 
> No update to Clang.
> 
> TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
> BUG=None
> 
> Change-Id: Ic4eca55ad692fc06a88d26b9ae40ddab68e8c384
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137320
> Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#27967}

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com

Change-Id: I9b1d68d02ab4fc8dd237245ce86b5a56c544637c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137420
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27968}
2019-05-17 07:02:15 +00:00
45a827351b Roll chromium_revision 64564f7a42..5ab21b0a3a (660541:660661)
Change log: 64564f7a42..5ab21b0a3a
Full diff: 64564f7a42..5ab21b0a3a

Changed dependencies
* src/base: 79d0db3862..2af57fa3f5
* src/build: 05ee3a4249..747602a080
* src/ios: 9efbd407c6..8144c1a2dc
* src/testing: f086dcc9cc..27aef0038a
* src/third_party: b57abf30b7..78419dc6d6
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/72ee2533b1..fd64d5d2d4
* src/tools: 3036709251..5d994ede45
DEPS diff: 64564f7a42..5ab21b0a3a/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ic4eca55ad692fc06a88d26b9ae40ddab68e8c384
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137320
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27967}
2019-05-17 00:31:05 +00:00
fe57f6252f Roll chromium_revision 0d85f6ad4e..64564f7a42 (660414:660541)
Change log: 0d85f6ad4e..64564f7a42
Full diff: 0d85f6ad4e..64564f7a42

Changed dependencies
* src/base: d2b96a427d..79d0db3862
* src/build: 2910da43de..05ee3a4249
* src/ios: 703ce24672..9efbd407c6
* src/testing: 3ea10302b0..f086dcc9cc
* src/third_party: 98b50663f6..b57abf30b7
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/89ec6c772d..72ee2533b1
* src/tools: 85b42ed358..3036709251
DEPS diff: 0d85f6ad4e..64564f7a42/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I4b3b3e7e5976e72a2a6e4647e90f4e25d46f506a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137240
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27966}
2019-05-16 20:26:24 +00:00
f0792ce410 Roll chromium_revision 609f581dc6..0d85f6ad4e (660301:660414)
Change log: 609f581dc6..0d85f6ad4e
Full diff: 609f581dc6..0d85f6ad4e

Changed dependencies
* src/base: 18f051a0f0..d2b96a427d
* src/build: 333f8224f9..2910da43de
* src/ios: 394135d276..703ce24672
* src/third_party: c5eea7e75a..98b50663f6
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d84db82ff3..89ec6c772d
* src/tools: 87a822c49d..85b42ed358
DEPS diff: 609f581dc6..0d85f6ad4e/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ic4cbe4d2852aba0b4764b9881509159376b32cd6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137140
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27965}
2019-05-16 16:34:29 +00:00
a24d934ee4 Add the option to use raw RTP packetization without the generic header.
Bug: webrtc:10625
Change-Id: I198031154dbb706ae1e7c15bd34a3bdf93d1a51a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136923
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Mirta Dvornicic <mirtad@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27964}
2019-05-16 14:41:42 +00:00
67c76b214d AEC3: Minor code corrections
Bug: webrtc:8671
Change-Id: I096053087e7ef0f3375f9c20b55558c1cec670cc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136806
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Commit-Queue: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27963}
2019-05-16 13:53:27 +00:00
9a4c93b7d7 Add DCHECK in LibvpxVp8Encoder
Ensure that frame_buffer_controller_ does not get assigned null
by the factory.

Bug: None
Change-Id: I84e141ae0390cd024863f88cdcdc79b8b13e7c64
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137043
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Commit-Queue: Elad Alon <eladalon@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27962}
2019-05-16 13:29:07 +00:00
f204787478 ReportBlockData and observer added, for stats collection in future CLs.
The ReportBlockData contains information about a ReportBlock and
additional data such as RTT. This will be used for the calculation of
RTCRemoteInboundRtpStreamStats, see full picture here:
https://webrtc-review.googlesource.com/c/src/+/134107

ReportBlockData is a class version of the previously internal struct
RTCPReceiver::ReportBlockWithRtt.
- The new name makes sense even if we add more info to it, which will
  be needed for future metrics.
- The new location is modules/rtp_rtcp/include/report_block_data.h.

The RTCPReceiver allows obtaining the ReportBlockData in two ways:
1. Using a ReportBlockDataObserver that is notified on receiving a
   report block.
2. Using the GetLatestReportBlockData().

Both codepaths will be needed; video stats uses observers and audio
stats uses polling.

Further plumbing will be done in follow-up CLs.

Bug: webrtc:10455, webrtc:10456
Change-Id: Ic9e5b4f451b5f4b203efcd6fa3bbf9736487e1f4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136584
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27961}
2019-05-16 12:12:07 +00:00
8d3d6cf908 SCTP: Treat message size zero as "responder selects"
This also refactors some of the code in peerconnection for
handling SCTP transports to be internal to the webrtc::SctpTransport
class, rather than being in peerconnection.

Bug: webrtc:10358, webrtc:10629
Change-Id: I15ecf95c199f56b08909e5a9311d446a412ed162
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137041
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27960}
2019-05-16 11:03:17 +00:00
6e70f18fbd Revert "Delete deprecated rtc::Thread default constructor"
This reverts commit fdd6d3e46e22e1242aa4acd7aa0271a7562fb0ac.

Reason for revert: Seems to be be breaking downstream project.

Original change's description:
> Delete deprecated rtc::Thread default constructor
> 
> Bug: None
> Change-Id: Ic0e2e94b174a49e5d20ebdea90568473e1b71d62
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134640
> Reviewed-by: Tommi <tommi@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27958}

TBR=nisse@webrtc.org,tommi@webrtc.org

Change-Id: Id8015805c28c08e5e5d97c0cdef3c17d6d281fb5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137042
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27959}
2019-05-16 10:27:25 +00:00
fdd6d3e46e Delete deprecated rtc::Thread default constructor
Bug: None
Change-Id: Ic0e2e94b174a49e5d20ebdea90568473e1b71d62
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/134640
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27958}
2019-05-16 08:44:21 +00:00
198cf00532 Reland "Change SimpleStringBuilder::Append to not use strcpyn and SIZE_UNKNOWN"
This is a reland of e779847fb6499ac2dc4757de8c625ac377e9d0d4

Original change's description:
> Change SimpleStringBuilder::Append to not use strcpyn and SIZE_UNKNOWN
>
> Also add explicit includes of rtc_base/string_utils.h in files depending on it.
>
> Bug: webrtc:6424
> Change-Id: Id6b53937ab2d185d092a5d8863018fd5f1a88e27
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135744
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#27903}

Tbr: kwiberg@webrtc.org
Bug: webrtc:6424
Change-Id: Ic08d5d7fbc25ff89e4182d7c9cb3b0e8e356339a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135946
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27957}
2019-05-16 08:21:04 +00:00
baf9c62bc7 Add <cstdio> include to string_builder.cc to support Android NDK r17
<cstdio> is needed for std::vsnprintf() on Android NDK r17

Bug: NONE
Change-Id: Ib533bc64fcc41deb68613f494b6777dcf805907e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137001
Commit-Queue: Tommi <tommi@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27956}
2019-05-16 06:39:22 +00:00
4e4fc628ab Roll chromium_revision 34a275789d..609f581dc6 (660187:660301)
Change log: 34a275789d..609f581dc6
Full diff: 34a275789d..609f581dc6

Changed dependencies
* src/base: 0ad5b51f71..18f051a0f0
* src/build: 871de7d6f1..333f8224f9
* src/ios: a9513a7603..394135d276
* src/testing: bde2acd1c5..3ea10302b0
* src/third_party: 5d12aa240a..c5eea7e75a
* src/third_party/depot_tools: 1f5e810a97..99fe071354
* src/third_party/icu: e3d32ff805..64e5d7d43a
* src/tools: 4fad880e99..87a822c49d
DEPS diff: 34a275789d..609f581dc6/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I3dcedccab9713f5980a2fd01387e659db41ecf44
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137008
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27955}
2019-05-16 06:33:22 +00:00
0f1a7ba23c Thread safe crc32 table initialization
The lazy generated table was not entirely thread safe under the
C++ (11) memory model, as pointed out by TSAN.

Bug: webrtc:10627
Change-Id: I0fe1cc7c10ca218a92c710a6382b64d7827f3a6a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136980
Reviewed-by: Amit Hilbuch <amithi@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27954}
2019-05-15 23:54:07 +00:00
9a7970de28 Roll chromium_revision ee800955b4..34a275789d (660080:660187)
Change log: ee800955b4..34a275789d
Full diff: ee800955b4..34a275789d

Changed dependencies
* src/base: 9700b6c4a5..0ad5b51f71
* src/build: 02b41bae7e..871de7d6f1
* src/ios: bb963637b1..a9513a7603
* src/testing: 4b22daf6aa..bde2acd1c5
* src/third_party: a0f42b25dc..5d12aa240a
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0aa89afdae..d84db82ff3
* src/third_party/depot_tools: a16f28fc23..1f5e810a97
* src/tools: 6a18b23f27..4fad880e99
DEPS diff: ee800955b4..34a275789d/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I90eba9f0c8b5e4be080a9c51773fe147d96475b4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136981
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27953}
2019-05-15 23:31:44 +00:00
dafb4f8279 Roll chromium_revision 7991984f8d..ee800955b4 (659976:660080)
Change log: 7991984f8d..ee800955b4
Full diff: 7991984f8d..ee800955b4

Changed dependencies
* src/base: 06559ae1bd..9700b6c4a5
* src/build: 603171c47c..02b41bae7e
* src/ios: db402dfa15..bb963637b1
* src/testing: 169fbb8020..4b22daf6aa
* src/third_party: f9a875745b..a0f42b25dc
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/71e1bec28d..0aa89afdae
* src/third_party/depot_tools: 2d3b9260f3..a16f28fc23
* src/tools: 6da0e43b2b..6a18b23f27
DEPS diff: 7991984f8d..ee800955b4/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ib3e25c446f57a858a10a19dcae69b67743995d65
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136961
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27952}
2019-05-15 20:33:14 +00:00
666290a263 Roll chromium_revision eacdc75a1b..7991984f8d (659866:659976)
Change log: eacdc75a1b..7991984f8d
Full diff: eacdc75a1b..7991984f8d

Changed dependencies
* src/base: f2cb8c38b7..06559ae1bd
* src/build: 5cb705b0be..603171c47c
* src/ios: b94d8e4111..db402dfa15
* src/testing: 366ab933a1..169fbb8020
* src/third_party: e9dee5f383..f9a875745b
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/578d0b9046..71e1bec28d
* src/tools: bc8b67f769..6da0e43b2b
DEPS diff: eacdc75a1b..7991984f8d/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ibf1727662896428e905510579e59f2ca375d9a99
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136912
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27951}
2019-05-15 17:35:09 +00:00
7581ff7375 Add screen share support to PC level test framework
Bug: webrtc:10138
Change-Id: I1a8ac683e91f8061387f407610d7db2a6d0d4fe9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136805
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Bjorn Mellem <mellem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27950}
2019-05-15 14:07:00 +00:00
a768345596 Reduce flakiness of NetworkEmulationManagerTest.ThroughputStats
Bug: webrtc:10138, webrtc:10553
Change-Id: Id7027b94b3a6c072ee48c1291b638f2dc8b8b095
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133164
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27949}
2019-05-15 11:32:46 +00:00
0ac1d993be Remove streaming_mode as it is always false.
Change-Id: I489b72985f36fd98413ecf729f7d69476c342851

Bug: webrtc:10618
Change-Id: I489b72985f36fd98413ecf729f7d69476c342851
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136803
Reviewed-by: Jakob Ivarsson‎ <jakobi@webrtc.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Ruslan Burakov <kuddai@google.com>
Cr-Commit-Position: refs/heads/master@{#27948}
2019-05-15 11:12:46 +00:00
4fd42974b1 Fix metadata setting in H264 decoder
Bug: webrtc:10303
Change-Id: Ie819802bd99975184b7a0dba3a56260d156b0246
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136807
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27947}
2019-05-15 08:43:07 +00:00
8567c39a15 Roll chromium_revision 3820725ad2..eacdc75a1b (659764:659866)
Change log: 3820725ad2..eacdc75a1b
Full diff: 3820725ad2..eacdc75a1b

Changed dependencies
* src/base: ede2b4df70..f2cb8c38b7
* src/build: efffdc012c..5cb705b0be
* src/ios: 6b63d0d961..b94d8e4111
* src/testing: cb98445141..366ab933a1
* src/third_party: f8fa05354f..e9dee5f383
* src/third_party/depot_tools: 3d86f06bc7..2d3b9260f3
* src/tools: ed0e423f60..bc8b67f769
DEPS diff: 3820725ad2..eacdc75a1b/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I4297f6a987cac12629c6814226b535097dac5ecb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136904
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27946}
2019-05-15 08:30:47 +00:00
fbb45bd02f Send and parse SCTP max-message-size in SDP
This also changes the default when no max-message-size is set
to the protocol defined value of 64K, and prevents messages
from being sent when they are too large to send.

Bug: webrtc:10358
Change-Id: Iacc1dd774d1554d9f27315378fbea6351300b5cc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135948
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27945}
2019-05-15 07:14:32 +00:00
e88eefc411 Roll chromium_revision 279d455093..3820725ad2 (659647:659764)
Change log: 279d455093..3820725ad2
Full diff: 279d455093..3820725ad2

Changed dependencies
* src/base: ec2cc0a1a2..ede2b4df70
* src/ios: b7a7733b5d..6b63d0d961
* src/testing: fce90f9e9f..cb98445141
* src/third_party: 501af987a1..f8fa05354f
* src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/777a239175..f014d609c0
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/88ad352aa1..578d0b9046
* src/third_party/depot_tools: 9f1377b765..3d86f06bc7
* src/tools: 3a50b5147f..ed0e423f60
DEPS diff: 279d455093..3820725ad2/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ief2f41943772eac48bc1e8cde1952876ad16baf3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136865
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27944}
2019-05-15 01:37:58 +00:00
c136b06326 Add datagram_transport and congestion_control interface
This change introduces experimental datagram_transport interface and congestion_control interfaces. The goal is to integrate support for datagram transport in DTLS transport and set it up in a similar way we currently setup media_transport. Datagram transport will be injected in peer connection factory the same way media_transport is injected (we might even keep using the same factory which creates both media and datagram transports for now until we decided what to do next).

Bug: webrtc:9719
Change-Id: I80e70ce8d3827664ac5f5f7e55b706fe2dd2fbef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136782
Commit-Queue: Anton Sukhanov <sukhanov@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Bjorn Mellem <mellem@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27943}
2019-05-14 22:22:45 +00:00
39068db06d Roll chromium_revision 1c80f902b4..279d455093 (659511:659647)
Change log: 1c80f902b4..279d455093
Full diff: 1c80f902b4..279d455093

Changed dependencies
* src/base: 885d7bef7b..ec2cc0a1a2
* src/build: e341300b4e..efffdc012c
* src/ios: b8508d3503..b7a7733b5d
* src/testing: f036f1b5df..fce90f9e9f
* src/third_party: 7f530d4e6f..501af987a1
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/701ac9a6e8..88ad352aa1
* src/third_party/depot_tools: 8a96493270..9f1377b765
* src/third_party/libvpx/source/libvpx: 4d0fe85c19..78c44e2dc2
* src/tools: 2bdafa7073..3a50b5147f
DEPS diff: 1c80f902b4..279d455093/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,marpan@webrtc.org, jianj@chromium.org,
BUG=None

Change-Id: I9175569862285f0b19bd3fc4eef985406d06bad6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136862
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27942}
2019-05-14 21:34:45 +00:00
4aa1192508 Change default SDP syntax for SCTP to spec-compliant.
This also introduces an option in CreateOfferOptions for
getting the non-spec behavior (2013 vintage) back.

Bug: chromium:962860
Change-Id: I72267408a61d6eb03e9895fe38b4cc803d8cbbaf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136809
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27941}
2019-05-14 20:38:08 +00:00
c3f4820e12 Change default secure SCTP protocol to UDP/DTLS/SCTP
The old value - DTLS/SCTP - is not standards conformant,
and the new value should be parsable since Chrome M61.

Bug: webrtc:7706
Change-Id: I7468cc9597dec4ef4b102fccddc4e981fed7e8d8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136804
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27940}
2019-05-14 18:36:47 +00:00
83afeebe94 Remove redundant capture time adjustment in RtpSender
webrtc::RealTimeClock::TimeInMilliseconds() and
rtc::TimeMillis() have for some time been backed by the same clock,
no need for adjustment.

Bug: None
Change-Id: I5962153d9f5aa5e58ccde26393c322972cb51d43
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136808
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27939}
2019-05-14 17:33:16 +00:00
3b9aa66c7b Roll chromium_revision 9500673d82..1c80f902b4 (659367:659511)
Change log: 9500673d82..1c80f902b4
Full diff: 9500673d82..1c80f902b4

Changed dependencies
* src/base: f337b799b1..885d7bef7b
* src/build: ebde73c978..e341300b4e
* src/ios: 8f337d96b4..b8508d3503
* src/testing: ba56fcd1b4..f036f1b5df
* src/third_party: fc67e8b588..7f530d4e6f
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/95764ff31e..701ac9a6e8
* src/third_party/depot_tools: 6a9b00e433..8a96493270
* src/third_party/googletest/src: 3f5b5b8f84..9d4cde44a4
* src/third_party/harfbuzz-ng/src: f3aca6aa26..c73d7ba75d
* src/tools: 3a60b148b1..2bdafa7073
DEPS diff: 9500673d82..1c80f902b4/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ibb40f3b0ec12f2df2dc25c5ab859ab2f544eb773
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136845
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27938}
2019-05-14 16:33:24 +00:00
f11c8d1e2c Check for uninitialized audio unit in HandleInterruptionEnd.
This fixes a potential crash if interrupted before the audio unit has been initialized.

Bug: None
Change-Id: Ib9f5ea305c98a172f8df52af5767c8543e59701c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136800
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Kári Helgason <kthelgason@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27937}
2019-05-14 07:42:55 +00:00
90d9feb8c8 Roll chromium_revision a1c6ffe854..9500673d82 (659234:659367)
Change log: a1c6ffe854..9500673d82
Full diff: a1c6ffe854..9500673d82

Changed dependencies
* src/base: c99c84bf42..f337b799b1
* src/ios: e8d17daf9b..8f337d96b4
* src/testing: 1941004760..ba56fcd1b4
* src/third_party: 7d4f7b7044..fc67e8b588
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e33ee3bd7c..95764ff31e
* src/third_party/depot_tools: 417f2332fc..6a9b00e433
* src/third_party/icu: 3a162e7afb..e3d32ff805
* src/tools: cbc88ed274..3a60b148b1
DEPS diff: a1c6ffe854..9500673d82/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Iddb0bd97b321adf0474e4ddcfc2f9a622d6eec52
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136788
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27936}
2019-05-14 03:43:22 +00:00
66fbb13a1e Roll chromium_revision b06ee6f3e1..a1c6ffe854 (659110:659234)
Change log: b06ee6f3e1..a1c6ffe854
Full diff: b06ee6f3e1..a1c6ffe854

Changed dependencies
* src/base: 5020ecdefb..c99c84bf42
* src/build: c4b1fe65f9..ebde73c978
* src/buildtools: d5c58b84d5..1f329a6e26
* src/ios: c688f64c73..e8d17daf9b
* src/testing: ce1f50210a..1941004760
* src/third_party: 1c791d6c08..7d4f7b7044
* src/third_party/depot_tools: 42db0b42ab..417f2332fc
* src/tools: 5c06a7d838..cbc88ed274
DEPS diff: b06ee6f3e1..a1c6ffe854/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I7ca055403dd04303036a227f5daefddc2b8c3b4c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136783
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27935}
2019-05-13 22:34:05 +00:00
e62a08a87a Request key frame on all layers.
Explicitly request key frame on all layers until proper mapping is
implemented (webrtc:10615).

Bug: webrtc:10585
Change-Id: I9722610920a753c50700d925ff6a1babf0011e2f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136682
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27934}
2019-05-13 21:00:26 +00:00
5fc28b11a0 Reland "Reland "Version 2 "Refactoring DataContentDescription class"""
This reverts commit 46afbf9481fbcc939c998c898ca1031ce41cc6b1.

Reason for revert: Tightened protocol name handling.

Original change's description:
> Revert "Reland "Version 2 "Refactoring DataContentDescription class"""
>
> This reverts commit 37f2b43274a0d718de53a4cfcf02226356edcf6e.
>
> Reason for revert: fuzzer failures
>
> Original change's description:
> > Reland "Version 2 "Refactoring DataContentDescription class""
> >
> > This is a reland of 14b2758726879d21671a21291dfed8fb4fd5c21c
> >
> > Original change's description:
> > > Version 2 "Refactoring DataContentDescription class"
> > >
> > > (substantial changes since version 1)
> > >
> > > This CL splits the cricket::DataContentDescription class into
> > > two classes: cricket::RtpDataContentDescription (used for RTP data)
> > > and cricket::SctpDataContentDescription (used for SCTP only).
> > >
> > > SctpDataContentDescription no longer inherits from
> > > MediaContentDescriptionImpl, and no longer contains "codecs".
> > >
> > > Due to usage of internal interfaces by consumers, shimming the old
> > > DataContentDescription API is needed.
> > >
> > > A new cricket::DataContentDescription class is defined, which is
> > > a shim over RtpDataContentDescription and SctpDataContentDescription.
> > > It exposes as little functionality as possible, but supports the
> > > concerned consumer's usage
> > >
> > > Design document:
> > > https://docs.google.com/document/d/1H5LfQxJA2ikMWTQ8FZ3_GAmaXM7knfVQWiSz6ph8VQ0/edit#
> > >
> > > Version 1 reviewed-on: https://webrtc-review.googlesource.com/c/src/+/132700
> > >

Bug: webrtc:10358
Change-Id: Ia9fb8f4679e082e3d18fbbb6b03fc13a08e06110
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136581
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27933}
2019-05-13 18:37:47 +00:00
863b2a2749 Roll chromium_revision 7da20dc3cb..b06ee6f3e1 (658985:659110)
Change log: 7da20dc3cb..b06ee6f3e1
Full diff: 7da20dc3cb..b06ee6f3e1

Changed dependencies
* src/base: 657d4f71f2..5020ecdefb
* src/build: 0fdfe6341a..c4b1fe65f9
* src/ios: 3afbfa2688..c688f64c73
* src/testing: 380db54b75..ce1f50210a
* src/third_party: f925a7d871..1c791d6c08
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ff395373a9..e33ee3bd7c
* src/third_party/gtest-parallel: 3ca6798e2c..3fca10f81e
* src/tools: c3a7f3e412..5c06a7d838
DEPS diff: 7da20dc3cb..b06ee6f3e1/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I92427c2b502a4a4420a7629dcde65b259073f044
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/136740
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#27932}
2019-05-13 18:36:41 +00:00
3dfb68082e Use robust variance computation in RollingAccumulator.
Previous one was failing NumericStabilityForVariance test.

Bug: webrtc:10412
Change-Id: I97ba321743ebb8cc0923ae13a17c9997779fc305
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133029
Commit-Queue: Yves Gerey <yvesg@google.com>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27931}
2019-05-13 15:41:01 +00:00