ef1052a134
Reland "Move api/rtp_headers.h to its own build target."
...
This is a reland of a67050debcb5a3461a452a7928d7aaea1562747e
Original change's description:
> Move api/rtp_headers.h to its own build target.
>
> Reduces dependencies on the libjingle_peerconnection_api target from
> lower-level code.
>
> Bug: None
> Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27213}
Bug: None
Tbr: kwiberg@webrtc.org
Change-Id: If15b05957e50bb8f18a33c2ed1321e672311b626
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127895
Reviewed-by: Niels Moller <nisse@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27216}
2019-03-21 09:17:07 +00:00
2baef3509f
Revert "Move api/rtp_headers.h to its own build target."
...
This reverts commit a67050debcb5a3461a452a7928d7aaea1562747e.
Reason for revert: breaks downstream projects
Original change's description:
> Move api/rtp_headers.h to its own build target.
>
> Reduces dependencies on the libjingle_peerconnection_api target from
> lower-level code.
>
> Bug: None
> Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565
> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Commit-Queue: Niels Moller <nisse@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27213}
TBR=danilchap@webrtc.org ,kwiberg@webrtc.org ,nisse@webrtc.org
Change-Id: I8cccaa8be1700ca8db141db7252eb6ce588ba2e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128645
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27215}
2019-03-20 16:47:30 +00:00
a67050debc
Move api/rtp_headers.h to its own build target.
...
Reduces dependencies on the libjingle_peerconnection_api target from
lower-level code.
Bug: None
Change-Id: I98576fc718c396cc0f720c3770acd2b696b9df89
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128565
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27213}
2019-03-20 16:00:49 +00:00
1f850a6dc7
Reland "SeqNumUnwrapper::Unwrap now returns int64_t instead of uint64_t."
...
This reverts commit b5207b488b035eae4d11dfdcca9526d5a70c9c09.
Reason for revert: DecodedFramesHistory has now been updated.
Original change's description:
> Revert "SeqNumUnwrapper::Unwrap now returns int64_t instead of uint64_t."
>
> This reverts commit b0f968a761b715da4cf81e4b9c3cab0ccd322cf2.
>
> Reason for revert: Need to update DecodedFramesHistory to manage negative picture IDs.
>
> Original change's description:
> > SeqNumUnwrapper::Unwrap now returns int64_t instead of uint64_t.
> >
> > Bug: webrtc:10263
> > Change-Id: Idaeae6be01bd4eba0691226c958d70e114161ffd
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127295
> > Commit-Queue: Philip Eliasson <philipel@webrtc.org >
> > Reviewed-by: Johannes Kron <kron@webrtc.org >
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#27129}
>
> TBR=kwiberg@webrtc.org ,eladalon@webrtc.org ,terelius@webrtc.org ,philipel@webrtc.org ,kron@webrtc.org
>
> Change-Id: I529bb0475bd21a80fa244278aff1fd912a85c169
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10263
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127885
> Reviewed-by: Philip Eliasson <philipel@webrtc.org >
> Commit-Queue: Philip Eliasson <philipel@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27135}
TBR=kwiberg@webrtc.org ,eladalon@webrtc.org ,terelius@webrtc.org ,philipel@webrtc.org ,kron@webrtc.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: webrtc:10263
Change-Id: Id59e377010b5070dd37a7ece8df79b23af43835a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128568
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27191}
2019-03-19 17:02:27 +00:00
b5207b488b
Revert "SeqNumUnwrapper::Unwrap now returns int64_t instead of uint64_t."
...
This reverts commit b0f968a761b715da4cf81e4b9c3cab0ccd322cf2.
Reason for revert: Need to update DecodedFramesHistory to manage negative picture IDs.
Original change's description:
> SeqNumUnwrapper::Unwrap now returns int64_t instead of uint64_t.
>
> Bug: webrtc:10263
> Change-Id: Idaeae6be01bd4eba0691226c958d70e114161ffd
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127295
> Commit-Queue: Philip Eliasson <philipel@webrtc.org >
> Reviewed-by: Johannes Kron <kron@webrtc.org >
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#27129}
TBR=kwiberg@webrtc.org ,eladalon@webrtc.org ,terelius@webrtc.org ,philipel@webrtc.org ,kron@webrtc.org
Change-Id: I529bb0475bd21a80fa244278aff1fd912a85c169
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10263
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127885
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27135}
2019-03-14 18:14:33 +00:00
f1c9e21366
ClangTidy fixes for logging/
...
These are manual edits please verify there are no typos.
Feel free to auto-submit if there are no issues.
Bug: webrtc:10410
Change-Id: I2ea59dc66230182bee6ae7a0925aed0fe9ef823c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127643
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27133}
2019-03-14 14:51:00 +00:00
b0f968a761
SeqNumUnwrapper::Unwrap now returns int64_t instead of uint64_t.
...
Bug: webrtc:10263
Change-Id: Idaeae6be01bd4eba0691226c958d70e114161ffd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/127295
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Johannes Kron <kron@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27129}
2019-03-14 13:01:20 +00:00
1175ae0d80
Add log based GoogCC simulation to visualizer.
...
This CL adds a mode to simulate roughly what GoogCC could have been
doing during the recording of an rtc event log by using the logged
events as input to GoogCC and visualizing the resulting target rate.
This is similar to the existing simulated_sendside_bwe mode, but uses
the new NetworkControllerInterface to ensure more reliable GoogCC
simulation.
Bug: None
Change-Id: I57894aa666151efc8405407d928b5257fb9b7d61
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/123924
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27095}
2019-03-13 09:39:14 +00:00
471783fc87
Remove rtc::QueuedTask alias, use webrtc::QueuedTask directly
...
Use absl::WrapUnique/absl::make_unique to create the queued tasks.
Bug: webrtc:10191
Change-Id: I8f47a60cb326b0fc361c7f0e338b25373d39937c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126525
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27063}
2019-03-11 16:49:21 +00:00
62c7b39c71
Allow suppression of padding check in RtpHeaderParser.
...
Bug: None
Change-Id: I39574cade2c8c9df539f778fd97cb7a62827e169
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125521
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#27039}
2019-03-08 15:54:17 +00:00
c8eeb18d41
Fixes parsing of logs where receive time info is missing.
...
Bug: None
Change-Id: I42165d3d9fa218f06013e964065a336e04f9f837
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/125522
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26962}
2019-03-05 08:19:10 +00:00
fc52b912a3
Implicitly suppress //build/config/clang:find_bad_constructs.
...
Since there is no way to enable/disable these diagnostics at runtime,
this CL moves the suppression into the rtc_* templates in order to
remove the need to explicitly add the snippet of code needed to
suppress it (currently copy/pasted in 144 locations).
The diagnostic that causes the most problems is the one about "complex
class/struct explicit ctor/dtor" [1] because WebRTC doesn't find
it useful enough.
Other diagnostics are good (for example the one that warns about
using "virtual" instead of "override", but that will be covered by
this clang-tidy check [2]) while others are Chromium related so
they have never triggered.
[1] - https://cs.chromium.org/chromium/src/tools/clang/plugins/FindBadConstructsConsumer.cpp?l=147-167&rcl=b4bebe1aa15dba7ca5fcc6456a81a55665327c3a
[2] - https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html
Bug: webrtc:163
Change-Id: Icbf27efa5b369100a31e6a32df1a0913729b3b34
Reviewed-on: https://webrtc-review.googlesource.com/c/125088
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26918}
2019-03-01 10:18:17 +00:00
b8a4d688f9
Allow injection of task queue factory in RtcEventLog.
...
Bug: webrtc:10365
Change-Id: I48dcaaa7cecf8a201a30b81f23056a4d3a72c5a4
Reviewed-on: https://webrtc-review.googlesource.com/c/124825
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26906}
2019-02-28 16:59:54 +00:00
6b7bf6ab0c
Add a presubmit check for absl/memory/memory.h inclusion for WrapUnique
...
This fixes a build error on C++17 mode due to missing #include, plus
adds a presubmit check to prevent further breakage.
Bug: chromium:752720
Change-Id: I5c7d1dca0079dfe7a042650402e6f7ae28a797ba
Reviewed-on: https://webrtc-review.googlesource.com/c/124940
Commit-Queue: Taiju Tsuiki <tzik@chromium.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26898}
2019-02-28 14:12:48 +00:00
08f6a6c672
Import proto_library.gni when rtc_enable_protobuf is true
...
Import proto_library.gni when rtc_enable_protobuf is true instead of when
build_with_mozilla is false.
Makes it maybe easier to reason about the intention (e.g. intention is to not
compile any protobuf in, hence flag rtc_enable_protobuf)
The build file could not work if build_with_mozilla = true but
rtc_enable_protobuf = true.
Bug: webrtc:10338
Change-Id: I26e5983bd1519aa46c308b11796d518de5ef7597
Reviewed-on: https://webrtc-review.googlesource.com/c/123763
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26868}
2019-02-27 09:56:42 +00:00
74f0a51f97
Move kFeedbackMessageType from Remb to Psfb
...
The FMT 15 is not specific only to REMB or loss notification messages.
Rather, it is the Application Layer FB (AFB) of Psfb (Payload Specific
Feedback Messages).
See https://tools.ietf.org/html/rfc4585#section-6.3
TBR=terelius@webrtc.org
Bug: webrtc:10336
Change-Id: I8cd27ef9ee044bf7b7e7c1bd1a53c1dae2d95006
Reviewed-on: https://webrtc-review.googlesource.com/c/123886
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26827}
2019-02-24 00:11:33 +00:00
8aa00f0371
Add missing absl/memory/memory.h to rtc_event_generic_ack_received.cc
...
absl/memory/memory.h needs to be included for absl::WrapUnique on the
C++17 mode build, as absl/types/optional.h has a conditional include of
memory.h.
Tbr: terelius@webrtc.org
Bug: chromium:752720
Change-Id: I7bdfb200f29ac8ec11f0b102304b7788595e7eb9
Reviewed-on: https://webrtc-review.googlesource.com/c/123360
Commit-Queue: Taiju Tsuiki <tzik@chromium.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26815}
2019-02-22 11:14:38 +00:00
054db54ec4
Remove an absl::WrapUnique usage without absl/memory/memory.h include
...
absl::WrapUnique requires memory.h include on C++17 mode compile.
Bug: chromium:752720
Change-Id: Iaa958652727c8927831d8eecd223678328c7b3bd
Reviewed-on: https://webrtc-review.googlesource.com/c/122440
Commit-Queue: Taiju Tsuiki <tzik@chromium.org >
Reviewed-by: Peter Slatala <psla@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26701}
2019-02-15 04:39:06 +00:00
cf8405e172
Add generic packet rates to event_log_visualizer.
...
This change adds incoming & outgoing packet rates to the
event_log_visualizer.
The outgoing packet rate is drawn on the graph with outgoing RTP rate,
because we want to see it together with bandwidth estimate and probe
clusters.
The incoming packet rate is drawn separately.
Bug: webrtc:9719
Change-Id: I32648d016359af110837440ed1a5f9c31c841ea7
Reviewed-on: https://webrtc-review.googlesource.com/c/122941
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Bjorn Mellem <mellem@webrtc.org >
Commit-Queue: Peter Slatala <psla@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26696}
2019-02-14 22:45:37 +00:00
aec9794120
Fix DCHECK when encoding GenericPacket* events using the legacy RTC event log format.
...
Bug: webrtc:10319
Change-Id: I6764072281b8d66a8e4a5b2c0e547af3bfddda37
Reviewed-on: https://webrtc-review.googlesource.com/c/123121
Commit-Queue: Peter Slatala <psla@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26693}
2019-02-14 18:11:19 +00:00
da825b1b12
Replace NOTREACHED with a break.
...
The old format is still used.
Bug: None
Change-Id: I2c8c9a8c7b09282ba8c375403cbee7fd7ab2d056
Reviewed-on: https://webrtc-review.googlesource.com/c/122960
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26679}
2019-02-14 09:59:49 +00:00
1290fc7086
Remove old accessor in GenericAckReceived
...
Bug: None
Change-Id: I6bb58f09731e0492e93bb28fd5d9fb541c7c8db1
Reviewed-on: https://webrtc-review.googlesource.com/c/122961
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26678}
2019-02-14 09:57:45 +00:00
dfd5c4b15e
Parse XR, FIR and PLI in rtc_event_log_parser.cc
...
Bug: webrtc:10312
Change-Id: I1b24e23f8002feef8a2ef928130ac6da19c3cd81
Reviewed-on: https://webrtc-review.googlesource.com/c/122580
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Mirta Dvornicic <mirtad@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26670}
2019-02-13 19:11:42 +00:00
5e2aad1c95
Support GenericPacketReceived/Sent/AckReceived event logs.
...
This change does not include receive_timestamps for ACKs, because there is 1 problem.
That problem will be resolved in a separate change.
I am getting receive_timestamp errors that have to do with delta compression with optional fields.
Two failure modes that I noticed:
1) the base event does not have the timestamp: it crashes with length validation
# Check failed: base <= MaxUnsignedValueOfBitWidth(params_.value_width_bits()) (1820716 vs. 131071)
2) all events are null, it crashes with assert that X events were expected, but no events were deserialized.
Bug: webrtc:9719
Change-Id: I5d1bbb95dfd15ca7321667aad5e4d89c085e9c06
Reviewed-on: https://webrtc-review.googlesource.com/c/122360
Commit-Queue: Peter Slatala <psla@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26668}
2019-02-13 17:06:22 +00:00
157540ac05
Stop hard-coding default IDs for RTP extensions
...
Hard-coding default values forces IDs over 14 to be used even
when we offer less than 15 different extensions.
Note that the code relies on MergeRtpHdrExts for making sure
that extension IDs are kept consistent and non-colliding between
different streams (audio/video).
Bug: webrtc:10288
Change-Id: I3e59f7ddc8ca43cea91084a6b7f36df70fb6be4a
Reviewed-on: https://webrtc-review.googlesource.com/c/121646
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Steve Anton <steveanton@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26622}
2019-02-09 01:04:35 +00:00
f6adac87b4
Add rtc event generic packet sent and received.
...
Bug: webrtc:9719
Change-Id: I2f692d9c1b33ac390975a9e695c7652cdc1b1e6e
Reviewed-on: https://webrtc-review.googlesource.com/c/121680
Commit-Queue: Peter Slatala <psla@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Bjorn Mellem <mellem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26616}
2019-02-08 19:13:57 +00:00
0859142244
Add events processing to GetIceEvents.
...
Bug: webrtc:10170
Change-Id: I91f58fe67552060ae50eea425637dd50479a9f17
Reviewed-on: https://webrtc-review.googlesource.com/c/121643
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26569}
2019-02-06 14:14:09 +00:00
1c54605e77
[clang-tidy] Apply performance-move-const-arg fixes (misc).
...
This CL is a manual spin-off of [1], which tried to apply clang-tidy's
performance-move-const-arg [1] to the WebRTC codebase.
Since there were some wrong fixes to correct, this CL lands a few
different fixes, like adding a constructor overload to take an rvalue
reference or remove 'const' to make std::move effective.
[1] - https://webrtc-review.googlesource.com/c/src/+/120350
[2] - https://clang.llvm.org/extra/clang-tidy/checks/performance-move-const-arg.html
Bug: webrtc:10252
Change-Id: I42a777247fee2cb788efcd7c2035148330056b7a
Reviewed-on: https://webrtc-review.googlesource.com/c/120928
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26553}
2019-02-05 15:12:20 +00:00
c84f661b10
Stop using Googletest legacy APIs.
...
Googletest recently started replacing the term Test Case by Test Suite.
From now on, the preferred API is TestSuite*; the older TestCase* API
will be slowly deprecated.
This CL moves WebRTC to the new set of APIs.
More info in [1].
This CL has been generated with this script:
declare -A items
items[TYPED_TEST_CASE]=TYPED_TEST_SUITE
items[TYPED_TEST_CASE_P]=TYPED_TEST_SUITE_P
items[REGISTER_TYPED_TEST_CASE_P]=REGISTER_TYPED_TEST_SUITE_P
items[INSTANTIATE_TYPED_TEST_CASE_P]=INSTANTIATE_TYPED_TEST_SUITE_P
items[INSTANTIATE_TEST_CASE_P]=INSTANTIATE_TEST_SUITE_P
for i in "${!items[@]}"
do
git ls-files | xargs sed -i "s/\b$i\b/${items[$i]}/g"
done
git cl format
[1] - https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature
Bug: None
Change-Id: I5ae191e3046caf347aeee01554d5743548ab0e3f
Reviewed-on: https://webrtc-review.googlesource.com/c/118701
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26494}
2019-01-31 13:23:33 +00:00
733e087e63
Ignore duplicated incoming RTCP packets in RTC event log parser.
...
Bug: webrtc:8111
Change-Id: I1082ff66cac9c3744811713d686b3d7f85bd7584
Reviewed-on: https://webrtc-review.googlesource.com/c/120200
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Peter Slatala <psla@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26430}
2019-01-28 20:38:38 +00:00
739baf097b
[clang-tidy] Apply performance-for-range-copy fixes.
...
This CL applies clang-tidy's performance-for-range-copy [1] on the
WebRTC codebase.
All changes in this CL are automatically generated by both clang-tidy
and 'git cl format'.
[1] - https://clang.llvm.org/extra/clang-tidy/checks/performance-for-range-copy.html
Bug: webrtc:10215
Change-Id: I7c83290b8866d76129bbec4e24e6701f5014102e
Reviewed-on: https://webrtc-review.googlesource.com/c/120043
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26420}
2019-01-28 09:53:50 +00:00
f380284035
(7) Rename files to snake_case: remove forwarding headers
...
Bug: webrtc:10159
Change-Id: I2ba899e0283b953538c7941c8790213e36d7c70e
Reviewed-on: https://webrtc-review.googlesource.com/c/118561
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Steve Anton <steveanton@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26417}
2019-01-26 00:33:46 +00:00
d970807e0c
Remove rtc_base/scoped_ref_ptr.h.
...
The type rtc::scoped_refptr<T> is now part of api/. Please include it from
api/scoped_refptr.h.
More info: See: https://groups.google.com/forum/#!topic/discuss-webrtc/Mme2MSz4z4o .
Bug: webrtc:9887, webrtc:8205
No-Try: True
Change-Id: Ic6c7c81e226e59f12f7933e472f573ae097b55bf
Reviewed-on: https://webrtc-review.googlesource.com/c/119041
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26414}
2019-01-25 20:29:58 +00:00
18f65dc20a
Don't attempt to unwrap RTP timestamps for RTX stream.
...
This fixes a bug where the event_log_visualizer hits a DCHECK when the RTP timestamp jumps.
TBR = kwiberg
Bug: webrtc:10170
Change-Id: I127a8e6165265d0726892a912f5bcdc33d98ced5
Reviewed-on: https://webrtc-review.googlesource.com/c/119664
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26410}
2019-01-25 15:59:22 +00:00
3770b99e64
Allow repeated feedback packets in log parser.
...
Bug: webrtc:10170
Change-Id: I68cf729aa92b1266868f6ebcb211d9d4af031176
Reviewed-on: https://webrtc-review.googlesource.com/c/119300
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26392}
2019-01-24 14:29:15 +00:00
84ca69ad6e
Add RTC event logging of LossNotification RTCP messages
...
Bug: webrtc:10226
Change-Id: Ib65970a8f13cd64529f3101993d40887168e313e
Reviewed-on: https://webrtc-review.googlesource.com/c/118933
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26391}
2019-01-24 13:33:57 +00:00
f8e7ccb967
Create new RTCP feedback message - LossIndication
...
Create a new RTCP feedback message for reporting the loss and/or non-decodability of video frames, to be used by the upcoming injectable VideoFrameBufferController. The new feedback message should report:
1. The sequence number of the last decoded non-discardable video frame. (TBD: If a multi-packet frame, should it be the sequence number of the first, last, or any of the packets?)
2. The sequence number of the last received RTP packet in the stream.
3. A decodability flag, whose specific meaning depends on the last-received
RTP sequence number. The decodability flag is true if and only if all of
the frame's dependencies are known to be decodable, and the frame itself
is not yet known to be unassemblable.
* Clarification #1 : In a multi-packet frame, the first packet's
dependencies are known, but it is not yet known whether all parts
of the current frame will be received.
* Clarification #2 : In a multi-packet frame, the dependencies would be
unknown if the first packet was not received. Then, the packet will
be known-unassemblable.
Bug: webrtc:10226
Change-Id: I1563c944477e3ed40235e82ab99a439414632aff
Reviewed-on: https://webrtc-review.googlesource.com/c/118931
Commit-Queue: Elad Alon <eladalon@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26387}
2019-01-24 12:21:00 +00:00
7e4341db60
Reland "Reland "Adds richer packet and ice processing to ParsedRtcEventLog.""
...
This is a reland of 6fc6a0cbb10ee0e988b47f48935b630ba41d109d
Original change's description:
> Reland "Adds richer packet and ice processing to ParsedRtcEventLog."
>
> This is a reland of 4306a25dfcaba7defe09f5d4b669736d374fe985
>
> Original change's description:
> > Adds richer packet and ice processing to ParsedRtcEventLog.
> >
> > Bug: webrtc:10170
> > Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000
> > Reviewed-on: https://webrtc-review.googlesource.com/c/116069
> > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#26268}
>
> Bug: webrtc:10170
> Change-Id: Ie523427acba02b554583223b9ef800249d8d8f2b
> Reviewed-on: https://webrtc-review.googlesource.com/c/117724
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26350}
Bug: webrtc:10170
Change-Id: I9b57ca754197822de9966ee4c93526c7f2159dfd
Reviewed-on: https://webrtc-review.googlesource.com/c/118784
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26362}
2019-01-23 10:00:01 +00:00
71b5a7df77
Revert "Reland "Adds richer packet and ice processing to ParsedRtcEventLog.""
...
This reverts commit 6fc6a0cbb10ee0e988b47f48935b630ba41d109d.
Reason for revert: Incorrect DCHECK
Original change's description:
> Reland "Adds richer packet and ice processing to ParsedRtcEventLog."
>
> This is a reland of 4306a25dfcaba7defe09f5d4b669736d374fe985
>
> Original change's description:
> > Adds richer packet and ice processing to ParsedRtcEventLog.
> >
> > Bug: webrtc:10170
> > Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000
> > Reviewed-on: https://webrtc-review.googlesource.com/c/116069
> > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#26268}
>
> Bug: webrtc:10170
> Change-Id: Ie523427acba02b554583223b9ef800249d8d8f2b
> Reviewed-on: https://webrtc-review.googlesource.com/c/117724
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26350}
TBR=terelius@webrtc.org ,srte@webrtc.org
Change-Id: I5a8ef5cf4d4dab783482ef4968b3a832b805d759
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10170
Reviewed-on: https://webrtc-review.googlesource.com/c/118783
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26351}
2019-01-22 07:39:05 +00:00
6fc6a0cbb1
Reland "Adds richer packet and ice processing to ParsedRtcEventLog."
...
This is a reland of 4306a25dfcaba7defe09f5d4b669736d374fe985
Original change's description:
> Adds richer packet and ice processing to ParsedRtcEventLog.
>
> Bug: webrtc:10170
> Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000
> Reviewed-on: https://webrtc-review.googlesource.com/c/116069
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26268}
Bug: webrtc:10170
Change-Id: Ie523427acba02b554583223b9ef800249d8d8f2b
Reviewed-on: https://webrtc-review.googlesource.com/c/117724
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26350}
2019-01-21 19:47:38 +00:00
05acd2b76f
Removes clock from TransportFeedbackAdapter.
...
Instead timestamps required for processing are provided explicitly.
This makes it easier to ensure correct usage in log processing
and simulation.
Bug: webrtc:10170
Change-Id: I724a6b9b94e83caa22b8e43b63ef4e6b46138e6a
Reviewed-on: https://webrtc-review.googlesource.com/c/118702
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26339}
2019-01-21 12:55:00 +00:00
5c2f1f053f
Add some missing includes and dependencies.
...
In particular, time_utils.h is currently pulled in via rtc_event.h
This CL is in preparation of moving parts of the RTC event log to api/.
Bug: webrtc:10206
Change-Id: Idd35aa9404afded4d29b1296344996c45b8c2e91
Reviewed-on: https://webrtc-review.googlesource.com/c/117921
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26326}
2019-01-18 15:30:26 +00:00
85989c4490
Remove unused friend declaration from ParsedRtcEventLog.
...
Bug: NONE
Change-Id: I987f13807a7aece16e88e9ff1c5b443b0213c488
Reviewed-on: https://webrtc-review.googlesource.com/c/118181
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Zach Stein <zstein@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26310}
2019-01-18 06:57:42 +00:00
4a7b3acfcf
Add DTLSTransport info into sender/receiver state.
...
This is in preparation for letting Chrome extract DTLSTransport
information after SLD/SRD instead of doing it on-demand.
Bug: chromium:907849
Change-Id: Iac6b174c98d3d14136e1fd25bce4a9292f6c8b41
Reviewed-on: https://webrtc-review.googlesource.com/c/116984
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26289}
2019-01-17 10:21:32 +00:00
876d1d3fed
Revert "Reland "Adds richer packet and ice processing to ParsedRtcEventLog.""
...
This reverts commit 20aae1de5c745fd62025e3464f736416c849e270.
Reason for revert: Accidental revert.
Original change's description:
> Reland "Adds richer packet and ice processing to ParsedRtcEventLog."
>
> This reverts commit 5586d7fb5717fd772463c17a4675491980c5d017.
>
> Reason for revert: <INSERT REASONING HERE>
>
> Original change's description:
> > Revert "Adds richer packet and ice processing to ParsedRtcEventLog."
> >
> > This reverts commit 4306a25dfcaba7defe09f5d4b669736d374fe985.
> >
> > Reason for revert: Breaks downstream project
> >
> > Original change's description:
> > > Adds richer packet and ice processing to ParsedRtcEventLog.
> > >
> > > Bug: webrtc:10170
> > > Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000
> > > Reviewed-on: https://webrtc-review.googlesource.com/c/116069
> > > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > > Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> > > Cr-Commit-Position: refs/heads/master@{#26268}
> >
> > TBR=terelius@webrtc.org ,srte@webrtc.org
> >
> > Change-Id: Ic50fdfb6b10c26e77728b594f553bc4aac4eb0ab
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: webrtc:10170
> > Reviewed-on: https://webrtc-review.googlesource.com/c/117780
> > Reviewed-by: Amit Hilbuch <amithi@webrtc.org >
> > Commit-Queue: Amit Hilbuch <amithi@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#26270}
>
> TBR=terelius@webrtc.org ,srte@webrtc.org ,amithi@webrtc.org
>
> Change-Id: I5e87fb472b91dd4b6fa177418f03a9031035ec60
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10170
> Reviewed-on: https://webrtc-review.googlesource.com/c/117721
> Reviewed-by: Sebastian Jansson <srte@webrtc.org >
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26274}
TBR=terelius@webrtc.org ,srte@webrtc.org ,amithi@webrtc.org
Change-Id: Ie020006b02dda628c638ba00ac519f6da2aaa090
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10170
Reviewed-on: https://webrtc-review.googlesource.com/c/117723
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26275}
2019-01-16 08:26:37 +00:00
20aae1de5c
Reland "Adds richer packet and ice processing to ParsedRtcEventLog."
...
This reverts commit 5586d7fb5717fd772463c17a4675491980c5d017.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Revert "Adds richer packet and ice processing to ParsedRtcEventLog."
>
> This reverts commit 4306a25dfcaba7defe09f5d4b669736d374fe985.
>
> Reason for revert: Breaks downstream project
>
> Original change's description:
> > Adds richer packet and ice processing to ParsedRtcEventLog.
> >
> > Bug: webrtc:10170
> > Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000
> > Reviewed-on: https://webrtc-review.googlesource.com/c/116069
> > Reviewed-by: Björn Terelius <terelius@webrtc.org >
> > Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#26268}
>
> TBR=terelius@webrtc.org ,srte@webrtc.org
>
> Change-Id: Ic50fdfb6b10c26e77728b594f553bc4aac4eb0ab
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10170
> Reviewed-on: https://webrtc-review.googlesource.com/c/117780
> Reviewed-by: Amit Hilbuch <amithi@webrtc.org >
> Commit-Queue: Amit Hilbuch <amithi@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26270}
TBR=terelius@webrtc.org ,srte@webrtc.org ,amithi@webrtc.org
Change-Id: I5e87fb472b91dd4b6fa177418f03a9031035ec60
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10170
Reviewed-on: https://webrtc-review.googlesource.com/c/117721
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26274}
2019-01-16 07:44:23 +00:00
5586d7fb57
Revert "Adds richer packet and ice processing to ParsedRtcEventLog."
...
This reverts commit 4306a25dfcaba7defe09f5d4b669736d374fe985.
Reason for revert: Breaks downstream project
Original change's description:
> Adds richer packet and ice processing to ParsedRtcEventLog.
>
> Bug: webrtc:10170
> Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000
> Reviewed-on: https://webrtc-review.googlesource.com/c/116069
> Reviewed-by: Björn Terelius <terelius@webrtc.org >
> Commit-Queue: Sebastian Jansson <srte@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#26268}
TBR=terelius@webrtc.org ,srte@webrtc.org
Change-Id: Ic50fdfb6b10c26e77728b594f553bc4aac4eb0ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:10170
Reviewed-on: https://webrtc-review.googlesource.com/c/117780
Reviewed-by: Amit Hilbuch <amithi@webrtc.org >
Commit-Queue: Amit Hilbuch <amithi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26270}
2019-01-15 21:58:02 +00:00
4306a25dfc
Adds richer packet and ice processing to ParsedRtcEventLog.
...
Bug: webrtc:10170
Change-Id: I0f10a8c0b5656917a806cf0f3ad88b7a6baee000
Reviewed-on: https://webrtc-review.googlesource.com/c/116069
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Sebastian Jansson <srte@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26268}
2019-01-15 16:30:38 +00:00
aec15aa810
(5) Rename files to snake_case: install forwarding headers
...
Mechanically generated with this command:
tools_webrtc/do-renames.sh install all-renames.txt && git cl format
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ic8e99f71f2da62e5c99863c6d24a8cfe311466cd
Reviewed-on: https://webrtc-review.googlesource.com/c/115682
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26227}
2019-01-11 17:13:36 +00:00
10542f21c8
(4) Rename files to snake_case: update BUILD.gn, include paths, header guards, and DEPS entries
...
Mechanically generated by running this command:
tools_webrtc/do-renames.sh update all-renames.txt && git cl format
Then manually updating:
tools_webrtc/sanitizers/tsan_suppressions_webrtc.cc
Bug: webrtc:10159
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I54824cd91dada8fc3ee3d098f971bc319d477833
Reviewed-on: https://webrtc-review.googlesource.com/c/115653
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#26226}
2019-01-11 17:11:39 +00:00
