582ffe27df
Take out the RTCPSender object under test from the test fixture
...
Intended to make it easier to write tests varying the
construction-time settings.
Bug: None
Change-Id: I397beee8f7ab48c79ecd095d7e8486f93f9d9b17
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195544
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32727}
2020-12-01 10:24:31 +00:00
6562109fc9
test: do not consider flexfec-03 a normal codec
...
BUG=None
Change-Id: I5d3720202893d73d467aac0288bc5fdef52f79e8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194262
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32726}
2020-12-01 10:23:26 +00:00
9a12ee5d37
Use frame rate in video overhead calculation.
...
Assume bitrate is evenly distributed between frames. This is wrong for
uneven frame sizes and will underestimate the overhead for simulcast.
However, it will be more correct than the current calculation,
especially for low bitrates when each frame is smaller than one packet.
This is also when overhead matters more since it is a larger fraction
of the total bitrate.
It is also unclear what will happen when using FEC.
Bug: b/166341943
Change-Id: I247b9d0fc7a8ad5daa9b577f55ec16c56efa34c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195221
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32725}
2020-12-01 09:42:40 +00:00
a420547865
modules/video_processing: replace copy memory with libyuv::CopyPlane
...
Bug: None
Change-Id: I4c41117028a6602e8d2cb627868d015422ef0b15
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195487
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Zhaoliang Ma <zhaoliang.ma@intel.com >
Cr-Commit-Position: refs/heads/master@{#32724}
2020-12-01 07:24:43 +00:00
b3f1e0fdb4
Roll chromium_revision 8bf715889f..5e6f1ed54f (832086:832199)
...
Change log: 8bf715889f..5e6f1ed54f8bf715889f..5e6f1ed54f4d009acb79..565c3b737374e52e7a7d..39ee8199e6a5c3e28696..e021e5ce31ab5649e834..8a83254bed39e687569f..6815222c2ahttps://chromium.googlesource.com/catapult.git/+log/146912bb62..5537c03942
* src/third_party/depot_tools: f819411f2a..1af7968d68f37338cdaa..42433abb959275bac201..7bbeac34808bf715889f..5e6f1ed54fTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ic41536b2421a91d0ddc69d955695228341d82eb2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196002
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32723}
2020-12-01 04:41:43 +00:00
9b0f2b30e5
Roll chromium_revision d28771013b..8bf715889f (831953:832086)
...
Change log: d28771013b..8bf715889fd28771013b..8bf715889fa4bd1d8b3b..4d009acb79c044db6dfd..74e52e7a7ddae1ac764d..a5c3e286966daf6d0b50..ab5649e8346ab48759c4..39e687569feb386eb3d2..f819411f2a3f45fb86ac..9275bac201d28771013b..8bf715889fTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I6b12e521bb7f7a3ec80cb94f4b5b1288f5b28283
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/196020
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32722}
2020-12-01 00:57:22 +00:00
3704603cc0
Roll chromium_revision d99eda17c0..d28771013b (831830:831953)
...
Change log: d99eda17c0..d28771013bd99eda17c0..d28771013bba32a25741..a4bd1d8b3b3328d0bdee..c044db6dfdb7dec422d2..dae1ac764d08db542028..6daf6d0b50cf672b2448..6ab48759c4dc7b108da6..eb386eb3d23692ffb6a3..3f45fb86acd99eda17c0..d28771013bTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ib1c08777cd31e10f7d6f5030edd8499835d9caef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195980
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32721}
2020-11-30 21:07:21 +00:00
83a5a20afe
Roll chromium_revision 6afe1bbaba..d99eda17c0 (831717:831830)
...
Change log: 6afe1bbaba..d99eda17c06afe1bbaba..d99eda17c084b4ee8c94..ba32a25741425e151f06..3328d0bdeeeef3a69f73..b7dec422d288c7098f26..08db5420280ece487b4a..cf672b2448https://chromium.googlesource.com/catapult.git/+log/7598272651..146912bb62
* src/tools: bdd6677946..3692ffb6a36afe1bbaba..d99eda17c0TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ia13808de69417efddb7a37f59200fa92586553c8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195900
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32720}
2020-11-30 14:33:21 +00:00
41774435f3
Roll chromium_revision 4559b6b576..6afe1bbaba (831617:831717)
...
Change log: 4559b6b576..6afe1bbaba4559b6b576..6afe1bbaba788e3c7e90..84b4ee8c94e1db346d5d..425e151f06112ad8ea26..88c7098f26cdcbc294eb..0ece487b4a6cdb496e99..f37338cdaa2a1184f6a0..bdd66779464559b6b576..6afe1bbaba4559b6b576..6afe1bbabaTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: If8173977e86b60d47e314d467446796f3521c205
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195740
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32719}
2020-11-29 10:24:08 +00:00
347dc75cb5
Roll chromium_revision 3e0e8c532b..4559b6b576 (831500:831617)
...
Change log: 3e0e8c532b..4559b6b5763e0e8c532b..4559b6b57691a7c0ba49..788e3c7e90169d15ccdb..e1db346d5dd13be65165..eef3a69f73913fc377e5..112ad8ea262336f7db95..cdcbc294ebhttps://chromium.googlesource.com/catapult.git/+log/ae003f552e..7598272651
* src/third_party/freetype/src: 3facafa44e..56c610b145254ea334b6..6cdb496e99920424e54d..2a1184f6a03e0e8c532b..4559b6b576TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I013cb313d20d3b997558b1a9d0c9ddba94106429
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195640
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32718}
2020-11-27 18:27:58 +00:00
4e702169e4
Break RtpFrameReferenceFinder into descriptor specific parts.
...
This CL breaks out descriptor specific parts into separate classes. All logic in the newly added classes is just copy pasted from the (previously massive) RtpFrameReferenceFinder with the exception of how frames are being returned, which is now done via return value rather than a callback. Basically, all interesting changes have been made in the RtpFrameReferenceFinder.
Bug: webrtc:12221
Change-Id: I5f958d2fbf4b77ba11c3c6c01d8d0d80e325be60
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195448
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32717}
2020-11-27 17:59:28 +00:00
e99b6ccb9b
Build and run iOS tests as XCTests.
...
After upgrading to xcode 12, some Gtest tests have started to randomly
fail. The solution around this problem is to build and run GTests as
XCTests.
In order to achieve that, the CL sets enable_run_ios_unittests_with_xctest
to true in all iOS builds and adds a dependency on
//base/test:google_test_runner for each Gtest that needs to run as an
XCTest.
Real XCTest don't need the dependency and they are marked with the
rtc_test() argument `is_xctest=true` (apprtcmobile_tests, sdk_unittests
and sdk_framework_unittests).
This CL is based on [1] which passes --xctest to the runner and uses
--undefok to avoid to crash when absl/flags doesn't recognize the
flag --enable-run-ios-unittests-with-xctest (absl/flags cannot have "-"
in flags so WebRTC binaries cannot define that flag). To workaround the
issue, WebRTC tests always behave like
--enable-run-ios-unittests-with-xctest is always set (by linking only
with //base/test:google_test_runner to run iOS tests).
This fixes iOS12 and iOS13 tests but not iOS14 on which some tests
are failing because of restricted access to resources (this will be
addressed in another CL).
Long term, this solution might cause problems when Chromium decides
to update test() GN template and/or the test launcher, so WebRTC should
plan a better integration with Chromium's iOS infra.
[1] - https://chromium-review.googlesource.com/c/chromium/tools/build/+/2550656
Bug: webrtc:12134
Change-Id: I24c731dee0310e02ae1bbe6c23d359d6fcd18f17
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193620
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32716}
2020-11-27 15:39:58 +00:00
bcca3b08a9
Improve dashboard upload script so the errors are more understandable
...
No-Presubmit: True
Bug: None
Change-Id: I2bc297fddacd33037a7c77107d653da87dd2737e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195560
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32715}
2020-11-27 15:26:58 +00:00
cde4a9f669
Enable initial frame drop for SVC 'singlecast'
...
Bug: none
Change-Id: Ideda726f4f7df5e92556048a199cda06261e76b4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195542
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32714}
2020-11-27 14:08:45 +00:00
4005e5abb8
Add av1 svc configuration for target bitrates
...
This configuration mostly copies vp9 configuration for regular video,
but is done separately to allow tune av1 svc bitrates independently of vp9.
Bug: webrtc:12148
Change-Id: Icd11817ada8f9b6135ee2da57204eadb50de3954
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195329
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32713}
2020-11-27 13:32:05 +00:00
faaaa87960
Remember the proxies
...
CL that should have been part of CL 195541
Bug: webrtc:12238
Change-Id: I3ab7a7a5f0d0bfdbc00904a01444acda02d49e90
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195543
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32712}
2020-11-27 12:51:54 +00:00
cd982137df
Add missing RTC_GUARDED_BY for ModuleRtpRtcpImpl::rtt_ms_
...
Bug: None
Change-Id: I7aef516e4310a7ff14a8bbc77c6edd488167d18d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195338
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32711}
2020-11-27 12:34:04 +00:00
a3dd772e7a
Add create function for PeerConnection that can return an error.
...
Needed in order to return different codes for different failures
in initialization.
Sideswipe: Check TURN URL hostnames for illegal characters.
Bug: webrtc:12238
Change-Id: I1af3a37b9654b83b268304f7356049f9f3786b7a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195541
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32710}
2020-11-27 11:08:10 +00:00
c22ac1cc60
Roll chromium_revision f23bf936d4..3e0e8c532b (831394:831500)
...
Change log: f23bf936d4..3e0e8c532bf23bf936d4..3e0e8c532bd2743375b0..91a7c0ba49137860baa5..169d15ccdbe8599b61a2..d13be65165360b2e3bb7..913fc377e50d743431a0..2336f7db95e62621d2eb..dc7b108da68f8e2dc7d5..254ea334b69b7a11904f..920424e54df23bf936d4..3e0e8c532bTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Id3dafcf7cf351a8add036acc5d3110b7fa8725b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195521
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32709}
2020-11-27 08:43:57 +00:00
569b76077d
Roll chromium_revision 2b2c6f2767..f23bf936d4 (831266:831394)
...
Change log: 2b2c6f2767..f23bf936d42b2c6f2767..f23bf936d4c6c9d2c2f8..d2743375b07b7e25e69c..137860baa5c789d359b1..e8599b61a2c3ae330521..360b2e3bb78a8f008fc4..0d743431a0c39ab82c90..53806e5b8395cd40e44f..9b7a11904f2b2c6f2767..f23bf936d4TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Iceb8fe6655401bc5b3755350ca97e1d67268e60d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195405
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32708}
2020-11-26 18:25:55 +00:00
84bc34841b
Reset initial frame dropper if the stream changes for external reasons
...
External reasons here are simulcast configuration and
source resolution change.
Initial frame dropper should be enabled in these cases because the
client can request way too big resolution for available bitrate and
usual quality scaling would take too long.
Bug: none
Change-Id: I02fbbd3c15b53b39672c083c2a1f9a780256c507
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195004
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32707}
2020-11-26 17:39:45 +00:00
d3811947e6
Adjust min bitrate for the first active stream
...
Without this change, if the user disables QVGA and VGA streams via |active|
flags in SetParamters, the resulting stream would have too high min bitrate.
This would lead to bad performance and low quality adaptation rate.
Bug: none
Change-Id: I919a30bfb248c06747c989afe6965b3afaef2260
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195325
Reviewed-by: Åsa Persson <asapersson@webrtc.org >
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32706}
2020-11-26 17:36:45 +00:00
27883a2593
Annotate cricket::BaseChannel with thread guards
...
This CL also adds commentary to member variables that couldn't be guarded
because they're accessed from multiple threads.
Bug: webrtc:12230
Change-Id: I5193a7ef36ab25588c76ee6a1863de6a844be1dc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195331
Reviewed-by: Tommi <tommi@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32705}
2020-11-26 13:30:59 +00:00
0d863f72a8
Cleanup of bwe_defines.h
...
Delete unused macros BWE_MIN and BWE_MAX.
Move enum RateControlState: Make it a private enum class in
AimdRateControl, the only user.
Change users of the header file that only need BandwidthUsage, to
instead include api/network_state_predictor.h, the file defining this
class. As a result, fewer dependencies on
modules/remote_bitrate_estimator.
Bug: None
Change-Id: I4450c79dd58e1875d64dd74d1ae2cb7d911a14b3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195222
Reviewed-by: Sebastian Jansson <srte@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32704}
2020-11-26 12:26:02 +00:00
e57eb34a40
Make the remote_bitrate_estimator build target private
...
Bug: webrtc:9808
Change-Id: I6f0c23841bbdc2999505b89888cf261c31536408
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194330
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32703}
2020-11-26 12:21:22 +00:00
b7d89ca0d3
Move iOS noise suppression override to default settings
...
Bug: None
Change-Id: I2cd642dd29a9b5e7e6141a54609b95318eb7fc85
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195442
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32702}
2020-11-26 12:04:42 +00:00
7b463c5f67
Add a "Smart flushing" feature to NetEq.
...
Instead of flushing all packets, it makes sense to flush down to the target level instead. This CL also initiates a flush when the packet buffer is a multiple of the target level, instead of waiting until it is completely full.
Bug: webrtc:12201
Change-Id: I8775147624536824eb88752f6e8ffe57ec6199cb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193941
Commit-Queue: Ivo Creusen <ivoc@webrtc.org >
Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32701}
2020-11-26 11:20:28 +00:00
54b91412de
CallbackList: Add support for removing receivers
...
Bug: webrtc:11943
Change-Id: I7a646729dd1e4f5abe20900412f4105414e1a98f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195332
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Karl Wiberg <kwiberg@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32700}
2020-11-26 08:41:36 +00:00
d174d370fe
Only call balanced_settings_.CanAdaptUpResolution if DegradationPreference::BALANCED.
...
Bug: none
Change-Id: If76a3413bfdf359f79d94691b841d4056d91a80b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195327
Reviewed-by: Evan Shrubsole <eshr@google.com >
Commit-Queue: Åsa Persson <asapersson@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32699}
2020-11-26 08:27:56 +00:00
c9a09859fc
Calculate writable state over both RTP and RTCP
...
Patch from andrey.semashev@gmail.com
Bug: webrtc:9424
Change-Id: I5f1378bbd9c7c371a3136b97edb5faa7d1127a82
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191760
Reviewed-by: Taylor <deadbeef@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32698}
2020-11-26 06:39:26 +00:00
b1f929cd8f
Roll chromium_revision 81d25031cb..2b2c6f2767 (831145:831266)
...
Change log: 81d25031cb..2b2c6f276781d25031cb..2b2c6f2767c8f17e4b6c..c6c9d2c2f8497b80f82b..7b7e25e69c23e9a490b2..c789d359b18b5a74302a..c3ae3305211ac02eb79d..8a8f008fc4a3762a907c..e62621d2eb68a7a727b0..95cd40e44f81d25031cb..2b2c6f2767TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ic6358d9bb4fa837799e48f4e0f01729580d8b090
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195420
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32697}
2020-11-26 06:37:46 +00:00
9d269408a4
Set TCP_NODELAY socket option before calling connect.
...
Setting the option after calling connect but before the socket is
connected fails in some circumstances on Windows, while setting it
before connecting always succeeds. That's what Chrome is doing;
TCPClientSocket::OpenSocket calls SetDefaultOptionsForClient (which
sets TCP_NODELAY) right after opening the socket.
Also, start logging errors, and storing last error when setsockopt
fails.
Bug: webrtc:12217
Change-Id: I169d52e31b50e54e5bc93ff3590bae656cacb2b2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195060
Commit-Queue: Taylor <deadbeef@webrtc.org >
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org >
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32696}
2020-11-26 01:00:22 +00:00
b6b599fc58
Roll chromium_revision a100f65b87..81d25031cb (831018:831145)
...
Change log: a100f65b87..81d25031cba100f65b87..81d25031cbf124b5128c..c8f17e4b6c542fd4cc32..497b80f82ba0caffcc89..23e9a490b25e0e3a4847..8b5a74302acf03144f3c..1ac02eb79d36e6ccfc77..68a7a727b0a100f65b87..81d25031cbTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Id180ee321d9651ef0e8c8223af74961c0c86b12a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195380
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32695}
2020-11-25 22:58:37 +00:00
0332921bcf
Roll chromium_revision 8f4e430afe..a100f65b87 (830890:831018)
...
Change log: 8f4e430afe..a100f65b878f4e430afe..a100f65b87b97e8e9f67..f124b5128c66f22dbb61..542fd4cc326b6c35d642..a0caffcc8970017627a0..5e0e3a4847c2e20c4073..cf03144f3c8820ab859b..a3762a907c5abd252a0a..3facafa44e9419fdea06..36e6ccfc778f4e430afe..a100f65b87TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I53b1a82381e0ff44e70510f76e563eb3f05fbc20
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195362
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32694}
2020-11-25 16:31:01 +00:00
0db3396646
Log VideoSendStreamImpl::Stop in logs
...
Removes confusion in the logs because both VideoSendStream and
VideoSendStreamImpl use the same log line.
Bug: None
Change-Id: Id9e22f23341e134667ab5f8e308732c836ab213d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195328
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@google.com >
Cr-Commit-Position: refs/heads/master@{#32693}
2020-11-25 15:01:51 +00:00
9a5e21da68
in Vp8 encoder fill resolution into codec agnostic structure
...
so that it will be filled in the dependency descriptor rtp header extension
Bug: webrtc:10342
Change-Id: Ifaf4963ca84f6d495287959746686ae3dcd176d8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168767
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32692}
2020-11-25 12:49:51 +00:00
b6b678d0f8
Revert "Filter out NaNs before uploading to the dasboard"
...
This reverts commit 9db3ab201ec73d5bbc547ebe2701b4695d1e281f.
Reason for revert: We shouldn't delete numbers from "running", since they represent count, mean, max, min, sum, variance and meanlogs. Just removing will lead to undefined behaviur.
Original change's description:
> Filter out NaNs before uploading to the dasboard
>
> No-Presubmit: True
> Bug: webrtc:12224
> Change-Id: I48a140f08276362491650496f63a23727c56fa6e
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195320
> Commit-Queue: Andrey Logvin <landrey@webrtc.org >
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#32690}
TBR=mbonadei@webrtc.org ,landrey@webrtc.org
Change-Id: If2b0bd5046d040b8289eefd22e313ce554b98bff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:12224
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195323
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32691}
2020-11-25 10:34:14 +00:00
9db3ab201e
Filter out NaNs before uploading to the dasboard
...
No-Presubmit: True
Bug: webrtc:12224
Change-Id: I48a140f08276362491650496f63a23727c56fa6e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195320
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32690}
2020-11-25 10:16:41 +00:00
8d87e6d1de
Roll chromium_revision 10f5691657..8f4e430afe (830729:830890)
...
Change log: 10f5691657..8f4e430afe10f5691657..8f4e430afed7b600503c..66f22dbb61def37292b7..6b6c35d64209a6bc8c68..70017627a0b19108a932..c2e20c4073https://chromium.googlesource.com/catapult.git/+log/a629d81faa..ae003f552e
* src/third_party/depot_tools: 4c5dd5d863..8820ab859bb0a18bc755..11cce5c2872a1d77f099..9419fdea0610f5691657..8f4e430afeTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I3625db8439e59a588235353fc91ff645b418471d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195300
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32689}
2020-11-25 07:07:50 +00:00
bafeede2b5
Roll chromium_revision fed88f41ed..10f5691657 (830583:830729)
...
Change log: fed88f41ed..10f5691657fed88f41ed..10f5691657df7d1bcfe2..b97e8e9f670b7bec4032..d7b600503cc22e99448e..def37292b7ae656081dc..09a6bc8c681f137efbc1..b19108a932b35dd76cd5..4c5dd5d863880674d483..2a1d77f099fed88f41ed..10f5691657TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I25a5021f0f591a889d735ac22ccee4cb0f5876c3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195280
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32688}
2020-11-24 22:39:24 +00:00
1620db743e
Roll chromium_revision acfa5a0113..fed88f41ed (830473:830583)
...
Change log: acfa5a0113..fed88f41edacfa5a0113..fed88f41ed67efd05620..df7d1bcfe2356ef25e24..0b7bec4032feae45c075..c22e99448e9b8961da57..1f137efbc1260eb0f662..b35dd76cd5d28bf829ec..880674d483acfa5a0113..fed88f41edTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I251b329a2677ea78a165ee3dd03949de83f090e2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195240
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32687}
2020-11-24 16:44:48 +00:00
25767f7c3f
Fix timout message while uploading to the dashboard
...
No-Presubmit: True
Bug: webrtc:12223
Change-Id: I8991962f6ec7fbf92ce6a90561e8438452ed632c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195220
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32686}
2020-11-24 15:56:08 +00:00
659d7015db
Replace all infinity values before uploading to the dashoard
...
No-Presubmit: True
Bug: webrtc:12224
Change-Id: I4a7a33bedb5449d7e36293e0c6f47e9cd4d0235a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195200
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32685}
2020-11-24 15:19:56 +00:00
a62fa7378f
Removed unused H264 specific code from RtpFrameReferenceFinder.
...
Bug: webrtc:12221
Change-Id: I238ad9c0cb53720a91e0722d61d1704586b56398
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195005
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32684}
2020-11-24 13:51:36 +00:00
3f77eb468f
fixing build for when HAVE_WEBRTC_VIDEO is not defined
...
In that configuration HAVE_WEBRTC_VIDEO is not defined so null_webrtc_video_engine.h gets included which unlike the real one does not include a required header.
Bug: webrtc:11926, webrtc:12187
Change-Id: I3f9df7a841ea6d9920dcb5b39a7386946c9e4341
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/193784
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32683}
2020-11-24 11:14:26 +00:00
bce02a9467
Fix authentication error while polling for upload results
...
I'm not 100% sure that is the reason. But I think it worth trying.
No-Presubmit: True
Bug: webrtc:12223
Change-Id: Idc6a9006ce2e3c6d299ad56cd747faebfeff37ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195003
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Andrey Logvin <landrey@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32682}
2020-11-24 10:37:16 +00:00
47a03e8743
Default enable sending transport sequence numbers on audio packets.
...
This enables send side bandwidth estimation for audio and removes field
trial "WebRTC-Audio-SendSideBwe" which this was controlled through.
Transport-cc extension still needs to be negotiated.
Bug: webrtc:12222
Change-Id: Ie2268fad13703eeb0f0d38fcf484baaa29715b7c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194142
Reviewed-by: Stefan Holmer <stefan@webrtc.org >
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#32681}
2020-11-24 09:19:54 +00:00
d840c8fb5d
Roll chromium_revision d375f99a80..acfa5a0113 (830370:830473)
...
Change log: d375f99a80..acfa5a0113d375f99a80..acfa5a011302e8075499..67efd05620e0140a0715..356ef25e2475ae34f793..feae45c0754dd6336ef5..ae656081dc6b15032a46..9b8961da57a373192bc2..d28bf829ecd375f99a80..acfa5a0113TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I154f9629662690349a149e416b18ee1207d7496a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195120
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32680}
2020-11-24 07:07:06 +00:00
c1f5aaac58
Roll chromium_revision 45755197db..d375f99a80 (830233:830370)
...
Change log: 45755197db..d375f99a8045755197db..d375f99a801b2111b9c2..02e80754996d81571a4b..e0140a0715a1a49e1c65..75ae34f793b066b8030e..6b15032a46https://chromium.googlesource.com/catapult.git/+log/844c1542a1..a629d81faa
* src/third_party/depot_tools: 9c0dc3026e..260eb0f6627db579a73a..6a33b647c0df81dcc2d6..a373192bc245755197db..d375f99a80TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ie5025dbae693f57effd785a830e5a58b9de7a379
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/195080
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32679}
2020-11-24 00:42:51 +00:00
2c73a92305
Roll chromium_revision ef9a6dff92..45755197db (830132:830233)
...
Change log: ef9a6dff92..45755197dbef9a6dff92..45755197db95868d5178..1b2111b9c2fe03ecff2c..6d81571a4b36e0416857..a1a49e1c655da61f6a14..4dd6336ef50eac02dab6..b066b8030ehttps://chromium.googlesource.com/catapult.git/+log/cb4bb2088a..844c1542a1
* src/tools: 28d6892464..df81dcc2d6ef9a6dff92..45755197dbTBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I112aee00817ad760f030b197ab18bce031b93652
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/194981
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#32678}
2020-11-23 18:32:45 +00:00
