1cdbabde53
WgcCaptureSession would crash when copying the frame data for an image from a portrait oriented monitor. This is because we were using the height of the image multiplied by the rowpitch of the buffer to determine the size of the data to be copied. However, in portrait mode the height measures the same dimension as the rowpitch, leading to us overrunning the frame buffer. The fix is to use the height and width of the image multiplied by the number of bytes per pixel to determine how much data to copy out of the buffer, and only use the rowpitch to advance the pointer in the source data buffer. This has the added benefit of giving us contiguous data, reducing the size of the DesktopFrame that we output. Bug: webrtc:12490 Change-Id: I4c26f8864cb57ac566a742af70fea1da504b9706 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/209501 Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Austin Orion <auorion@microsoft.com> Cr-Commit-Position: refs/heads/master@{#33532}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: http://build.chromium.org/p/client.webrtc
- Coding style guide
- Code of conduct
- Reporting bugs