50a0b1219e
When a socket is shutting down, either explicitly by the ULP calling Shutdown(), or when the socket receives a SHUTDOWN chunk, the socket should send all outstanding data and when all is sent and acked, _then_ it should continue the shutdown protocol. As it currently doesn't calculate correctly when all data has been sent, as NACKED chunks are not included in what it believes is remaining in the retransmission queue, it will shut down prematurely and may go back to a previous state (ShutdownPending) from ShutdownSent or ShutdownAckSent. This is a workaround that just avoids the illegal state transition as that puts the socket in an inconsistent state. The bug is merely theoretical as WebRTC doesn't currently gracefully shut down a SCTP socket, but just terminates the DTLS transport. As TODOs mention, this will be fixed correctly a bit later. Bug: webrtc:12739 Change-Id: Ibde2acc3a6aca701ac178d6181028404d470a5d5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/218340 Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33982}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: https://ci.chromium.org/p/webrtc/g/ci/console
- Coding style guide
- Code of conduct
- Reporting bugs