4c6ca30019
This CL wires up the new SetRates() method of the video encoders, and refactors a few things in the process: Most notably, the VideoStreamEncoderInterface is update so that the |target_headroom| parameter is replaced with |link_allocation|, meaning that instead of indicating bitrate capacity in excess of the target bitrate, it indicates to total network capacity allocated for the stream including the target bitrate. This matches the VideoEncoder API. The VideoEncoder::RateControlParameters struct gets a few new helper methods. In VideoStreamEncoder, instead of adding more fields to the |last_observed_bitrate*| family, uses an optional struct that inherits from VideoEncoder::RateControlParameters. Bug: webrtc:10481 Change-Id: Iee3965531142ae9b964ed86c0d51db59b1cdd61c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/131123 Commit-Queue: Erik Språng <sprang@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/master@{#27487}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.