6e2458d888
With deferred packet sequencing, the PacketSequencer instance is called directly from the RtpRtcp module while before it was called from within the RTPSender while holding a lock. Since sequence number assignment happens on the same thread as actual packet sending, though thought was that locking was no longer needed. Unfortunately, SetRtpState()/GetRtpState() also exists - and while they should only be called on creating/destruction there is a possible race where a delayed packet from the pacer accesses the sequencer while GetRtpState() is being called. For now, this CL just adds a lock to guard sequencer. Follow-ups will make sure get/set state is never called while module is attached to the packet router. After that, the lock can be removed again. Bug: webrtc:11340, webrtc:12470 Change-Id: I123c762fb4afd20b3a6bd03b86234eb9ec34a209 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228430 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34723}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: https://ci.chromium.org/p/webrtc/g/ci/console
- Coding style guide
- Code of conduct
- Reporting bugs
- Documentation