ad82a424e4
RtcEventLogImpl::task_queue_ is a std::unique_ptr<rtc::TaskQueue>. When a unique_ptr is destroyed, it first sets its internal pointer to point to null, and only then invokes the destructor of that object. However, the code in RtcEventLogImpl relies on rtc::TaskQueue's property, that its destructor blocks on executing tasks. We solve by manually invoking the destructor, and only resetting the internal pointer thereafter. In theory, we could have changed the unique_ptr to a raw pointer at this point. We avoid that, so as to keep the ownership clearer to readers of the code. Bug: webrtc:10085 Change-Id: I54bbf5d6bae019757ca2e31ee960d558058ccc42 Reviewed-on: https://webrtc-review.googlesource.com/c/112598 Commit-Queue: Elad Alon <eladalon@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/master@{#25875}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: http://build.chromium.org/p/client.webrtc
- Coding style guide
- Code of conduct