ea20e95cdc
When ScreencastPortal::OnStartRequestResponseSignal receives either a non-zero response code or is missing the response data, it would directly cast this to a RequestResponse. However, this direct cast is an error. Per the documentation, the response signal returns the following values with their corresponding meanings: 0 - Success 1 - User Cancelled 2 - Error The RequestResponse enum however, has "kUnknown" as 0, and thus "kSuccess" as 1 (with all other values also shifted up by 1 value). This means that when the portal was cancelled, we were still receiving RequestResponse::kSuccess. This fixes the issue by removing the improper cast and adding a translation function. This function is local for now since no where else attempted to cast values to a RequestResponse; but can be moved if the need arises. Fixed: chromium:1351824 Change-Id: I4cd44d90055147c9592d590c7969dcfc3297a3d9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271240 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37755}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: https://ci.chromium.org/p/webrtc/g/ci/console
- Coding style guide
- Code of conduct
- Reporting bugs
- Documentation