fa8a9465d5
When fixing so that RemoteAudioSource does not end the track just because the audio channel is gone in Unified Plan[1], this made it possible for ~PeerConnection to delete all objects, including deleting the MediaStreamTrack and its RemoteAudioSource, when all tracks are not in an ended state. In a real application or Chromium, the PeerConnection would not be destroyed prior to closing and not hit this DCHECK. But in upstream dependent projects' unit tests, it would be possible for ref counted tracks to be destroyed when the track are still kLive, and as a side-effect hit this DCHECK. sinks_ is just a list of raw pointers, and whether or not we have done sinks_.clear() prior to destruction is irrelevant going forward. [1] https://webrtc-review.googlesource.com/c/src/+/214136 Bug: chromium:1121454 Change-Id: If6cf3dffcd3cb47d46694755b5dc45fa381285fc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/215226 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/master@{#33739}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: http://build.chromium.org/p/client.webrtc
- Coding style guide
- Code of conduct
- Reporting bugs