database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[pipelineX](minor) remove unused timer (#25766)

Browse Source
This commit is contained in:
Gabriel
2023-10-23 17:50:46 +08:00
committed by GitHub
parent 267c11207b
commit 206aeabe9a
4 changed files with 2 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
be/src/pipeline/exec/sort_sink_operator.cpp
View File

@ -65,12 +65,6 @@ Status SortSinkLocalState::init(RuntimeState* state, LocalSinkStateInfo& info) {
_profile->add_info_string("TOP-N", p._limit == -1 ? "false" : "true");
_memory_usage_counter = ADD_LABEL_COUNTER(_profile, "MemoryUsage");
_sort_blocks_memory_usage =
ADD_CHILD_COUNTER(_profile, "SortBlocks", TUnit::BYTES, "MemoryUsage");
_child_get_next_timer = ADD_TIMER(_profile, "ChildGetResultTime");
_sink_timer = ADD_TIMER(_profile, "PartialSortTotalTime");
return Status::OK();
}

3
be/src/pipeline/exec/sort_sink_operator.h
View File

@ -65,9 +65,6 @@ private:
vectorized::VSortExecExprs _vsort_exec_exprs;
RuntimeProfile::Counter* _memory_usage_counter;
RuntimeProfile::Counter* _sort_blocks_memory_usage;
RuntimeProfile::Counter* _child_get_next_timer = nullptr;
RuntimeProfile::Counter* _sink_timer = nullptr;
// topn top value
vectorized::Field old_top {vectorized::Field::Types::Null};

11
be/src/pipeline/exec/sort_source_operator.cpp
View File

@ -26,15 +26,7 @@ namespace doris::pipeline {
OPERATOR_CODE_GENERATOR(SortSourceOperator, SourceOperator)
SortLocalState::SortLocalState(RuntimeState* state, OperatorXBase* parent)
: PipelineXLocalState<SortDependency>(state, parent), _get_next_timer(nullptr) {}
Status SortLocalState::init(RuntimeState* state, LocalStateInfo& info) {
RETURN_IF_ERROR(PipelineXLocalState<SortDependency>::init(state, info));
SCOPED_TIMER(profile()->total_time_counter());
SCOPED_TIMER(_open_timer);
_get_next_timer = ADD_TIMER(profile(), "GetResultTime");
return Status::OK();
}
: PipelineXLocalState<SortDependency>(state, parent) {}
SortSourceOperatorX::SortSourceOperatorX(ObjectPool* pool, const TPlanNode& tnode,
const DescriptorTbl& descs)
@ -44,7 +36,6 @@ Status SortSourceOperatorX::get_block(RuntimeState* state, vectorized::Block* bl
SourceState& source_state) {
CREATE_LOCAL_STATE_RETURN_IF_ERROR(local_state);
SCOPED_TIMER(local_state.profile()->total_time_counter());
SCOPED_TIMER(local_state._get_next_timer);
bool eos = false;
RETURN_IF_ERROR_OR_CATCH_EXCEPTION(
local_state._shared_state->sorter->get_next(state, block, &eos));

5
be/src/pipeline/exec/sort_source_operator.h
View File

@ -50,13 +50,10 @@ class SortLocalState final : public PipelineXLocalState<SortDependency> {
public:
ENABLE_FACTORY_CREATOR(SortLocalState);
SortLocalState(RuntimeState* state, OperatorXBase* parent);
Status init(RuntimeState* state, LocalStateInfo& info) override;
~SortLocalState() override = default;
private:
friend class SortSourceOperatorX;
RuntimeProfile::Counter* _get_next_timer = nullptr;
};
class SortSourceOperatorX final : public OperatorX<SortLocalState> {