database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[refactor] add some log when close parquet file (#8144)

Browse Source
This commit is contained in:
Zhengguo Yang
2022-02-21 09:36:53 +08:00
committed by GitHub
parent 16bf60e0da
commit 409aefdfbf
5 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
be/src/exec/csv_scan_node.cpp
View File

@ -557,7 +557,6 @@ bool CsvScanNode::split_check_fill(const std::string& line, RuntimeState* state)
if (flag == false) {
LOG(INFO) << error_msg.str();
;
return false;
}
}

4
be/src/exec/parquet_reader.cpp
View File

@ -123,7 +123,7 @@ Status ParquetReaderWrap::init_parquet_reader(const std::vector<SlotDescriptor*>
void ParquetReaderWrap::close() {
arrow::Status st = _parquet->Close();
if (!st.ok()) {
LOG(WARNING) << "close parquet file error";
LOG(WARNING) << "close parquet file error: " << st.ToString();
}
}
@ -542,7 +542,7 @@ ParquetFile::ParquetFile(FileReader* file) : _file(file) {}
ParquetFile::~ParquetFile() {
arrow::Status st = Close();
if (!st.ok()) {
LOG(WARNING) << "close parquet file error";
LOG(WARNING) << "close parquet file error: " << st.ToString();
}
}

4
be/src/exec/parquet_writer.cpp
View File

@ -44,7 +44,7 @@ ParquetOutputStream::ParquetOutputStream(FileWriter* file_writer)
ParquetOutputStream::~ParquetOutputStream() {
arrow::Status st = Close();
if (!st.ok()) {
LOG(WARNING) << "close parquet file error";
LOG(WARNING) << "close parquet file error: " << st.ToString();
}
}
@ -468,7 +468,7 @@ void ParquetWriterWrapper::close() {
_writer->Close();
arrow::Status st = _outstream->Close();
if (!st.ok()) {
LOG(WARNING) << "close parquet file error";
LOG(WARNING) << "close parquet file error: " << st.ToString();
}
} catch (const std::exception& e) {
_rg_writer = nullptr;

4
be/src/olap/rowset/segment_v2/segment_iterator.cpp
View File

@ -592,8 +592,8 @@ Status SegmentIterator::next_batch(RowBlockV2* block) {
void SegmentIterator::_vec_init_lazy_materialization() {
_is_pred_column.resize(_schema.columns().size(), false);
std::set<ColumnId>
pred_column_ids; // including short_cir_pred_col_id_set and vec_pred_col_id_set
// including short_cir_pred_col_id_set and vec_pred_col_id_set
std::set<ColumnId> pred_column_ids;
_is_all_column_basic_type = true;
bool is_predicate_column_exists = false;
bool is_non_predicate_column_exists = false;

17
be/src/runtime/exec_env_init.cpp
View File

@ -101,16 +101,16 @@ Status ExecEnv::_init(const std::vector<StorePath>& store_paths) {
new ExtDataSourceServiceClientCache(config::max_client_cache_size_per_host);
_pool_mem_trackers = new PoolMemTrackerRegistry();
_thread_mgr = new ThreadResourceMgr();
if (config::doris_enable_scanner_thread_pool_per_disk
&& config::doris_scanner_thread_pool_thread_num >= store_paths.size()
&& store_paths.size() > 0) {
_scan_thread_pool = new PriorityWorkStealingThreadPool(config::doris_scanner_thread_pool_thread_num,
store_paths.size(),
config::doris_scanner_thread_pool_queue_size);
if (config::doris_enable_scanner_thread_pool_per_disk &&
config::doris_scanner_thread_pool_thread_num >= store_paths.size() &&
store_paths.size() > 0) {
_scan_thread_pool = new PriorityWorkStealingThreadPool(
config::doris_scanner_thread_pool_thread_num, store_paths.size(),
config::doris_scanner_thread_pool_queue_size);
LOG(INFO) << "scan thread pool use PriorityWorkStealingThreadPool";
} else {
_scan_thread_pool = new PriorityThreadPool(config::doris_scanner_thread_pool_thread_num,
config::doris_scanner_thread_pool_queue_size);
config::doris_scanner_thread_pool_queue_size);
LOG(INFO) << "scan thread pool use PriorityThreadPool";
}
@ -136,7 +136,8 @@ Status ExecEnv::_init(const std::vector<StorePath>& store_paths) {
_etl_job_mgr = new EtlJobMgr(this);
_load_path_mgr = new LoadPathMgr(this);
_disk_io_mgr = new DiskIoMgr();
_tmp_file_mgr = new TmpFileMgr(this), _bfd_parser = BfdParser::create();
_tmp_file_mgr = new TmpFileMgr(this);
_bfd_parser = BfdParser::create();
_broker_mgr = new BrokerMgr(this);
_load_channel_mgr = new LoadChannelMgr();
_load_stream_mgr = new LoadStreamMgr();