database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[chore](merge-on-write) disable rowid conversion check for mow table by default (#27482)

Browse Source
This commit is contained in:
Xin Liao
2023-11-23 23:39:01 +08:00
committed by GitHub
parent 39a5229027
commit df628e1538
3 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
be/src/common/config.cpp
View File

@ -1068,6 +1068,8 @@ DEFINE_mInt64(lookup_connection_cache_bytes_limit, "4294967296");
DEFINE_mInt64(LZ4_HC_compression_level, "9");
DEFINE_mBool(enable_merge_on_write_correctness_check, "true");
// rowid conversion correctness check when compaction for mow table
DEFINE_mBool(enable_rowid_conversion_correctness_check, "false");
// The secure path with user files, used in the `local` table function.
DEFINE_mString(user_files_secure_path, "${DORIS_HOME}");

2
be/src/common/config.h
View File

@ -1130,6 +1130,8 @@ DECLARE_mBool(enable_flatten_nested_for_variant);
DECLARE_mDouble(ratio_of_defaults_as_sparse_column);
DECLARE_mBool(enable_merge_on_write_correctness_check);
// rowid conversion correctness check when compaction for mow table
DECLARE_mBool(enable_rowid_conversion_correctness_check);
// The secure path with user files, used in the `local` table function.
DECLARE_mString(user_files_secure_path);

8
be/src/olap/compaction.cpp
View File

@ -689,7 +689,9 @@ Status Compaction::modify_rowsets(const Merger::Statistics* stats) {
}
}
RETURN_IF_ERROR(_tablet->check_rowid_conversion(_output_rowset, location_map));
if (config::enable_rowid_conversion_correctness_check) {
RETURN_IF_ERROR(_tablet->check_rowid_conversion(_output_rowset, location_map));
}
location_map.clear();
{
@ -750,7 +752,9 @@ Status Compaction::modify_rowsets(const Merger::Statistics* stats) {
}
}
RETURN_IF_ERROR(_tablet->check_rowid_conversion(_output_rowset, location_map));
if (config::enable_rowid_conversion_correctness_check) {
RETURN_IF_ERROR(_tablet->check_rowid_conversion(_output_rowset, location_map));
}
_tablet->merge_delete_bitmap(output_rowset_delete_bitmap);
RETURN_IF_ERROR(_tablet->modify_rowsets(output_rowsets, _input_rowsets, true));