database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](merge-on-write) migration may cause duplicate keys for mow table (#28923)

Browse Source
This commit is contained in:
Xin Liao
2023-12-23 23:37:00 +08:00
committed by GitHub
parent 1d8822b2b7
commit dfbf082e06
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
be/src/olap/task/engine_storage_migration_task.cpp
View File

@ -24,6 +24,7 @@
#include <algorithm>
#include <ctime>
#include <memory>
#include <mutex>
#include <new>
#include <ostream>
#include <set>
@ -195,6 +196,21 @@ Status EngineStorageMigrationTask::_migrate() {
int32_t end_version = 0;
std::vector<RowsetSharedPtr> consistent_rowsets;
// During migration, if the rowsets being migrated undergoes a compaction operation,
// that will result in incorrect delete bitmaps after migration for mow table. Therefore,
// compaction will be prohibited for the mow table when migration. Moreover, it is useless
// to perform a compaction operation on the migration data, as the migration still migrates
// the data of rowsets before the compaction operation.
std::unique_lock full_compaction_lock(_tablet->get_full_compaction_lock(), std::defer_lock);
std::unique_lock base_compaction_lock(_tablet->get_base_compaction_lock(), std::defer_lock);
std::unique_lock cumu_compaction_lock(_tablet->get_cumulative_compaction_lock(),
std::defer_lock);
if (_tablet->enable_unique_key_merge_on_write()) {
full_compaction_lock.lock();
base_compaction_lock.lock();
cumu_compaction_lock.lock();
}
// try hold migration lock first
Status res;
uint64_t shard = 0;