database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Improvement](sink) remove unused check on string's write_column_to_mysql (#34491)

Browse Source 
remove unused check on string's write_column_to_mysql
This commit is contained in:
Pxl
2024-05-09 20:53:58 +08:00
committed by yiguolei
parent ec34bc0386
commit e2ea54c0a7
2 changed files with 2 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
be/src/vec/columns/column_string.h
View File

@ -133,7 +133,7 @@ public:
}
StringRef get_data_at(size_t n) const override {
assert(n < size());
DCHECK_LT(n, size());
return StringRef(&chars[offset_at(n)], size_at(n));
}

18
be/src/vec/data_types/serde/data_type_string_serde.h
View File

@ -255,23 +255,7 @@ private:
int row_idx, bool col_const) const {
const auto col_index = index_check_const(row_idx, col_const);
const auto string_val = assert_cast<const ColumnType&>(column).get_data_at(col_index);
if (string_val.data == nullptr) {
if (string_val.size == 0) {
// 0x01 is a magic num, not useful actually, just for present ""
char* tmp_val = reinterpret_cast<char*>(0x01);
if (UNLIKELY(0 != result.push_string(tmp_val, string_val.size))) {
return Status::InternalError("pack mysql buffer failed.");
}
} else {
if (UNLIKELY(0 != result.push_null())) {
return Status::InternalError("pack mysql buffer failed.");
}
}
} else {
if (UNLIKELY(0 != result.push_string(string_val.data, string_val.size))) {
return Status::InternalError("pack mysql buffer failed.");
}
}
result.push_string(string_val.data, string_val.size);
return Status::OK();
}
};