zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PCLF] Remove temporary AddAndReturnPeer method

Browse Source 
Bug: b/198796179
Change-Id: I567790294044e6907eb2efb90a1babbecaae0fef
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/231184
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#34922}
This commit is contained in:
Artem Titov
2021-09-04 00:52:08 +02:00
committed by WebRTC LUCI CQ
parent 15157abf02
commit 749f709504
3 changed files with 2 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
api/test/peerconnection_quality_test_fixture.h
View File

@ -501,15 +501,7 @@ class PeerConnectionE2EQualityTestFixture {
virtual PeerHandle* AddPeer(
rtc::Thread* network_thread,
rtc::NetworkManager* network_manager,
rtc::FunctionView<void(PeerConfigurer*)> configurer) {
return nullptr;
}
virtual PeerHandle* AddAndReturnPeer(
rtc::Thread* network_thread,
rtc::NetworkManager* network_manager,
rtc::FunctionView<void(PeerConfigurer*)> configurer) {
return nullptr;
}
rtc::FunctionView<void(PeerConfigurer*)> configurer) = 0;
// Runs the media quality test, which includes setting up the call with
// configured participants, running it according to provided `run_params` and
// terminating it properly at the end. During call duration media quality

10
test/pc/e2e/peer_connection_quality_test.cc
View File

@ -154,8 +154,7 @@ void PeerConnectionE2EQualityTest::AddQualityMetricsReporter(
quality_metrics_reporters_.push_back(std::move(quality_metrics_reporter));
}
PeerConnectionE2EQualityTest::PeerHandle*
PeerConnectionE2EQualityTest::AddAndReturnPeer(
PeerConnectionE2EQualityTest::PeerHandle* PeerConnectionE2EQualityTest::AddPeer(
rtc::Thread* network_thread,
rtc::NetworkManager* network_manager,
rtc::FunctionView<void(PeerConfigurer*)> configurer) {
@ -166,13 +165,6 @@ PeerConnectionE2EQualityTest::AddAndReturnPeer(
return &peer_handles_.back();
}
PeerConnectionE2EQualityTest::PeerHandle* PeerConnectionE2EQualityTest::AddPeer(
rtc::Thread* network_thread,
rtc::NetworkManager* network_manager,
rtc::FunctionView<void(PeerConfigurer*)> configurer) {
return AddAndReturnPeer(network_thread, network_manager, configurer);
}
void PeerConnectionE2EQualityTest::Run(RunParams run_params) {
SetDefaultValuesForMissingParams(&run_params, &peer_configurations_);
ValidateParams(run_params, peer_configurations_);

4
test/pc/e2e/peer_connection_quality_test.h
View File

@ -72,10 +72,6 @@ class PeerConnectionE2EQualityTest
rtc::Thread* network_thread,
rtc::NetworkManager* network_manager,
rtc::FunctionView<void(PeerConfigurer*)> configurer) override;
PeerHandle* AddAndReturnPeer(
rtc::Thread* network_thread,
rtc::NetworkManager* network_manager,
rtc::FunctionView<void(PeerConfigurer*)> configurer) override;
void Run(RunParams run_params) override;
TimeDelta GetRealTestDuration() const override {