476f18d2a4
Rename FrameBufferProxy to VideoStreamBufferController
...
This makes the class concrete, and the former FrameBuffer3Proxy is the implementation.
Bug: webrtc:14003
Change-Id: Ife825b9f4efc7b79d9be8b4afb03904da819958a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265868
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37793}
2022-08-16 09:10:47 +00:00
f37b0016c5
Adopt absl::string_view in modules/audio_mixer/
...
Bug: webrtc:13579
Change-Id: I40db95dcbd8e7bc7423144cf9066414d9f62fd2c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271283
Commit-Queue: Ali Tofigh <alito@webrtc.org >
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37792}
2022-08-16 09:07:35 +00:00
7cbd8dee7b
Prefer use of time controller main thread to run loop
...
Bug: None
Change-Id: I1f3802ad720b585a44e8e4cba1aad0c48a1473a5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/266499
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37791}
2022-08-16 08:53:38 +00:00
c3cfa5f123
Update WebRTC code version (2022-08-16T04:04:57).
...
Bug: None
Change-Id: I1ec7b22a9e1a9d4ad365a5811f21c8f2a2f979f2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271761
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37790}
2022-08-16 05:28:26 +00:00
8810a93ade
Roll chromium_revision dafd6f34c3..5ddcf683a5 (1035229:1035358)
...
Change log: dafd6f34c3..5ddcf683a5dafd6f34c3..5ddcf683a52007726c2c..eafe58b58c59abbfcf6e..39f80dadcdd11ec50f72..f503e0c50e617872328c..dbe2ab9dc9a5b6880c2a..ad0ac8cf43https://chromium.googlesource.com/catapult.git/+log/42f4f9ca7d..b3421074fa
* src/third_party/depot_tools: 647cfe6bf1..268d6458539c88d08f46..e13881c4d2dafd6f34c3..5ddcf683a5https://webrtc-review.googlesource.com/c/src/+/271780
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37789}
2022-08-16 04:35:07 +00:00
93fd55a030
Roll chromium_revision 9c813849ab..dafd6f34c3 (1035116:1035229)
...
Change log: 9c813849ab..dafd6f34c39c813849ab..dafd6f34c30cb1b3b9fb..2007726c2cf4bf4bfd41..d11ec50f729a59c82dbd..617872328cb4f84b16d9..a5b6880c2ahttps://chromium.googlesource.com/catapult.git/+log/6dbdca4bea..42f4f9ca7d
* src/tools: 889ffbd6f2..9c88d08f469c813849ab..dafd6f34c3https://webrtc-review.googlesource.com/c/src/+/271723
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37788}
2022-08-15 22:38:12 +00:00
e1bd833f9d
Combine setters for protection payload types (red and ulpfec)
...
Bug: webrtc:11993
Change-Id: Ibd1402ac1b77d0484c3a97e9a758ed9e588615eb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271640
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37787}
2022-08-15 19:53:06 +00:00
ab6233708c
Roll chromium_revision 9ae72ef099..9c813849ab (1034994:1035116)
...
Change log: 9ae72ef099..9c813849ab9ae72ef099..9c813849abca235570ef..0cb1b3b9fb3424d9d44f..59abbfcf6ec53aa08f59..f4bf4bfd4195324abbb0..9a59c82dbd86aa99995b..b4f84b16d99b95139ed2..14874308ba73a455d15c..889ffbd6f29ae72ef099..9c813849abhttps://webrtc-review.googlesource.com/c/src/+/271721
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37786}
2022-08-15 18:33:36 +00:00
1c5f317e17
Update the red_payload_type without recreating video receive streams.
...
A follow-up change will combine the setters for ulpfec and red payload
types, since they're entwined.
Bug: webrtc:11993
Change-Id: Ifea7fe9f4ebc7ac88a62db6cd6748f4d3c20db4c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271482
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37785}
2022-08-15 17:23:56 +00:00
875c9d357b
Reorder Kalman filter update steps physically (but not logically)
...
This CL reorders the update steps physically, to make them
easier to comprehend. It renames variables to be more verbose,
but also adds succinct mathematical descriptions (using Wikipedia
notation) to all steps.
No functional changes are intended with this change.
Bug: webrtc:14151
Change-Id: I6a4642e89e2b73639f0b4c928e07b317c14d5884
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271546
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37784}
2022-08-15 14:56:06 +00:00
48ac38ec9b
Prevent UB on BufferT::AppendData.
...
As per https://en.cppreference.com/w/cpp/string/byte/memcpy , calling
std::memcpy with dest or src as nullptr is UB.
This CL prevents this from happening and is also looking into
why UBSan didn't catch the issue.
Bug: webrtc:14292
Change-Id: I99833f28ac865719d0dcb02c4de00f33a48c3992
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271502
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37783}
2022-08-15 10:11:46 +00:00
2f764dd53d
Roll chromium_revision 24b1561edd..9ae72ef099 (1034914:1034994)
...
Change log: 24b1561edd..9ae72ef09924b1561edd..9ae72ef099dbab4f8764..98014eb61a1f6f8b77bc..6cc58d640c116bc7af5b..c53aa08f596ab6330272..95324abbb09ce96d7008..86aa99995bd6a71f8272..73a455d15c24b1561edd..9ae72ef099https://webrtc-review.googlesource.com/c/src/+/271672
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37782}
2022-08-15 09:00:56 +00:00
24a8e0d161
Remove unnecessary virtual function specifiers
...
This class is never overridden.
Bug: webrtc:14151
Change-Id: I3b70e927ee0eafd71ce4bdb8f6e8d6330c1a3f08
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271501
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37781}
2022-08-15 08:58:46 +00:00
3afe6331fb
Update WebRTC code version (2022-08-15T04:04:59).
...
Bug: None
Change-Id: I96e2049451ba48348b4840e5e7bf66d0a4e5c6e7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271669
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37780}
2022-08-15 06:37:06 +00:00
0b73372a7e
Roll chromium_revision 2fcda9488b..24b1561edd (1034811:1034914)
...
Change log: 2fcda9488b..24b1561edd2fcda9488b..24b1561edd5c91684271..3424d9d44f47ec3a84c6..dbab4f87649f503bebdb..1f6f8b77bc754d016769..030b4ebf323202c9caf7..116bc7af5bcc5aacb027..6ab6330272f04ec4d493..9ce96d70082fcda9488b..24b1561eddhttps://webrtc-review.googlesource.com/c/src/+/271664
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37779}
2022-08-14 18:25:05 +00:00
ae1e69bdd5
Update WebRTC code version (2022-08-14T04:04:05).
...
Bug: None
Change-Id: Id24b0b7c7c1ab8578de28c733a09718451e8537c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271617
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37778}
2022-08-14 05:57:27 +00:00
c1751f4dbe
Roll chromium_revision b432ce7fe4..2fcda9488b (1034705:1034811)
...
Change log: b432ce7fe4..2fcda9488bb432ce7fe4..2fcda9488b4696250a24..ca235570ef1995e7aaf3..5c91684271fe7cb69ebd..cc5aacb0276be9169669..f04ec4d49350ec7b3822..b3070c52556a6564666e..d6a71f8272b432ce7fe4..2fcda9488bhttps://webrtc-review.googlesource.com/c/src/+/271607
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37777}
2022-08-13 10:46:44 +00:00
2e809365d7
Add SetRtcpXr - set extended RTCP attributes without recreate.
...
Bug: webrtc:11993
Change-Id: Ie64b37c1e8a3f5b6fbcf671fce4ed642c74521cd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271300
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37776}
2022-08-13 08:15:45 +00:00
7dc5e11666
Update WebRTC code version (2022-08-13T04:02:54).
...
Bug: None
Change-Id: I096fc34900f185e1d9c4ba062a3b87a86e3e0929
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271622
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37775}
2022-08-13 05:49:04 +00:00
2aaef45876
Replace Invoke in tests with SendTask test helper
...
Bug: webrtc:11318
Change-Id: I14e3fbc694d41c785a61c88d8207005c681576c4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271540
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37774}
2022-08-12 23:42:16 +00:00
6f1c84705f
Roll chromium_revision 17713efc0e..b432ce7fe4 (1034554:1034705)
...
Change log: 17713efc0e..b432ce7fe417713efc0e..b432ce7fe4a558a42d65..4696250a241ecd4e6c21..1995e7aaf3a097a1ada6..754d016769a1c4da0415..3202c9caf7f2e7e36ca9..fe7cb69ebd4f618cc598..6be9169669a7a8b9c300..e085b3b50b9b17af9bef..1c5a8bb17a9cfcd03fbc..6a6564666e17713efc0e..b432ce7fe4https://webrtc-review.googlesource.com/c/src/+/271620
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37773}
2022-08-12 22:32:16 +00:00
cc903d99bd
Remove rtc::Location from pc/proxy as unused
...
Bug: webrtc:11318
Change-Id: Ie1ec35a61f8ad029127d5feb824308d0297919ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271542
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37772}
2022-08-12 20:05:30 +00:00
66d20c487d
Allow ulpfec payload type reconfig without recreating receive streams.
...
Bug: none
Change-Id: I1c5dad7811dd93552c185145e5a1488a8e9bb863
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271000
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37771}
2022-08-12 20:03:14 +00:00
57574ea577
Fix potentially negative Timestamp in logs.
...
This bug was activated by [1] when we started to store the timestamp
in the webrtc::Timestamp class (causing an RTC_DCHECK to trigger) but
it has been in the codebase for long time (but without using
webrtc::Timestamp the RTC_DCHECK was not triggered).
Basically, LogStartTime() can be called externally to create a baseline
for logging but if that is not the case, LogMessage should call it [2]
and initialise the baseline.
This was happening in reverse order, causing the first LogMessage to
call LogStartTime() after the SystemTimeMillis(), causing a negative
time difference that when gets wrapped into webrtc::Timestamp triggers
the RTC_DCHECK [3].
[1] - https://webrtc-review.googlesource.com/c/src/+/269249
[2] - https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/rtc_base/logging.h;l=493-497;drc=821b92a66ed661714cc21020b5a045fcd18d0176
[3] - https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/rtc_base/units/unit_base.h;l=122;drc=6dcd43f1e4f2f3ec0bd844cd45e011e9c4d16e38
Bug: b/238157120
Change-Id: I891799316503030c0df5e10e759a61dfc5e1ab3c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271582
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37770}
2022-08-12 19:54:33 +00:00
dfb9e8b02c
Roll chromium_revision f7f9661e5f..17713efc0e (1034398:1034554)
...
Change log: f7f9661e5f..17713efc0ef7f9661e5f..17713efc0e7b607ca21c..a558a42d6536b3854b7e..1ecd4e6c213dafa33556..a1c4da04154802c02064..f2e7e36ca9e9954c9c75..4f618cc5982d152304da..9b95139ed256642e7768..9cfcd03fbcf7f9661e5f..17713efc0ehttps://webrtc-review.googlesource.com/c/src/+/271600
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37769}
2022-08-12 18:56:24 +00:00
1856b2ce71
Stop adding zeros for the off-diagonal components
...
Bug: webrtc:14151
Change-Id: I58017cab911e642f457f665c5f4d1ff6d11d8571
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271545
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37768}
2022-08-12 16:04:34 +00:00
949530e6aa
Improve FrameDelayDeltaKalmanFilter members naming.
...
* Update naming of data members.
* Start reordering code blocks in `PredictAndUpdate`.
(The "predict" step is done in this C:. The "update"
step will be improved in another cl.)
Bug: webrtc:14151
Change-Id: Idea1e8e786bd672dadedbcb3cd5598f4a033e81e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271023
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37767}
2022-08-12 14:07:44 +00:00
ae4a832730
Improve FrameDelayDeltaKalmanFilter interface and add more docs.
...
This CL simplifies and documents the interface of the Kalman filter better. A simple unit test verifying the filter's convergence is
added. No functional changes to the filter are intended.
Future CLs will improve the data member naming and code organization.
Bug: webrtc:14151
Change-Id: I01e60d4b783cabad3ccbdc711c5d746666dd16ca
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265877
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37766}
2022-08-12 13:42:23 +00:00
85a126ec5d
ApmTest.VerifyDebugDump(Int|Float) more insightful with failures
...
Instead of showing individual byte differences, this CL detects
differences in the expected and actual byte streams of the evaluated
AEC dump and, if detected, parses the `audioproc::Event` proto lite
messages and calls EXPECT_EQ() for a subset of individual (sub-)fields.
Note that messages are parsed only if the byte streams of each message
pair do not match, so with no failures the test runs at no extra cost.
Plus, the the added funcionality can only be enabled for local
debugging by flipping the `kDumpWhenExpectMessageEqFails` flag - a
code change cannot land if the flag is set to true.
Note that `MessageDifferencer` (see [1]) could not be used because
it is not implemented for `MessageLite` protos.
[1] https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.util.message_differencer
Bug: b/241923537
Change-Id: I8e0eda3b1ecfe06945b6dad5ee8871f8200d76d7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270922
Reviewed-by: Jesus de Vicente Pena <devicentepena@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37765}
2022-08-12 12:42:43 +00:00
b69b81944c
Conditionally construct UlpfecReceiver
...
Bug: none
Change-Id: I986803dcba5d7b6bb6e58e6a51fb38a216c1d03d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271120
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37764}
2022-08-12 11:57:35 +00:00
afba20a40d
Roll chromium_revision 2edc75a4bd..f7f9661e5f (1034319:1034398)
...
Change log: 2edc75a4bd..f7f9661e5f2edc75a4bd..f7f9661e5f319b678221..7b607ca21c11459ac227..47ec3a84c655e0c49d14..9f503bebdbe9f50739ee..3dafa3355608ab203984..4802c0206475ea04e77d..e9954c9c75https://chromium.googlesource.com/catapult.git/+log/b2cd6477b9..6dbdca4bea
* src/third_party/r8: YywdNQUrAK_HHH829t_MPLvTyjmQW-dWAsB7k-8gpNkC..DZRgtLW0NflugdN9UMc7OsJqux69vI-6BxCNcTJaRTwC
* src/tools: 73e64c8356..56642e77682edc75a4bd..f7f9661e5fhttps://webrtc-review.googlesource.com/c/src/+/271467
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37763}
2022-08-12 11:30:03 +00:00
b8c8d0b431
Trigger CI.
...
No-Try: True
Bug: None
Change-Id: Id93f774d1c84f933e83ba753f2246222d930e8ce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271520
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org >
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37762}
2022-08-12 11:03:03 +00:00
166ef2788a
Format build_apprtc.py as requested by presubmit.
...
No-Try: True
Bug: None
Change-Id: I17e8abd3678dec4ffc33ce5932952046e06194e5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271500
Auto-Submit: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Evan Shrubsole <eshr@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Evan Shrubsole <eshr@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37761}
2022-08-12 09:13:52 +00:00
7d9f0dc40f
Downgrade go runtime to 1.16 for macOS AppRTC tests.
...
Starting from Go 1.17, modules are the default and cannot be disabled.
This requires a change in the GitHub repositury [1].
As a stopgap solution, this CL moves Go back to 1.16 and disables
modules [2].
[1] - https://github.com/webrtc/apprtc/tree/master/src/collider
[2] - https://go.dev/blog/go116-module-changes
No-Presubmit: True
Bug: webrtc:14342
Change-Id: Idd03639588bc03497a78f0cef350daebf3b2f1d9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271481
Reviewed-by: Evan Shrubsole <eshr@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37760}
2022-08-12 07:13:52 +00:00
c2b1e53923
Update WebRTC code version (2022-08-12T04:04:41).
...
Bug: None
Change-Id: Iabe68a121b0f24786df2f31ec82b94a0017921f9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271464
Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37759}
2022-08-12 05:06:13 +00:00
ce081ca649
Roll chromium_revision 20e12fda4c..2edc75a4bd (1034200:1034319)
...
Change log: 20e12fda4c..2edc75a4bd20e12fda4c..2edc75a4bd3ca180e1f3..319b67822136d2f78cc9..e9f50739ee29004acfff..08ab2039842974d8aa5f..75ea04e77dafc8daa2de..a7a8b9c300b7427143a5..73e64c835620e12fda4c..2edc75a4bdhttps://webrtc-review.googlesource.com/c/src/+/271463
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37758}
2022-08-12 04:29:32 +00:00
b5353a4bd4
Roll chromium_revision 7d7712f9a5..20e12fda4c (1034078:1034200)
...
Change log: 7d7712f9a5..20e12fda4c7d7712f9a5..20e12fda4c927f34ef3f..3ca180e1f369cc1cd402..36b3854b7e3fc6878268..36d2f78cc9c26185bc64..29004acfff4b1d077fe9..2974d8aa5fhttps://chromium.googlesource.com/catapult.git/+log/268569634e..b2cd6477b9
* src/tools: 993e6846ed..b7427143a57d7712f9a5..20e12fda4chttps://webrtc-review.googlesource.com/c/src/+/271460
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37757}
2022-08-11 23:05:22 +00:00
61ebb8f1cb
Roll chromium_revision 97cc0354ba..7d7712f9a5 (1033968:1034078)
...
Change log: 97cc0354ba..7d7712f9a597cc0354ba..7d7712f9a5a2ce233e87..927f34ef3f740dc38636..69cc1cd40210e9d08ce2..3fc68782682673a6e4fa..c26185bc64ad4b9274a8..4b1d077fe95e21a38118..993e6846ed97cc0354ba..7d7712f9a5https://webrtc-review.googlesource.com/c/src/+/271420
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37756}
2022-08-11 18:49:02 +00:00
ea20e95cdc
Fix improper cast from PipeWire portal to RequestResponse
...
When ScreencastPortal::OnStartRequestResponseSignal receives either a
non-zero response code or is missing the response data, it would
directly cast this to a RequestResponse. However, this direct cast is an
error. Per the documentation, the response signal returns the following
values with their corresponding meanings:
0 - Success
1 - User Cancelled
2 - Error
The RequestResponse enum however, has "kUnknown" as 0, and thus
"kSuccess" as 1 (with all other values also shifted up by 1 value). This
means that when the portal was cancelled, we were still receiving
RequestResponse::kSuccess. This fixes the issue by removing the improper
cast and adding a translation function. This function is local for now
since no where else attempted to cast values to a RequestResponse; but
can be moved if the need arises.
Fixed: chromium:1351824
Change-Id: I4cd44d90055147c9592d590c7969dcfc3297a3d9
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271240
Commit-Queue: Alexander Cooper <alcooper@chromium.org >
Auto-Submit: Alexander Cooper <alcooper@chromium.org >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37755}
2022-08-11 16:51:44 +00:00
71434ae614
Rename PreferGlobalIPv6ToLinkLocal field trial to group IPv6 fixes.
...
This combines the below IPv6 fixes into the field trial
WebRTC-IPv6NetworkResolutionFixes:
1. Prefer global IPv6 address over link local
2. Use address family when resolving STUN hostname
WebRTC-PreferGlobalIPv6ToLinkLocal is currently in Dev but will be
rolled back temporarily.
Bug: webrtc:14334, webrtc:14131
Change-Id: I1fb3f55c4c5f3c5c0b441ece30e72cf393e074d0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271340
Reviewed-by: Diep Bui <diepbp@webrtc.org >
Commit-Queue: Sameer Vijaykar <samvi@google.com >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37754}
2022-08-11 16:24:12 +00:00
a75eb43e99
Lookup STUN hostname using the network's IP family.
...
The current behaviour is to lookup using AF_UNSPEC, which leaves
the decision up to the getaddrinfo implementation, then filter to
resolved addresses matching the network family anyway.
Looking up using the network's family upfront avoids resolving to
an unusable address.
Bug: webrtc:14319, webrtc:14131
Change-Id: I4997452dc26aeb82e5d2890701721e7d477803a8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270625
Commit-Queue: Sameer Vijaykar <samvi@google.com >
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37753}
2022-08-11 15:34:32 +00:00
f0ab4ba26e
Remove fhernqvist from watchlists
...
Change-Id: I366c93dea6bc0ff7e0d366ed8ea4fdbe1b07268c
Bug: None
Change-Id: I366c93dea6bc0ff7e0d366ed8ea4fdbe1b07268c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271341
Reviewed-by: Fredrik Hernqvist <fhernqvist@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Commit-Queue: Fredrik Hernqvist <fhernqvist@google.com >
Cr-Commit-Position: refs/heads/main@{#37752}
2022-08-11 14:44:52 +00:00
6c32480afa
Roll chromium_revision dfc145b856..97cc0354ba (1033853:1033968)
...
Change log: dfc145b856..97cc0354badfc145b856..97cc0354ba4f682b0fc7..a2ce233e879497cae3d0..740dc38636904b3de67c..10e9d08ce258f59cf5ed..2673a6e4fa711bbc6760..ad4b9274a8https://chromium.googlesource.com/catapult.git/+log/47666e0907..268569634e
* src/third_party/libyuv: d53f1beecd..9b17af9befec087833c1..5e21a38118dfc145b856..97cc0354bahttps://webrtc-review.googlesource.com/c/src/+/271360
Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/main@{#37751}
2022-08-11 14:43:02 +00:00
b787e26369
Support DNS resolution matching a specified IP family.
...
The input SocketAddress for STUN host lookup is constructed with just
the hostname, so the family is AF_UNSPEC. So added an overload with a
target family to distinguish this from the family of the input addr.
Bug: webrtc:14319, webrtc:14131
Change-Id: Ia5ac5aa2e894e0c4dfb4417e3e8a76a6cec3ea71
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270624
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Sameer Vijaykar <samvi@google.com >
Reviewed-by: Jonas Oreland <jonaso@webrtc.org >
Reviewed-by: Jonas Oreland <jonaso@google.com >
Cr-Commit-Position: refs/heads/main@{#37750}
2022-08-11 13:52:53 +00:00
12053ec64a
Encode remote link capacity estimates in legacy RTC event log format
...
Bug: None
Change-Id: I36037d0c654e773d5e1c6e9821031eafea54fe0d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271162
Reviewed-by: Per Kjellander <perkj@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37749}
2022-08-11 12:57:02 +00:00
e519f38eaa
Remove rtc::Location from SendTask test helper
...
that rtc::Location parameter was used only as extra information for the
RTC_CHECKs directly in the function, thus call stack of the crash should
provide all the information about the caller.
Bug: webrtc:11318
Change-Id: Iec6dd2c5de547f3e1601647a614be7ce57a55734
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/270920
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37748}
2022-08-11 12:55:32 +00:00
e2d829cf77
Remove unnecessary overload
...
Bug: webrtc:13579
Change-Id: Ib8e9f3fb085718a140b5a6199cb75e7da22e4fe5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271202
Commit-Queue: Ali Tofigh <alito@webrtc.org >
Reviewed-by: Ivo Creusen <ivoc@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37747}
2022-08-11 12:34:32 +00:00
e04d0fa1b2
Fix Event Log For Video Receiver
...
Resolves an issue where, in Chrome, WebRTC event logs do not capture outgoing packets for video receivers because no reference to the event log was passed to the video receiver.
Bug: webrtc:14338
Change-Id: Ia33ce6f2d69a0e341530648b10a08516dc53abf3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271080
Reviewed-by: Magnus Flodman <mflodman@webrtc.org >
Reviewed-by: Björn Terelius <terelius@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37746}
2022-08-11 12:15:52 +00:00
ef4a2cfc45
Remove condition that will never be active
...
Remove check if `prev_estimate_` is less than 10 us since it can never
be less than 1 ms.
Bug: None
Change-Id: If151390d22fa0b6ecdc36af64168d3e2049c7b6b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271203
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Johannes Kron <kron@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37745}
2022-08-11 09:41:52 +00:00
fb8641c4e6
Drop frames in RtpVideoSender::OnEncodedImage if stream disabled
...
Drops frames if the encoder has been configured with a new set of rtp
streams and a stray frame is returned from an encoder. This can happen with
hardware encoders that may deliver frames on a separate thread than were
they are configured.
This cl disable sending media on the RTP module a video layer is connected to and there by, old frames are dropped.
Bug: webrtc:1200, b/201798527
Change-Id: Id6bcfc3a846f6b8ed3b645cbbde571b819611a75
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/271122
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Per Kjellander <perkj@webrtc.org >
Cr-Commit-Position: refs/heads/main@{#37744}
2022-08-11 08:40:01 +00:00
