Commit Graph

25310 Commits

Author SHA1 Message Date
9405efaeff Add element_type typedef to rtc::scoped_refptr
This allows rtc::scoped_refptr to be used with templates
that use element_type as the mechanism to interface with
smart pointers.

Bug: None
Change-Id: Ie742f416a78efce0b07cfa3009d939e51506ccf9
Reviewed-on: https://webrtc-review.googlesource.com/c/115100
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26078}
2018-12-20 19:11:22 +00:00
7f57788ab7 Removes trial to enable BBR congestion controller.
The BBR controller can still be injected, but the trials
will no longer work. This reduces the binary size.

Bug: webrtc:8415
Change-Id: I2c32c414d08ef0cc16bfd72651535a755cde9916
Reviewed-on: https://webrtc-review.googlesource.com/c/114120
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26077}
2018-12-20 16:42:07 +00:00
e2e000059d Make pacing buffer send interval configurable.
Bug: webrtc:10153
Change-Id: I2f71b5fc902e24b87f0b6cba474d988b8c27aefa
Reviewed-on: https://webrtc-review.googlesource.com/c/115301
Commit-Queue: Christoffer Rodbro <crodbro@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26076}
2018-12-20 15:29:27 +00:00
61832dd018 Propagate spatial index to EncodedImage.
Set spatial index of assembled VP9 picture equal to spatial index of
its top spatial layer frame.

Bug: webrtc:10151
Change-Id: Iae40505864b14b01cc6787f8da99a9e3fe283956
Reviewed-on: https://webrtc-review.googlesource.com/c/115280
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26075}
2018-12-20 15:21:22 +00:00
76fd7b402e Roll chromium_revision bdf260ef72..5397835a49 (617896:618202)
Change log: bdf260ef72..5397835a49
Full diff: bdf260ef72..5397835a49

Changed dependencies
* src/base: a86344f69f..e8a9bf196b
* src/build: c221730fee..f105d6f929
* src/ios: 16b48d13a6..8c5e5e5510
* src/testing: 1bf05a7eb7..1f281b0c1c
* src/third_party: 8115ff439e..1528353c53
* src/third_party/depot_tools: 0a8ce8ee8b..2cc6e25536
* src/third_party/libvpx/source/libvpx: d8f89c49e1..57f7c6f191
* src/tools: bbcfc766f3..ee99d84f02
DEPS diff: bdf260ef72..5397835a49/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,marpan@webrtc.org,
BUG=None

Change-Id: I0830c8883a1bf59c55e7ad5b3d966e9318251d0e
Reviewed-on: https://webrtc-review.googlesource.com/c/115261
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#26074}
2018-12-20 14:43:06 +00:00
3793bb447a Refactor TestVideoCapturer to support multiple sinks.
To be able to reuse VideoBroadcaster, that class needs to be
officially threadsafe. It already had the needed locks, but thread
checkers have to be deleted to allow calls to AddOrUpdateSink on
multiple threads (worker thread + encoder thread).

Bug: webrtc:6353, webrtc:10147
Change-Id: I16128ac205c566f09402b6f22587a340d9a983c1
Reviewed-on: https://webrtc-review.googlesource.com/c/115201
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26073}
2018-12-20 14:04:16 +00:00
941fd43a15 Update number of spatial layers if SS is available.
Bug: webrtc:10149
Change-Id: I4e962283619590999a02a31b63f1dd7ce25aa11d
Reviewed-on: https://webrtc-review.googlesource.com/c/115041
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Sergey Silkin <ssilkin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26072}
2018-12-20 13:14:12 +00:00
2894750848 Adds flag to customize output root dir in scenario tests.
Bug: webrtc:9510
Change-Id: I005baffc0b0166dc39f5f387b1d3b5caa1f350a9
Reviewed-on: https://webrtc-review.googlesource.com/c/115200
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26071}
2018-12-20 13:05:31 +00:00
d69998aa5c Adds support for empty key fields in field trial parser.
Bug: webrtc:9346
Change-Id: I16e068340d3d48b983270af0c481ed538632e148
Reviewed-on: https://webrtc-review.googlesource.com/c/115241
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26070}
2018-12-20 13:03:01 +00:00
afa07dda42 [Unified Plan] SRD: Always set associated remote streams.
This fixes a bug where the streams are not updated if the "msid" changes
without triggering "ontrack", such as if the streams associated with a
receiver changes while the receiver is active.

Bug: webrtc:10083, chromium:916934
Change-Id: Ic7b19ad5ef648ed6880cae4157bf49f8435467ae
Reviewed-on: https://webrtc-review.googlesource.com/c/114161
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26069}
2018-12-20 13:01:58 +00:00
02c4f150a8 Stop using deprecated PacedSender method from RtpTransportControllerSend.
The deprecated method will instantiate the alr detector member
that is not actually used later on.

Bug: webrtc:10108
Change-Id: I78ac8f286758078b5a9351578bea44a862e499c4
Reviewed-on: https://webrtc-review.googlesource.com/c/115180
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26068}
2018-12-20 10:31:37 +00:00
29a935a7fe Refactor NetEqDecoderPlc to use AudioDecoderProxyFactory
Bug: webrtc:10080
Change-Id: I651efc70fa020e345776c44d9510245c45f9b092
Reviewed-on: https://webrtc-review.googlesource.com/c/114547
Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26067}
2018-12-20 10:17:15 +00:00
f65309cd47 Removes return value and Try prefix from TryDeliverPacket.
The return value is not used. This change prepares for future
refactoring by removing the requirement that TryDeliverPacket must be
synchronous. Also renaming to DeliverPacket as we no longer need to
indicate the meaning of the return value.

Bug: webrtc:9510
Change-Id: I78536434b198fa7bf4df88b10d6add23684767f1
Reviewed-on: https://webrtc-review.googlesource.com/c/115181
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26066}
2018-12-20 10:04:17 +00:00
9a4f38ec5c Adds optional video quality metrics to scenario tests.
Bug: webrtc:9510
Change-Id: I448e7156cc8f56930f58c4d25bd167df83a2ba85
Reviewed-on: https://webrtc-review.googlesource.com/c/114885
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26065}
2018-12-20 08:50:12 +00:00
54fa02486a Removed log from StatsCollector::GetTrackIdBySsrc.
Bug: chromium:906988
Change-Id: I353db16687e66c265a6121ee24e6353971d7884e
Reviewed-on: https://webrtc-review.googlesource.com/c/115120
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26064}
2018-12-20 00:54:52 +00:00
ceac0152b1 Fail SetLocalDescription if a=mid lines are missing
Bug: webrtc:9540
Change-Id: I5f75feedf2aca5162269e6b4ded6e797b064415a
Reviewed-on: https://webrtc-review.googlesource.com/c/115062
Reviewed-by: Amit Hilbuch <amithi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26063}
2018-12-20 00:18:20 +00:00
b275788016 Register stat callbacks after rate observer is registered.
Currently the stats callback is registered too early.
For now we ignore media transport for these callbacks (it was ignored
already), and we will introduce changes to media transport in the
future.

Bug: webrtc:9719
Bug: chromium:906998
Bug: chromium:906533
Change-Id: I24c0265d46ec2eb35743de6cd96a11d8c41fefbe
Reviewed-on: https://webrtc-review.googlesource.com/c/114904
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Commit-Queue: Peter Slatala <psla@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26062}
2018-12-19 21:19:01 +00:00
322bba7b7d Roll chromium_revision 7ebbeeebe7..bdf260ef72 (617780:617896)
Change log: 7ebbeeebe7..bdf260ef72
Full diff: 7ebbeeebe7..bdf260ef72

Changed dependencies
* src/base: 2318229f25..a86344f69f
* src/build: f349a19606..c221730fee
* src/ios: 046c456058..16b48d13a6
* src/testing: ddd27900f9..1bf05a7eb7
* src/third_party: cecc5f148e..8115ff439e
* src/tools: 35e681ac77..bbcfc766f3
DEPS diff: 7ebbeeebe7..bdf260ef72/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Ibb0a4376c1ead8eb7cd4783a8dae71c78d5c520d
Reviewed-on: https://webrtc-review.googlesource.com/c/115061
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#26061}
2018-12-19 19:31:44 +00:00
e920351798 Update PeerConnectionProxy to reflect new PeerConnectionInterface methods
Bug: webrtc:10133
Change-Id: I0fa62d7265b3a101e7c55695fca47b72d7fabf58
Reviewed-on: https://webrtc-review.googlesource.com/c/114913
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26060}
2018-12-19 18:41:26 +00:00
f5fc537c4b Allow H264 simulcast be default
Bug: chromium:908099
Change-Id: If50d59e01ea008ce29c8225c24f5189d34817506
Reviewed-on: https://webrtc-review.googlesource.com/c/115042
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26059}
2018-12-19 17:48:26 +00:00
3f651d80a0 Reland "Add AudioDecoderFactory to NetEqTest constructor."
This is a reland of daa970f33e1923c5651a4a63c18e3d5361d0a795

Original change's description:
> Add AudioDecoderFactory to NetEqTest constructor.
>
> Update EventLogAnalyzer to not depend on builtin audio decoders.
>
> Bug: webrtc:8396, webrtc:10080
> Change-Id: Ie02ed9cda6d4f11bfdf2e65eb6482283b7520738
> Reviewed-on: https://webrtc-review.googlesource.com/c/114301
> Reviewed-by: Alex Loiko <aleloi@webrtc.org>
> Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
> Reviewed-by: Björn Terelius <terelius@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#26026}

Tbr: kwiberg@webrtc.org
Bug: webrtc:8396, webrtc:10080
Change-Id: I598ce1cd41676b1992b0973b09476eeeb0e602d2
Reviewed-on: https://webrtc-review.googlesource.com/c/114940
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26058}
2018-12-19 15:08:47 +00:00
31d8b52075 Delete unneeded includes of rtc_base/stringutils.h.
Also delete corresponding dependencies on rtc_base:stringutils.

Bug: webrtc:6424
Change-Id: I2be5e021292eea2d788c76a63cc0e4f7cefd927d
Reviewed-on: https://webrtc-review.googlesource.com/c/114544
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26057}
2018-12-19 11:04:27 +00:00
aabac232b1 Roll chromium_revision 638370e07d..7ebbeeebe7 (617680:617780)
Change log: 638370e07d..7ebbeeebe7
Full diff: 638370e07d..7ebbeeebe7

Changed dependencies
* src/base: cebe18315b..2318229f25
* src/build: 7f82cfcf4c..f349a19606
* src/ios: c3817f8bb4..046c456058
* src/testing: dcd5a94654..ddd27900f9
* src/third_party: a62015d25c..cecc5f148e
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/6bd7a3c6d7..7d95d86a65
* src/third_party/depot_tools: f18aaf4f57..0a8ce8ee8b
* src/tools: a33b51b213..35e681ac77
DEPS diff: 638370e07d..7ebbeeebe7/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I683567119842f6f8c8afb7304afb8e95034283d7
Reviewed-on: https://webrtc-review.googlesource.com/c/114962
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#26056}
2018-12-19 10:33:10 +00:00
f2090c1085 Roll chromium_revision eaca19bda5..638370e07d (617557:617680)
Change log: eaca19bda5..638370e07d
Full diff: eaca19bda5..638370e07d

Changed dependencies
* src/base: 720663c11b..cebe18315b
* src/build: eab9b1722a..7f82cfcf4c
* src/ios: f03855abc1..c3817f8bb4
* src/testing: 74a93e18b0..dcd5a94654
* src/third_party: 8b6224758c..a62015d25c
* src/third_party/depot_tools: cf56a4bfb0..f18aaf4f57
* src/tools: b1186964a0..a33b51b213
DEPS diff: eaca19bda5..638370e07d/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I0321022d91ee8554d9c6503e4ecba272287e68cf
Reviewed-on: https://webrtc-review.googlesource.com/c/114912
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#26055}
2018-12-19 01:17:19 +00:00
06817cd973 [Unified Plan] Support legacy endpoints that do not use a=mid
These legacy endpoints were supported with Plan B since the SDP
parser would fill in default MID values if a=mid was absent that
happened to match the default offered MIDs.

With Unified Plan, these default MIDs changed so the autofilled
MIDs do not match any more.

This CL adds information to the SessionDescription struct to
indicate whether or not a=mid was present and modified
PeerConnection::SetRemoteDescription to copy MIDs from the local
description if the a=mid lines are not present.

Bug: webrtc:9540
Change-Id: Ibf923b4ad59edb0facd06ddbd01cc10c62fc48e6
Reviewed-on: https://webrtc-review.googlesource.com/c/114820
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Amit Hilbuch <amithi@webrtc.org>
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26054}
2018-12-19 01:01:59 +00:00
d1208c26b1 Desktop capturer: Add OnDisplayChanged callback
This adds support for a new DesktopCapturer::Callback method
OnDisplayChanged that is sent at the start of a desktop capture
session and whenever the display geometry changes.

This cl adds the basic structure to call this api at the start
of the capture session. Currently Windows only.

A follow-up cl will add support to call this whenever the display
geometry changes.

Bug: webrtc:10122, chromium:915411
Change-Id: Ie7283be5992454180daab1a60f58a3b2efdfed56
Reviewed-on: https://webrtc-review.googlesource.com/c/114020
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Brave Yao <braveyao@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26053}
2018-12-18 21:56:48 +00:00
5a1de87e9a Use unique_ptr in webrtcsdp.cc
Bug: None
Change-Id: I68c1d1bbde928667b215340e2b1a6133b344d179
Reviewed-on: https://webrtc-review.googlesource.com/c/114907
Reviewed-by: Amit Hilbuch <amithi@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26052}
2018-12-18 20:38:54 +00:00
c26337d96d Roll chromium_revision 640d842b5c..eaca19bda5 (617449:617557)
Change log: 640d842b5c..eaca19bda5
Full diff: 640d842b5c..eaca19bda5

Changed dependencies
* src/base: 56d52a1591..720663c11b
* src/build: 0184972e96..eab9b1722a
* src/ios: 16778ca7ca..f03855abc1
* src/testing: 03652df1d0..74a93e18b0
* src/third_party: 7cfa69e393..8b6224758c
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c2fc5e046c..6bd7a3c6d7
* src/tools: e48d182c4a..b1186964a0
DEPS diff: 640d842b5c..eaca19bda5/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I5e3a24d6478bd72932875026b9921e97b6f76b6b
Reviewed-on: https://webrtc-review.googlesource.com/c/114905
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#26051}
2018-12-18 18:24:23 +00:00
503da94350 Adds first unacknowledged packet send time.
This will be used to calculate a lower bound for the round trip time in
a later CL.

Bug: webrtc:9718
Change-Id: I0a1d22045961fe6bd343d1d6ce9b36490b036bb1
Reviewed-on: https://webrtc-review.googlesource.com/c/114680
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26050}
2018-12-18 16:55:33 +00:00
11b8703201 Base ApmTest.Process on AudioProcessingStats.output_rms_dbfs
This replaces the current usage of AudioProcessing::level_estimator()
in that test.

The unit tests that specifically test the level_estimator API are left
in place, until the level_estimator API itself is removed.

Bug: webrtc:9947
Change-Id: I73301c1478d2c9763bb49598a692142229102876
Reviewed-on: https://webrtc-review.googlesource.com/c/114550
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26049}
2018-12-18 16:45:03 +00:00
358fba1f9d Removes NetworkControllerTester
Replacing NetworkControllerTester usages with SimulatedTimeClient since
they have corresponding functionality.

Bug: webrtc:9510
Change-Id: I4a6a78142a9922e53b862eb8cb71ba9091236346
Reviewed-on: https://webrtc-review.googlesource.com/c/114660
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26048}
2018-12-18 16:11:22 +00:00
1c931c4f00 Use VideoSourceInterface for owning test video sources
CallTest, VideoQualityTest and VideoAnalyzer used test::TestVideoCapturer
as an interface for video sources. Change to use VideoSourceInterface instead,
since that's all they need.

This is a preparation for making test::VcmCapturer usable as a
VideoTrackSource, and replace use of cricket::VideoCapturer in example code.

Bug: webrtc:6353
Change-Id: I445f5f6f9b7342230b89f53a5722df9c9e92834f
Reviewed-on: https://webrtc-review.googlesource.com/c/114881
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26047}
2018-12-18 15:43:55 +00:00
f0d031240c Allows injection of network controller in scenarios.
This makes it possible to test custom network controllers without
requiring update to test framework. Also updating BBR performance
test to use this feature.

Bug: webrtc:9510
Change-Id: I0446de0403fe9d1f6dc3710c1d114887a6c359c5
Reviewed-on: https://webrtc-review.googlesource.com/c/114640
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Christoffer Rodbro <crodbro@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26046}
2018-12-18 15:15:05 +00:00
b3564c1cb2 Back off relative to current estimate rather than ack rate when in ALR.
If we're in ALR, the acked rate is going to be significantly lower than
the current estimate for the link capacity. If we need to back off in
this situation (usually caused by latency spikes), this CL makes us back
off relative to current estimate if. We then immediately send a new
probe just in case the network did actually change.

All of this is behind experiment flags for now.

Bug: webrtc:10144
Change-Id: I062a259c36417eea2211d44592ef7fc979aa22b7
Reviewed-on: https://webrtc-review.googlesource.com/c/113880
Commit-Queue: Erik Språng <sprang@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26045}
2018-12-18 12:33:08 +00:00
a1bec23f6c Pass on explicit color space for VP8 and H264
Bug: webtc:8651
Change-Id: I9d478e7123e915bff858d725d6008fcfeeb0779d
Reviewed-on: https://webrtc-review.googlesource.com/c/114424
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Johannes Kron <kron@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26044}
2018-12-18 12:32:03 +00:00
0fcf4b1dbd Delete unused I420 "codec"
Previous attempt: https://codereview.webrtc.org/1882733006/. There
might be some benefit of having dummy encoder/decoder available in
video_loopback.

Bug: webrtc:5791
Change-Id: Iec316296754178c92b18dd3cf92f67ce6aed9439
Reviewed-on: https://webrtc-review.googlesource.com/c/112596
Commit-Queue: Niels Moller <nisse@webrtc.org>
Reviewed-by: Rasmus Brandt <brandtr@webrtc.org>
Reviewed-by: Magnus Flodman <mflodman@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26043}
2018-12-18 12:30:58 +00:00
e1190c6085 Roll chromium_revision 56612bfb38..640d842b5c (617342:617449)
Change log: 56612bfb38..640d842b5c
Full diff: 56612bfb38..640d842b5c

Changed dependencies
* src/base: 0544b2209f..56d52a1591
* src/build: df23eb1b25..0184972e96
* src/ios: 515fd03046..16778ca7ca
* src/testing: cb8fc3656f..03652df1d0
* src/third_party: c78f3a4681..7cfa69e393
* src/third_party/depot_tools: 61cb9d6ba7..cf56a4bfb0
* src/tools: 0d6446c223..e48d182c4a
DEPS diff: 56612bfb38..640d842b5c/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: Iae86763064687dd15b26c3b85877bb3cde5fdf39
Reviewed-on: https://webrtc-review.googlesource.com/c/114861
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#26042}
2018-12-18 12:29:38 +00:00
16994087d8 Inlining IncomingVideoStream::NewFrameTask.
This CL moves IncomingVideoStream::NewFrameTask closer to where it's
used and simplifies it somewhat. This makes it easier to follow the code
when debugging etc.

Bug: webrtc:9883
Change-Id: I359e2a5f4f2341259fd7e66a55c7a4b8bd9313ba
Reviewed-on: https://webrtc-review.googlesource.com/c/114720
Reviewed-by: Magnus Jedvert <magjed@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26041}
2018-12-18 10:52:09 +00:00
7d92de69fe Deprecating legacy SendSideCongestionController.
For somewhat similar funtionality, GoogCcNetworkController can
be used via GoogCcNetworkControllerFactory.

Bug: webrtc:9586
Change-Id: I298050184513f50c1b9ef5c21b8c9b7a6ca46fd5
Reviewed-on: https://webrtc-review.googlesource.com/c/114543
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26040}
2018-12-18 10:22:30 +00:00
4415315b52 Move ServerSocket code to separate files and into test target
Classes AsyncProxyServerSocket, AsyncSSLServerSocket, and
AsyncSSLServerSocket are used only by test and example code.

Moved to server_socket_adapters.{cc,h}, and to the
rtc_base_tests_utils build target.

In the process, also deleted a few ancient and unattributed TODO
comments.

Bug: webrtc:9798
Change-Id: I21279c92bd8f1354fab7eeaf1f9697fedfc760e1
Reviewed-on: https://webrtc-review.googlesource.com/c/107735
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26039}
2018-12-18 10:12:19 +00:00
3d2ed19d95 Remove Transport implementation from ChannelSend
Avoids taking a lock for each outgoing packet.

Bug: none
Change-Id: I54defbf07097ea8032b556b6900ca58c7486c3d9
Reviewed-on: https://webrtc-review.googlesource.com/c/112123
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26038}
2018-12-18 09:34:52 +00:00
8eeccbe6a6 Delete Start and Stop methods from TestVideoCapturer.
Preparation for replacing use of TestVideoCapturer as an interface,
instead using VideoSourceInterface.

Methods kept as non-virtual on the subclass FrameGeneratorCapturer,
but it's changed to be started on creation.

Bug: webrtc:6353
Change-Id: Iae1c9a0ee55d730d4992204f62227ef2f057d58e
Reviewed-on: https://webrtc-review.googlesource.com/c/114425
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26037}
2018-12-18 09:29:52 +00:00
41f3a43c74 Remove CodecInst pt.3
Finally remove CodecInst from common_types.h, including remaining code referencing it.

TBR=kwiberg

Bug: webrtc:7626
Change-Id: I5e6b949ae9093641e33972af8438d1126fc48556
Reviewed-on: https://webrtc-review.googlesource.com/c/114546
Commit-Queue: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Oskar Sundbom <ossu@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26036}
2018-12-18 07:42:21 +00:00
de133ce79e Roll chromium_revision caa5e0d1c9..56612bfb38 (617225:617342)
Change log: caa5e0d1c9..56612bfb38
Full diff: caa5e0d1c9..56612bfb38

Changed dependencies
* src/base: cd3c1fe6e0..0544b2209f
* src/build: b423fb4501..df23eb1b25
* src/ios: 36664d0613..515fd03046
* src/testing: 82dce44707..cb8fc3656f
* src/third_party: 4444813c40..c78f3a4681
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/2ce7ac89a3..c2fc5e046c
* src/third_party/depot_tools: a1e4d48a10..61cb9d6ba7
* src/third_party/libvpx/source/libvpx: 18d260d13f..d8f89c49e1
* src/tools: df7de56552..0d6446c223
DEPS diff: caa5e0d1c9..56612bfb38/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,marpan@webrtc.org,
BUG=None

Change-Id: Ic811ebe99f5aa4f02e811fdc5bd19f40da8a551c
Reviewed-on: https://webrtc-review.googlesource.com/c/114800
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#26035}
2018-12-18 02:43:16 +00:00
7a33d23503 Roll chromium_revision ddce7e097d..caa5e0d1c9 (617111:617225)
Change log: ddce7e097d..caa5e0d1c9
Full diff: ddce7e097d..caa5e0d1c9

Changed dependencies
* src/base: 49db73713b..cd3c1fe6e0
* src/build: d20f468cf8..b423fb4501
* src/ios: b97b57743a..36664d0613
* src/testing: 4e884f9ae9..82dce44707
* src/third_party: 2ad7d171b7..4444813c40
* src/third_party/depot_tools: 27c6e44188..a1e4d48a10
* src/tools: cbad873606..df7de56552
DEPS diff: ddce7e097d..caa5e0d1c9/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I06d1227afb6893f1efb1cd7a303fd3f1155c889a
Reviewed-on: https://webrtc-review.googlesource.com/c/114742
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#26034}
2018-12-17 21:37:33 +00:00
7d8c27e12a [Fuchsia] Implement detection of available cores.
Bug: webrtc:10135
Change-Id: I958276f4bbf5fa1a77335d4b7a279cb6c3344abc
Reviewed-on: https://webrtc-review.googlesource.com/c/114504
Reviewed-by: Henrik Andreassson <henrika@webrtc.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#26033}
2018-12-17 19:37:46 +00:00
68586e80fc Replace starts_with and ends_with with Abseil
Bug: None
Change-Id: I7eae3db1aeb81f0f1d37ff50d5c85c16ecb1f366
Reviewed-on: https://webrtc-review.googlesource.com/c/114221
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26032}
2018-12-17 17:33:06 +00:00
73f2da9fa7 Remove VP8EncoderSimulcastProxy
The class has been renamed to EncoderSimulcastProxy.

Bug: webrtc:10069
Change-Id: Ief03cfb27145798ac46692d9e51371d2e119eeb0
Reviewed-on: https://webrtc-review.googlesource.com/c/114551
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26031}
2018-12-17 15:29:20 +00:00
f7f753b320 Revert "Add AudioDecoderFactory to NetEqTest constructor."
This reverts commit daa970f33e1923c5651a4a63c18e3d5361d0a795.

Reason for revert: Speculative revert due to downstream breakage

Original change's description:
> Add AudioDecoderFactory to NetEqTest constructor.
>
> Update EventLogAnalyzer to not depend on builtin audio decoders.
>
> Bug: webrtc:8396, webrtc:10080
> Change-Id: Ie02ed9cda6d4f11bfdf2e65eb6482283b7520738
> Reviewed-on: https://webrtc-review.googlesource.com/c/114301
> Reviewed-by: Alex Loiko <aleloi@webrtc.org>
> Reviewed-by: Ivo Creusen <ivoc@webrtc.org>
> Reviewed-by: Björn Terelius <terelius@webrtc.org>
> Commit-Queue: Niels Moller <nisse@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#26026}

TBR=mbonadei@webrtc.org,aleloi@webrtc.org,kwiberg@webrtc.org,terelius@webrtc.org,nisse@webrtc.org,ivoc@webrtc.org

No-Try: True
Bug: webrtc:8396, webrtc:10080
Change-Id: Ided750d8ed800d8a38f7cce8f72095d8ed1bc6cb
Reviewed-on: https://webrtc-review.googlesource.com/c/114552
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26030}
2018-12-17 15:16:30 +00:00
74a99e7b74 Roll chromium_revision 380d56dda2..ddce7e097d (617001:617111)
Change log: 380d56dda2..ddce7e097d
Full diff: 380d56dda2..ddce7e097d

Changed dependencies
* src/base: 0dc1321d01..49db73713b
* src/build: 0062e6cc5b..d20f468cf8
* src/ios: 0e16b20a79..b97b57743a
* src/testing: 8daf553f67..4e884f9ae9
* src/third_party: c581edfb90..2ad7d171b7
* src/third_party/icu: 2823bdd7ed..23de01679d
* src/tools: fd41660fc1..cbad873606
DEPS diff: 380d56dda2..ddce7e097d/DEPS

No update to Clang.

TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com,
BUG=None

Change-Id: I73f7a0ee09e9e72ae74791994c617b2d11d551bd
Reviewed-on: https://webrtc-review.googlesource.com/c/114623
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#26029}
2018-12-17 14:52:41 +00:00