bb55e0bc72
ADM2 for Windows is based on the CoreAudioUtil class in Chrome. CoreAudioUtil in Chrome does not use a special string to identify the Default Communication device but instead a combination of a string (Default) and a role parameter [1]. When CoreAudioUtil was ported to WebRTC, I accidentally added an invalid usage of a unique string to identify the default comm device and it can lead to errors since there are then two different ways to identify this device. It will also complicate life when we want to merge changes from Chrome into WebRTC. This CL removes usage of AudioDeviceName::kDefaultCommunicationsDeviceId in WebRTC to reduce the risk of errors. [1] https://cs.chromium.org/chromium/src/media/audio/win/core_audio_util_win.cc?q=core_audio_ut&sq=package:chromium&g=0&l=464 Excluding flaky bot win_x86_msvc_dbg and using Tbr. Tbr: thaloun@chromium.org No-Try: True Bug: webrtc:11107 Change-Id: Ie6687adbe9c3940a217456e4025967f71d86214c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160047 Commit-Queue: Henrik Andreassson <henrika@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29848}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: http://build.chromium.org/p/client.webrtc
- Coding style guide
- Code of conduct