7cbe88767b
Change default adaptive ptime min bitrate to 16kbps.
...
This is to allow FEC to be encoded at the lowest bitrate.
Bug: chromium:1086942
Change-Id: I1d30276a9a2aaa80016250dc786d5d867ba6cd10
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212501
Commit-Queue: Jakob Ivarsson <jakobi@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Reviewed-by: Minyue Li <minyue@webrtc.org >
Reviewed-by: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/master@{#33539}
2021-03-23 11:31:49 +00:00
f0adf38d51
Fix timestamps for the remote outbound audio stream stats
...
The timestamps must correspond to the time elapsed since the Unix epoch
and not since Jan 1 1900 (which is used by the RTCP SRs).
Bug: webrtc:12529,webrtc:12605
Change-Id: I6013cf3d9bf9915b5f5db8661f7b2b84231cca57
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212606
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Sam Zackrisson <saza@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33538}
2021-03-23 10:53:59 +00:00
3889de1c4c
Support native scaling of VideoFrameBuffers in LibvpxVp8Encoder.
...
This is a follow-up to the VP9, fixing VP8 this time. Context again:
This CL is part of Optimized Scaling efforts. In Chromium, the native
frame buffer is getting an optimized CropAndScale() implementation. To
support HW accelerated scaling, returning pre-scaled images and skipping
unnecessary intermediate downscales, WebRTC needs to 1) use CropAndScale
instead of libyuv::XXXXScale and 2) only map buffers it actually intends
to encode.
- To achieve this, WebRTC encoders are updated to map kNative video
buffers so that in a follow-up CL VideoStreamEncoder can stop mapping
intermediate buffer sizes.
Bug: webrtc:12469, chromium:1157072
Change-Id: I026527ae77e36f66d02e149ad6fe304f6a8ccb05
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212600
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Evan Shrubsole <eshr@google.com >
Cr-Commit-Position: refs/heads/master@{#33537}
2021-03-23 09:08:58 +00:00
6a6715042a
Move RtpFrameReferenceFinder out of video_coding namespace.
...
Namespace used because of copy-pasting an old pattern, should never have been used in the first place. Removing it now to make followup refactoring prettier.
Bug: webrtc:12579
Change-Id: I00a80958401cfa368769dc0a1d8bbdd76aaa4ef5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212603
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Commit-Queue: Philip Eliasson <philipel@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33536}
2021-03-23 08:48:37 +00:00
2ba32f3423
Delete AsyncInvoker usage in TurnServer
...
Bug: webrtc:12339
Change-Id: Ibcc5d9d5b5abf0d926290e3164f60dd46c0b460b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212666
Reviewed-by: Taylor <deadbeef@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33535}
2021-03-23 08:01:00 +00:00
a9ba450339
stats: add address as alias for ip
...
this was renamed in https://github.com/w3c/webrtc-pc/issues/1913 and https://github.com/w3c/webrtc-stats/pull/381
Spec: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-address
BUG=chromium:968203
Change-Id: If75849fe1dc87ada6850e7b64aa8569e13baf0d8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212681
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/master@{#33534}
2021-03-23 06:29:10 +00:00
e2ac591c0d
Update WebRTC code version (2021-03-23T04:03:37).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I5ce88d419a3f5d7c930185746a2b82fbd0d4ce2d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212844
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33533}
2021-03-23 06:02:50 +00:00
1cdbabde53
Update WgcCaptureSession to handle portrait oriented screen capture.
...
WgcCaptureSession would crash when copying the frame data for an image
from a portrait oriented monitor. This is because we were using the
height of the image multiplied by the rowpitch of the buffer to
determine the size of the data to be copied. However, in portrait
mode the height measures the same dimension as the rowpitch, leading
to us overrunning the frame buffer.
The fix is to use the height and width of the image multiplied by
the number of bytes per pixel to determine how much data to copy
out of the buffer, and only use the rowpitch to advance the pointer
in the source data buffer. This has the added benefit of giving us
contiguous data, reducing the size of the DesktopFrame that we output.
Bug: webrtc:12490
Change-Id: I4c26f8864cb57ac566a742af70fea1da504b9706
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/209501
Reviewed-by: Joe Downing <joedow@chromium.org >
Commit-Queue: Austin Orion <auorion@microsoft.com >
Cr-Commit-Position: refs/heads/master@{#33532}
2021-03-22 20:50:50 +00:00
e0059dc4ad
Roll chromium_revision b7f0a0c111..c0436807ae (865116:865247)
...
Change log: b7f0a0c111..c0436807ae
Full diff: b7f0a0c111..c0436807ae
Changed dependencies
* src/base: ce392ef26f..8d5e7ce339
* src/build: 120a8d610c..7ce3b71efa
* src/ios: e4c6cd619a..0f60053c1f
* src/testing: 38ceae6941..5515895a0f
* src/third_party: 0819985359..9dec2334e3
* src/third_party/androidx: qVuvMdiLCD8N4Fl_eGCJnsGXwtgHVnJEdUbokvTqvssC..c1XqVP7XC51iTS4Zs03SWVTsz5AdCYHK01o4IsyEC0MC
* src/third_party/perfetto: 024ea24c78..0c50637320
* src/tools: 53c3bb6e60..4c1d963f3e
DEPS diff: b7f0a0c111..c0436807ae
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I8534f0d93d8f81ab0add90faeb62d9b9b67645a5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212801
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33531}
2021-03-22 18:57:43 +00:00
c366d51836
Fix unit for inbound RTP stat lastPacketReceivedTimestamp
(s -> ms)
...
Both inbound RTP stats `estimatedPlayoutTimestamp` and
`lastPacketReceivedTimestamp` are surfaced to JS land as
`DOMHighResTimeStamp` - i.e., time values in milliseconds.
This CL fixes `lastPacketReceivedTimestamp` which is incorrectly
surfaced as time value in seconds.
Bug: webrtc:12605
Change-Id: I290103071cca3331d2a3066b6b6b9fcb4f4fd0af
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212742
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33530}
2021-03-22 18:47:33 +00:00
c303f82f4d
Add new owners for sdk/android.
...
Bug: None
Change-Id: Ia47050e178e696b5374513f5ec9a00fff4a1cd34
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212618
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Carolina Sartorius <sartorius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33529}
2021-03-22 15:48:52 +00:00
464bcd4502
Revert "Reland "[Battery]: Delay start of TaskQueuePacedSender.""
...
This reverts commit dd4d5e36c6205457add1fd9df9061ca60d315fe7.
Reason for revert: crashes due to uninitialized pacing_bitrate_
crbug.com/1190547
Original change's description:
> Reland "[Battery]: Delay start of TaskQueuePacedSender."
>
> This is a reland of 89cb65ed663a9000b9f7c90a78039bd85731e9ae
> Reason for revert: failing trybots: https://ci.chromium.org/ui/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win8%20Tester/7757/overview
>
> Original change's description:
> > [Battery]: Delay start of TaskQueuePacedSender.
> >
> > To avoid unnecessary repeating tasks, TaskQueuePacedSender is started
> > only upon RtpTransportControllerSend::EnsureStarted().
> >
> > More specifically, the repeating task happens in
> > TaskQueuePacedSender::MaybeProcessPackets() every 500ms, using a self
> > task_queue_.PostDelayedTask().
> >
> > Bug: chromium:1152887
> > Change-Id: I72c96d2c4b491d5edb45a30b210b3797165cbf48
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208560
> > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
> > Reviewed-by: Henrik Boström <hbos@webrtc.org >
> > Reviewed-by: Erik Språng <sprang@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#33421}
>
> Bug: chromium:1152887
> Change-Id: Ia4fae13294472160e2dff40738b6fd245700beeb
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211920
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Reviewed-by: Artem Titov <titovartem@webrtc.org >
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
> Cr-Commit-Position: refs/heads/master@{#33491}
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: chromium:1152887, chromium:1190547
Change-Id: I8ce3ba2fee8a38f918e20db953ce1c4b923cdd18
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212700
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
Reviewed-by: Erik Språng <sprang@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33528}
2021-03-22 14:46:06 +00:00
efad89cb58
Roll chromium_revision 23141e38f1..b7f0a0c111 (864556:865116)
...
Change log: 23141e38f1..b7f0a0c111
Full diff: 23141e38f1..b7f0a0c111
Changed dependencies
* src/base: cff6aa74fa..ce392ef26f
* src/build: 100ae19f99..120a8d610c
* src/ios: e84bee050b..e4c6cd619a
* src/testing: 55b74c093b..38ceae6941
* src/third_party: e90289cdba..0819985359
* src/third_party/androidx: HrObtBeHuh5R3OZF1qqHNjQl38HI9tJTa3qDEcySZVoC..qVuvMdiLCD8N4Fl_eGCJnsGXwtgHVnJEdUbokvTqvssC
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c730daef75..999f35f30e
* src/third_party/depot_tools: e7c0581740..392c407b55
* src/third_party/libunwindstack: 11659d420a..aab2c87473
* src/third_party/perfetto: f22dda1544..024ea24c78
* src/tools: 57aabd656c..53c3bb6e60
* src/tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:e567b4580a0854199f30444e583c17ee65abcc10
* src/tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:e567b4580a0854199f30444e583c17ee65abcc10
* src/tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:e567b4580a0854199f30444e583c17ee65abcc10
DEPS diff: 23141e38f1..b7f0a0c111
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I58171e1ca03305581f623b8e1d317660d559b0b6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212636
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33527}
2021-03-22 13:36:40 +00:00
bd9e4a95eb
Support native scaling of VideoFrameBuffers in LibvpxVp9Encoder.
...
This CL is part of Optimized Scaling efforts. In Chromium, the native
frame buffer is getting an optimized CropAndScale() implementation. To
support HW accelerated scaling, returning pre-scaled images and skipping
unnecessary intermediate downscales, WebRTC needs to 1) use CropAndScale
instead of libyuv::XXXXScale and 2) only map buffers it actually intends
to encode.
- To achieve this, WebRTC encoders are updated to map kNative video
buffers so that in a follow-up CL VideoStreamEncoder can stop mapping
intermediate buffer sizes.
In this CL LibvpxVp9Encoder is updated to map kNative buffers of pixel
formats it supports and convert ToI420() if the kNative buffer is
something else. A fake native buffer that keeps track of which
resolutions were mapped, MappableNativeBuffer, is added.
Because VP9 is currently an SVC encoder and not a simulcast encoder, it
does not need to invoke CropAndScale.
This CL also fixes MultiplexEncoderAdapter, but because it simply
forwards frames it only cares about the pixel format when
|supports_augmented_data_| is true so this is the only time we map it.
Because this encoder is not used with kNative in practise, we don't care
to make this path optimal.
Bug: webrtc:12469, chromium:1157072
Change-Id: I74edf85b18eccd0d250776bbade7a6444478efce
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212580
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Evan Shrubsole <eshr@google.com >
Cr-Commit-Position: refs/heads/master@{#33526}
2021-03-22 13:35:35 +00:00
2ff25db72a
Update apply-iwyu tool to report compile errors
...
Note: apply-iwyu on a lone .h file *will* fail due to c++/c confusion.
Bug: none
Change-Id: I3dda0df28cd4ec85ecb895efed1b04c3d70343bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212680
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Harald Alvestrand <hta@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33525}
2021-03-22 13:01:56 +00:00
ffb7603b60
Delete TurnPort usage of AsyncInvoker
...
Bug: webrtc:12339
Change-Id: I098b5f4b58c3ac0c275157c0c9d5a280b1cbef97
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212440
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Taylor <deadbeef@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33524}
2021-03-22 12:56:26 +00:00
eb282985e9
Update rsid and mid spec links from draft to release version
...
No-Try: true
Bug: None
Change-Id: Iae39f6253357870d775cfa4ce918a756ab1fdc4a
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212614
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33523}
2021-03-22 12:24:00 +00:00
47350c2dba
Reland "Triggering CI."
...
This reverts commit 50d79babcd37e0de20d9333f6dee9c789dc841e7.
Reason for revert: Triggering bots.
Original change's description:
> Revert "Triggering CI."
>
> This reverts commit c73257651b221585798dc46ec539f94f332500b6.
>
> Reason for revert: Triggering CI.
>
> Original change's description:
> > Triggering CI.
> >
> > TBR=titovartem@webrtc.org
> >
> > No-Try: True
> > Bug: None
> > Change-Id: I215faab15d178ba5e76daa14e07028eae2ce220e
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212641
> > Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> > Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> > Cr-Commit-Position: refs/heads/master@{#33514}
>
> TBR=mbonadei@webrtc.org ,titovartem@webrtc.org
>
> Change-Id: Ia44aaacbad3f6acfee7930b06914114d422eded8
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: None
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212667
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#33520}
# Not skipping CQ checks because this is a reland.
TBR=titovartem@webrtc.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Change-Id: I029804475912012a17c936a9cec5cd34d6eb1bc8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212668
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33522}
2021-03-22 11:57:23 +00:00
f412976eca
Provide a default implementation of NV12BufferInterface::CropAndScale.
...
This avoids falling back on the VideoFrameBuffer::CropAndScale default
implementation which performs ToI420. This has two major benefits:
1. We save CPU by not converting to I420 for NV12 frames.
2. We make is possible for simulcast encoders to use Scale() and be
able to trust that the scaled simulcast layers have the same pixel
format as the top layer, which is required by libvpx.
In order to invoke NV12Buffer::CropAndScaleFrom() without introducing a
circular dependency, nv12_buffer.[h/cc] is moved to the "video_frame"
build target.
Bug: webrtc:12595, webrtc:12469
Change-Id: I81aac5c6b3e81c49f32a7be6dc2640e6b40f7692
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212643
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Reviewed-by: Evan Shrubsole <eshr@google.com >
Commit-Queue: Henrik Boström <hbos@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33521}
2021-03-22 11:09:36 +00:00
50d79babcd
Revert "Triggering CI."
...
This reverts commit c73257651b221585798dc46ec539f94f332500b6.
Reason for revert: Triggering CI.
Original change's description:
> Triggering CI.
>
> TBR=titovartem@webrtc.org
>
> No-Try: True
> Bug: None
> Change-Id: I215faab15d178ba5e76daa14e07028eae2ce220e
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212641
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#33514}
TBR=mbonadei@webrtc.org ,titovartem@webrtc.org
Change-Id: Ia44aaacbad3f6acfee7930b06914114d422eded8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212667
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33520}
2021-03-22 11:04:08 +00:00
0a104c4c2d
Delete obsolete method EncodedImage::Retain()
...
Bug: webrtc:9378
Change-Id: I7ba4a3842e9d9d107b920b2e5daec2c5cb23fb8e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212602
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33519}
2021-03-22 10:30:13 +00:00
6f7e205529
Delete AsyncInvoker usage from StunProber
...
Bug: webrtc:12339
Change-Id: I643a06a26d5aa38e135c252d5b71aee3d073ea3b
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212504
Reviewed-by: Taylor <deadbeef@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33518}
2021-03-22 09:58:24 +00:00
ebd20109f0
Check if ifa_addr field is null.
...
This field can be null. See e.g. https://man7.org/linux/man-pages/man3/getifaddrs.3.html
Bug: webrtc:12523
Change-Id: I63ba297d0c57b3b70c545d1434716094d8ce20a4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212601
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Björn Terelius <terelius@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33517}
2021-03-22 09:41:27 +00:00
76b51e21bc
Improve thread annotations for TurnServer
...
Bug: webrtc:12339
Change-Id: I317485a392ad6cdf77ebf4ea8a7066f8ba0245bb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212502
Reviewed-by: Taylor <deadbeef@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33516}
2021-03-22 09:09:57 +00:00
2f5f5fa171
standalone ice transport: dont use component 0
...
0 is not valid per https://tools.ietf.org/html/rfc5245#section-15.1 which says
<component-id>: is a positive integer between 1 and 256
This is part of the RTCIceTransport extension API which is probably going away.
BUG=chromium:1044875
Change-Id: I56d8dec79d3191e084f4a25a2c0a4d0b67afde74
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212642
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com >
Cr-Commit-Position: refs/heads/master@{#33515}
2021-03-22 06:42:15 +00:00
c73257651b
Triggering CI.
...
TBR=titovartem@webrtc.org
No-Try: True
Bug: None
Change-Id: I215faab15d178ba5e76daa14e07028eae2ce220e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212641
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33514}
2021-03-21 19:10:30 +00:00
8bf1cd1c66
Rename (packets|bytes)_dropped to (packets|bytes)_discarded_no_receiver
...
Rename (packets|bytes)_dropped to (packets|bytes)_discarded_no_receiver
in PC level framework based tests to make it more clear for metric means.
Bug: None
Change-Id: I8d36f5d03399ad40cd367bb65410ff97a0616d4e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212611
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33513}
2021-03-20 14:47:49 +00:00
eecc4f5e7c
Fix: when SamplesStatsCounter is empty it's not propagated to the Histogram perf output
...
Bug: None
Change-Id: I5664c39ed702b8ca581d28a08900f7a7d435d6ac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212610
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Commit-Queue: Artem Titov <titovartem@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33512}
2021-03-20 14:05:59 +00:00
2bab0efee4
Update WebRTC code version (2021-03-20T04:03:21).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I0fc6a3f7ebfa2c97c077038808032d3aceaf1c75
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212569
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33511}
2021-03-20 05:38:27 +00:00
490c1503d9
Delete unowned buffer in EncodedImage.
...
Bug: webrtc:9378
Change-Id: Ice48020c0f14905cbc185b52c88bbb9ac3bb4c93
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/128575
Reviewed-by: Philip Eliasson <philipel@webrtc.org >
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33510}
2021-03-19 14:12:28 +00:00
2b250734da
Delete FakeIceTransport usage of AsyncInvoker
...
Bug: webrtc:12339
Change-Id: I1656bef5178dd150f5069d743ea7236dc0cb0300
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212500
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Tommi <tommi@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33509}
2021-03-19 10:05:13 +00:00
ef7d61ed1c
Update WebRTC code version (2021-03-19T04:04:06).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: I350e7a652c3ed3170f4f69536d58e6275c148d14
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212563
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33508}
2021-03-19 06:09:10 +00:00
ba3e6c29e2
Roll chromium_revision 5f1d8e0c95..23141e38f1 (864439:864556)
...
Change log: 5f1d8e0c95..23141e38f1
Full diff: 5f1d8e0c95..23141e38f1
Changed dependencies
* src/base: 3c77df1c30..cff6aa74fa
* src/build: 866b8dab2e..100ae19f99
* src/ios: f519acb9be..e84bee050b
* src/testing: 57deb8e7a1..55b74c093b
* src/third_party: 5e9fc8bb56..e90289cdba
* src/third_party/androidx: YW8CKR7AhVJkpWoV2s_HL1thW4I7c7xoxj3BGA3mHYgC..HrObtBeHuh5R3OZF1qqHNjQl38HI9tJTa3qDEcySZVoC
* src/third_party/depot_tools: 2737963b46..e7c0581740
* src/tools: 1206afd020..57aabd656c
DEPS diff: 5f1d8e0c95..23141e38f1
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Idcec2bd8c982caa9953e6337cad1aa1ce6e7f957
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212562
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33507}
2021-03-19 05:07:58 +00:00
18b0947023
Roll chromium_revision 6bb9b62b86..5f1d8e0c95 (864335:864439)
...
Change log: 6bb9b62b86..5f1d8e0c95
Full diff: 6bb9b62b86..5f1d8e0c95
Changed dependencies
* src/base: dc354a44fb..3c77df1c30
* src/build: 39d6c25941..866b8dab2e
* src/buildtools/third_party/libc++abi/trunk: c93be42a40..4e078437d0
* src/ios: 2e936f4702..f519acb9be
* src/testing: 1c045f6e5e..57deb8e7a1
* src/third_party: f76bc49aa6..5e9fc8bb56
* src/third_party/perfetto: 634775413f..f22dda1544
* src/third_party/r8: p8MxOkeoVbwFeWnyTIOV5apfrUkcEo5Mq0bGVQtF82IC..TNGssqzExjlZ_AG4P92Hje4YYbM8o_TMSLQeRxrAB-8C
* src/tools: 142c3c0c55..1206afd020
DEPS diff: 6bb9b62b86..5f1d8e0c95
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I78a958df9157737e2a5c015bb43ad45e7dabe6dd
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212540
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33506}
2021-03-18 23:35:08 +00:00
3328761741
Roll chromium_revision 74fb21b370..6bb9b62b86 (864218:864335)
...
Change log: 74fb21b370..6bb9b62b86
Full diff: 74fb21b370..6bb9b62b86
Changed dependencies
* src/base: e0d6dce37e..dc354a44fb
* src/ios: f68e2a3229..2e936f4702
* src/testing: abb650f2ba..1c045f6e5e
* src/third_party: fcafd6eced..f76bc49aa6
* src/third_party/androidx: i0GHnYjbnrO5uPFUhN_LTY-OldhEXfimO5qHglFC5fwC..YW8CKR7AhVJkpWoV2s_HL1thW4I7c7xoxj3BGA3mHYgC
* src/tools: dde895601c..142c3c0c55
DEPS diff: 74fb21b370..6bb9b62b86
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I7e7866bf20ce543417e53d123804f08bf9c81ac6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212520
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33505}
2021-03-18 19:00:54 +00:00
d6d2a29792
Roll chromium_revision a1e978b5ab..74fb21b370 (864105:864218)
...
Change log: a1e978b5ab..74fb21b370
Full diff: a1e978b5ab..74fb21b370
Changed dependencies
* src/base: 0fb68da7d7..e0d6dce37e
* src/build: ff9d9ded7e..39d6c25941
* src/ios: 42bc686f49..f68e2a3229
* src/testing: 4901239ff2..abb650f2ba
* src/third_party: 2319446232..fcafd6eced
* src/third_party/androidx: 65fRug8cVwh3hU__E3A3qq1_ITouFc9LU--TbqTw714C..i0GHnYjbnrO5uPFUhN_LTY-OldhEXfimO5qHglFC5fwC
* src/third_party/perfetto: 371d8955a1..634775413f
* src/tools: bc8d59ca85..dde895601c
DEPS diff: a1e978b5ab..74fb21b370
/DEPS
Clang version changed llvmorg-13-init-3462-gfe5c2c3c:llvmorg-13-init-4720-g7bafe336
Details: a1e978b5ab..74fb21b370
/tools/clang/scripts/update.py
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ie52dc27a0d9f58d43087fed321e6ffc280845756
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212481
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33504}
2021-03-18 15:34:33 +00:00
c780605f6f
Make num_encoded_channels_ atomic
...
Ensures that the value read by the audio thread is well-defined.
Bug: b/176104610
Change-Id: I15d1901522be79703b3dc188fbe03c752be09a60
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212442
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org >
Reviewed-by: Per Åhgren <peah@webrtc.org >
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33503}
2021-03-18 15:26:23 +00:00
049e6113a8
Add missing EXPECT_CALL for RTCStatsCollectorTest
tests
...
Bug: webrtc:12529
Change-Id: I89e90f48ebcf5e4085c6a8403d733f416f27e6a0
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212441
Reviewed-by: Henrik Boström <hbos@webrtc.org >
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33502}
2021-03-18 12:52:42 +00:00
0848994ad8
Replace AsyncInvoker with PostDelayedTask, in DtmfSender
...
And add thread annotations.
Bug: webrtc:12339
Change-Id: I5c945b3f5f3f6490dff3040bd26cec035b6660ff
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212025
Commit-Queue: Niels Moller <nisse@webrtc.org >
Reviewed-by: Taylor <deadbeef@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33501}
2021-03-18 10:21:00 +00:00
92430888fd
Add thread annotations to FakeIceTransport
...
Bug: webrtc:12339
Change-Id: I29f5c910c60155cbb48c686e77b02ad3aa761fb1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211665
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33500}
2021-03-18 09:57:00 +00:00
035747712f
Delete use of AsyncInvoker from FakePacketTransport
...
Bug: webrtc:12339
Change-Id: Ia9a5568b576b9a95ed9e1326f38fb68a8581dc88
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211981
Reviewed-by: Taylor <deadbeef@webrtc.org >
Commit-Queue: Niels Moller <nisse@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33499}
2021-03-18 09:07:20 +00:00
cbadb8bcab
Expose offerExtmapAllowMixed in iOS SDK.
...
Bug: None
Change-Id: Ic14d1f005b6c727b509492399901d822bd6950db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212280
Commit-Queue: Kári Helgason <kthelgason@webrtc.org >
Reviewed-by: Kári Helgason <kthelgason@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33498}
2021-03-18 08:54:11 +00:00
426d679886
Update WebRTC code version (2021-03-18T04:03:50).
...
TBR=webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com ,mbonadei@webrtc.org
Bug: None
Change-Id: Ia0ef229c0c85d5c3e98b0e3bd6cec5a8223def9e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212402
Reviewed-by: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33497}
2021-03-18 05:57:37 +00:00
b9a6c03d7e
Roll chromium_revision 345f2fb2f5..a1e978b5ab (863976:864105)
...
Change log: 345f2fb2f5..a1e978b5ab
Full diff: 345f2fb2f5..a1e978b5ab
Changed dependencies
* src/base: 1326e07a78..0fb68da7d7
* src/build: 50f68d60a1..ff9d9ded7e
* src/ios: af1c51c165..42bc686f49
* src/testing: 6d26badea8..4901239ff2
* src/third_party: 5ef7057576..2319446232
* src/third_party/androidx: xIdmDAvhfStt7ky1enCv_j6NNXqdhajuI8563NJ3QekC..65fRug8cVwh3hU__E3A3qq1_ITouFc9LU--TbqTw714C
* src/third_party/breakpad/breakpad: d6a6f52606..dff7d5afd5
* src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/629e117d9b..c730daef75
* src/tools: 9bd466f422..bc8d59ca85
* src/tools/luci-go: git_revision:e81c0c9c528d0a416922e4ccd958d0de59a64816..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d
* src/tools/luci-go: git_revision:e81c0c9c528d0a416922e4ccd958d0de59a64816..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d
* src/tools/luci-go: git_revision:e81c0c9c528d0a416922e4ccd958d0de59a64816..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d
DEPS diff: 345f2fb2f5..a1e978b5ab
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: Ia6e52b4128bcd7a2f587f1ddd8362d501d266a6c
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212401
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33496}
2021-03-18 05:03:27 +00:00
5a23b3d08c
Roll chromium_revision ca2293bd17..345f2fb2f5 (863854:863976)
...
Change log: ca2293bd17..345f2fb2f5
Full diff: ca2293bd17..345f2fb2f5
Changed dependencies
* src/base: 3f7efbf9e1..1326e07a78
* src/build: 2e22b6d06b..50f68d60a1
* src/ios: 56d5aa0f85..af1c51c165
* src/testing: f83b428d45..6d26badea8
* src/third_party: f2ef9d89aa..5ef7057576
* src/third_party/depot_tools: 36de4be91e..2737963b46
* src/tools: c624ebd1f0..9bd466f422
* src/tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:e81c0c9c528d0a416922e4ccd958d0de59a64816
* src/tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:e81c0c9c528d0a416922e4ccd958d0de59a64816
* src/tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:e81c0c9c528d0a416922e4ccd958d0de59a64816
DEPS diff: ca2293bd17..345f2fb2f5
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I70ed62f14b2012d07af3354d930dc664358ffad4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212360
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33495}
2021-03-17 23:12:28 +00:00
f8776cba62
Revert "AV1: Use Default TX type for encoding"
...
This reverts commit b0dc518f82b2a50c1b3e3062d3b58ee221d2e028.
Reason for revert: corresponding change https://chromium-review.googlesource.com/c/chromium/src/+/2765225 from chromium has not been backported to webrtc yet.
Original change's description:
> AV1: Use Default TX type for encoding
>
> This will further speed up intra frame encoding
>
> Bug: None
> Change-Id: I1a105c6d2cdd9dc82f84d0039dbea3f0d090ab93
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212320
> Reviewed-by: Marco Paniconi <marpan@webrtc.org >
> Commit-Queue: Fyodor Kyslov <kyslov@google.com >
> Cr-Commit-Position: refs/heads/master@{#33492}
TBR=jianj@google.com ,marpan@webrtc.org ,kyslov@google.com
Change-Id: I7ff93537942ab34706db0b71c6b5f8535209619d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212340
Reviewed-by: Andrey Logvin <landrey@webrtc.org >
Commit-Queue: Fyodor Kyslov <kyslov@google.com >
Cr-Commit-Position: refs/heads/master@{#33494}
2021-03-17 19:16:50 +00:00
db01a82ff2
Roll chromium_revision 5371070da9..ca2293bd17 (863745:863854)
...
Change log: 5371070da9..ca2293bd17
Full diff: 5371070da9..ca2293bd17
Changed dependencies
* src/base: 3bbd658686..3f7efbf9e1
* src/build: a8fc514621..2e22b6d06b
* src/ios: a532c657e9..56d5aa0f85
* src/testing: abdf5bd723..f83b428d45
* src/third_party: b4d3774855..f2ef9d89aa
* src/third_party/androidx: ZvXzCmnbaONNhr6d8cbYTREJiadk9QBhBCm1foVA0nAC..xIdmDAvhfStt7ky1enCv_j6NNXqdhajuI8563NJ3QekC
* src/third_party/perfetto: a575cd672d..371d8955a1
* src/tools: 09f0df6f24..c624ebd1f0
DEPS diff: 5371070da9..ca2293bd17
/DEPS
No update to Clang.
TBR=chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com ,
BUG=None
Change-Id: I9d97fc3adae487f95fb120393026ec2914f8abf4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212321
Reviewed-by: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com >
Cr-Commit-Position: refs/heads/master@{#33493}
2021-03-17 18:44:33 +00:00
b0dc518f82
AV1: Use Default TX type for encoding
...
This will further speed up intra frame encoding
Bug: None
Change-Id: I1a105c6d2cdd9dc82f84d0039dbea3f0d090ab93
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212320
Reviewed-by: Marco Paniconi <marpan@webrtc.org >
Commit-Queue: Fyodor Kyslov <kyslov@google.com >
Cr-Commit-Position: refs/heads/master@{#33492}
2021-03-17 18:43:28 +00:00
dd4d5e36c6
Reland "[Battery]: Delay start of TaskQueuePacedSender."
...
This is a reland of 89cb65ed663a9000b9f7c90a78039bd85731e9ae
Reason for revert: failing trybots: https://ci.chromium.org/ui/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Win8%20Tester/7757/overview
Original change's description:
> [Battery]: Delay start of TaskQueuePacedSender.
>
> To avoid unnecessary repeating tasks, TaskQueuePacedSender is started
> only upon RtpTransportControllerSend::EnsureStarted().
>
> More specifically, the repeating task happens in
> TaskQueuePacedSender::MaybeProcessPackets() every 500ms, using a self
> task_queue_.PostDelayedTask().
>
> Bug: chromium:1152887
> Change-Id: I72c96d2c4b491d5edb45a30b210b3797165cbf48
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/208560
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
> Reviewed-by: Henrik Boström <hbos@webrtc.org >
> Reviewed-by: Erik Språng <sprang@webrtc.org >
> Cr-Commit-Position: refs/heads/master@{#33421}
Bug: chromium:1152887
Change-Id: Ia4fae13294472160e2dff40738b6fd245700beeb
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211920
Reviewed-by: Erik Språng <sprang@webrtc.org >
Reviewed-by: Artem Titov <titovartem@webrtc.org >
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org >
Cr-Commit-Position: refs/heads/master@{#33491}
2021-03-17 16:10:02 +00:00
32af25b72a
Disable more flaky PeerConnectionIntegrationTests on Windows
...
Bug: webrtc:12590, webrtc:12591
Change-Id: Id7703d6eb0c898789fa99216635578d5cf188c74
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212085
Reviewed-by: Harald Alvestrand <hta@webrtc.org >
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org >
Cr-Commit-Position: refs/heads/master@{#33490}
2021-03-17 14:54:41 +00:00